From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405E1C43603 for ; Thu, 12 Dec 2019 04:45:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1182C21655 for ; Thu, 12 Dec 2019 04:45:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="b6SBIvR0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1182C21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A18CB6EC4E; Thu, 12 Dec 2019 04:45:35 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 43AD06EC4E for ; Thu, 12 Dec 2019 04:45:34 +0000 (UTC) X-UUID: 23546b1eccb14db899646099425c2d11-20191212 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=v9ZqsgXk9NozG0fT4n7QDFC2xDWiIZjiiZ5zEyF6I8c=; b=b6SBIvR0JKBoKsN1OOfx4W6wTthZbZ9A46X7KGYwcRJfKQ3NkjjOJSA1TjSr+2dlPC1VJCh/LOQiHDPOIPiXGPZi0jvGQUyeHtb0uDQU5h00ux84nN0TZjQ6GK809SMXFLqlgJ6AZASx5wj6RIhszB+f9gLK1jCgaL6gH0hmXIc=; X-UUID: 23546b1eccb14db899646099425c2d11-20191212 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1853379524; Thu, 12 Dec 2019 12:45:29 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Dec 2019 12:45:44 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Dec 2019 12:45:23 +0800 Message-ID: <1576125928.29693.1.camel@mtksdaap41> Subject: Re: [PATCH 2/2] Turn off Alpha bit when plane format has no alpha From: CK Hu To: Mark Yacoub Date: Thu, 12 Dec 2019 12:45:28 +0800 In-Reply-To: <20191211154901.176256-2-markyacoub@google.com> References: <20191211154901.176256-1-markyacoub@google.com> <20191211154901.176256-2-markyacoub@google.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniele Castagna , David Airlie , dri-devel@lists.freedesktop.org, Sean Paul , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Mark: On Wed, 2019-12-11 at 10:49 -0500, Mark Yacoub wrote: > drm/mediatek: Add OVL_CON_ALPHA only when the plane format has_alpha. > > This change enables XR24 format to be displayed as an overlay on top of > the primary plane. Reviewed-by: CK Hu > > Suggested-by: Sean Paul > To: CK Hu > To: dri-devel@lists.freedesktop.org > Cc: Daniele Castagna > Cc: Philipp Zabel > Cc: David Airlie > Cc: Daniel Vetter > Cc: Matthias Brugger > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Signed-off-by: Mark Yacoub > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 526b595eeff9..a7851756dddf 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -266,7 +266,7 @@ static void mtk_ovl_layer_config(struct mtk_ddp_comp *comp, unsigned int idx, > } > > con = ovl_fmt_convert(ovl, fmt); > - if (idx != 0) > + if (state->base.fb->format->has_alpha) > con |= OVL_CON_AEN | OVL_CON_ALPHA; > > if (pending->rotation & DRM_MODE_REFLECT_Y) { _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel