From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B19A8C43603 for ; Wed, 18 Dec 2019 05:41:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77BCD20733 for ; Wed, 18 Dec 2019 05:41:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="twhGNb1s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77BCD20733 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A333D6E22B; Wed, 18 Dec 2019 05:41:41 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id 188346E226 for ; Wed, 18 Dec 2019 05:41:39 +0000 (UTC) X-UUID: 10f94fa4800b4bf3982b3b0e977d1c0a-20191218 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=kekEdDqgpJakyxhI05Eo5niVp+Cj3bY7GT/GLsY78ko=; b=twhGNb1sxlKvoEm59N9ojZB5ckhYNTdiM14CQJ3u2WENm8P0yzrVLnt3nc9KLCqDzOmGBOSqIESHIJ1qpsnpKzi3+jgIu3ShWDYUUssmwuTwMfJq6E7uuNB364uAhKqwmv688LLvIUjEOHDbWFYzxiNG4aMzE+2D15dvZAt2NSY=; X-UUID: 10f94fa4800b4bf3982b3b0e977d1c0a-20191218 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1470846705; Wed, 18 Dec 2019 13:41:35 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 18 Dec 2019 13:41:00 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 18 Dec 2019 13:40:39 +0800 Message-ID: <1576647693.15003.11.camel@mtksdaap41> Subject: Re: [PATCH 1/4] dt-binds: display: mediatek: add property to control mipi tx drive current From: CK Hu To: Jitao Shi Date: Wed, 18 Dec 2019 13:41:33 +0800 In-Reply-To: <20191216082937.119164-2-jitao.shi@mediatek.com> References: <20191216082937.119164-1-jitao.shi@mediatek.com> <20191216082937.119164-2-jitao.shi@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 1DA0C317F4B4323403052D3798DC4C90F37261A92771694E211F6DEDF72998F82000:8 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: srv_heupstream@mediatek.com, David Airlie , stonea168@163.com, cawa.cheng@mediatek.com, dri-devel@lists.freedesktop.org, sj.huang@mediatek.com, linux-mediatek@lists.infradead.org, Matthias Brugger , yingjoe.chen@mediatek.com, eddie.huang@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Jitao: On Mon, 2019-12-16 at 16:29 +0800, Jitao Shi wrote: > Add a property to control mipi tx drive current: > "mipitx-current-drive" > > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > index a19a6cc375ed..780201ddcd5c 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > @@ -33,6 +33,9 @@ Required properties: > - #clock-cells: must be <0>; > - #phy-cells: must be <0>. > > +Optional properties: > +- mipitx-current-drive: adjust driving current, should be 1 ~ 0xF > + In "[PATCH 3/4] drm/mediatek: add the mipitx driving control" [1], I see that you actually control a register its name is MIPITX_VOLTAGE_SEL, so I guess this control the voltage. If mipi_tx has the ability to control the voltage, could we just treat mipi_tx as a regulator? For a regulator, regulator-min-microvolt and regulator-max-microvolt would limit the volt range and you could get it by of_get_regulator_init_data(). If it actually control the current, regulator-min-microamp and regulator-max-microamp could be used. I'm not expert on this, so please give me more information on this. [1] http://lists.infradead.org/pipermail/linux-mediatek/2019-December/025638.html Regards, CK > Example: > > mipi_tx0: mipi-dphy@10215000 { > @@ -42,6 +45,7 @@ mipi_tx0: mipi-dphy@10215000 { > clock-output-names = "mipi_tx0_pll"; > #clock-cells = <0>; > #phy-cells = <0>; > + mipitx-current-drive = <0x8>; > }; > > dsi0: dsi@1401b000 { _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel