From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A06C2D0C0 for ; Mon, 23 Dec 2019 08:59:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF21B206D3 for ; Mon, 23 Dec 2019 08:59:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="c1jKL4cT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF21B206D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C3B7789FCC; Mon, 23 Dec 2019 08:59:44 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 1378389FCC for ; Mon, 23 Dec 2019 08:59:42 +0000 (UTC) X-UUID: fdbe423be5424ef0b7b0a6fa0cef7895-20191223 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=GIxkr6Z3J7HgwOFSpLaPB2mv26seiJrHqASnjdQ/WuM=; b=c1jKL4cTWnGtOxIq36oOVI39ctbinDcNdvG/SnInr75JnU8Xvp9tSrrTEwttbrLIW36IXiT07fliI3/ncn99PJdV0Xva0MAe6szb/mHs1GC4NpxlN3WSmlZRIKirhNuuv3w//vtn23sem0lkDfj3FXFCF3Jr0RXfRdyTlx22ThE=; X-UUID: fdbe423be5424ef0b7b0a6fa0cef7895-20191223 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 103425353; Mon, 23 Dec 2019 16:59:37 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 23 Dec 2019 16:59:16 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 23 Dec 2019 16:59:48 +0800 Message-ID: <1577091576.20525.4.camel@mtksdaap41> Subject: Re: [PATCH v5 6/7] drm/mediatek: support CMDQ interface in ddp component From: CK Hu To: Hsin-Yi Wang Date: Mon, 23 Dec 2019 16:59:36 +0800 In-Reply-To: References: <20191210050526.4437-1-bibby.hsieh@mediatek.com> <20191210050526.4437-7-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Yongqiang Niu , srv_heupstream@mediatek.com, David Airlie , Daniel Vetter , lkml , dri-devel , Tomasz Figa , Thierry Reding , linux-mediatek@lists.infradead.org, Matthias Brugger , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Hsin-yi: On Fri, 2019-12-20 at 21:27 +0800, Hsin-Yi Wang wrote: > On Tue, Dec 10, 2019 at 5:05 AM Bibby Hsieh wrote: > > > > > +void mtk_ddp_write(struct cmdq_pkt *cmdq_pkt, unsigned int value, > > + struct mtk_ddp_comp *comp, unsigned int offset) > > +{ > > +#if IS_ENABLED(CONFIG_MTK_CMDQ) > Should we use #ifdef like in v4? https://patchwork.kernel.org/patch/11274439/ > > We got warnings while compiling kernels if CONFIG_MTK_CMDQ is not set, > since cmdq_pkt_write() would still be compiled. > Similar in other #if IS_ENABLED(CONFIG_MTK_CMDQ) (also in 7/7 > https://patchwork.kernel.org/patch/11281349/) > I've changed IS_ENABLED() to IS_REACHABLE()in mediatek-drm-next-5.6 [1] for the correct relationship between MTK_DRM and MTK_CMDQ. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-5.6 Regards, CK > > > + if (cmdq_pkt) > > + cmdq_pkt_write(cmdq_pkt, comp->subsys, > > + comp->regs_pa + offset, value); > > + else > > +#endif > > + writel(value, comp->regs + offset); > > +} > > + _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel