From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/panel: lvds: Handle the optional regulator case properly Date: Fri, 12 Jan 2018 00:06:06 +0200 Message-ID: <1579517.s7hJ1SlSuH@avalon> References: <20180110155941.16109-1-maxime.ripard@free-electrons.com> <1944741.zEkzsdPTSS@avalon> <20180111131256.bmr6qbgzcmyfg4mj@flea.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DF4A6E478 for ; Thu, 11 Jan 2018 22:06:08 +0000 (UTC) In-Reply-To: <20180111131256.bmr6qbgzcmyfg4mj@flea.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Daniel Vetter , Maxime Ripard , Mark Brown , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgTWF4aW1lLAoKT24gVGh1cnNkYXksIDExIEphbnVhcnkgMjAxOCAxNToxMjo1NiBFRVQgTWF4 aW1lIFJpcGFyZCB3cm90ZToKPiBPbiBUaHUsIEphbiAxMSwgMjAxOCBhdCAwMzowNTowMVBNICsw MjAwLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gT24gV2VkbmVzZGF5LCAxMCBKYW51YXJ5 IDIwMTggMTc6NTk6NDEgRUVUIE1heGltZSBSaXBhcmQgd3JvdGU6Cj4gPj4gVGhlIGRldm1fcmVn dWxhdG9yX2dldF9vcHRpb25hbCBmdW5jdGlvbiwgdW5saWtlIGl0IHdhcyBhc3N1bWVkIGluIHRo ZQo+ID4+IGNvbW1pdCBhMWM1NWJjY2Y2MDAgKCJkcm0vcGFuZWw6IGx2ZHM6IEFkZCBzdXBwb3J0 IGZvciB0aGUgcG93ZXItc3VwcGx5Cj4gPj4gcHJvcGVydHkiKSwgaXMgYWN0dWFsbHkgcmV0dXJu aW5nIGFuIGVycm9yIHBvaW50ZXIgd2l0aCAtRU5PREVWIGluc3RlYWQKPiA+PiBvZiBOVUxMIHdo ZW4gdGhlcmUncyBubyByZWd1bGF0b3IgdG8gZmluZC4KPiA+PiAKPiA+PiBNYWtlIHN1cmUgd2Ug aGFuZGxlIHRoYXQgY2FzZSBwcm9wZXJseS4KPiA+PiAKPiA+PiBGaXhlczogYTFjNTViY2NmNjAw ICgiZHJtL3BhbmVsOiBsdmRzOiBBZGQgc3VwcG9ydCBmb3IgdGhlIHBvd2VyLXN1cHBseQo+ID4+ IHByb3BlcnR5IikgU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZAo+ID4+IDxtYXhpbWUucmlw YXJkQGZyZWUtZWxlY3Ryb25zLmNvbT4KPiA+PiAtLS0KPiA+PiAKPiA+PiAgZHJpdmVycy9ncHUv ZHJtL3BhbmVsL3BhbmVsLWx2ZHMuYyB8IDkgKysrKysrKy0tCj4gPj4gIDEgZmlsZSBjaGFuZ2Vk LCA3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPj4gCj4gPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1sdmRzLmMKPiA+PiBiL2RyaXZlcnMvZ3B1L2Ry bS9wYW5lbC9wYW5lbC1sdmRzLmMgaW5kZXggNTdlMzhhOWU3YWI0Li45ZjQ2ZTcwOTVjMGUKPiA+ PiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtbHZkcy5jCj4g Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWx2ZHMuYwo+ID4+IEBAIC0yMTUs OCArMjE1LDEzIEBAIHN0YXRpYyBpbnQgcGFuZWxfbHZkc19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlCj4gPj4gKnBkZXYpCj4gPj4gCWx2ZHMtPnN1cHBseSA9IGRldm1fcmVndWxhdG9yX2dl dF9vcHRpb25hbChsdmRzLT5kZXYsICJwb3dlciIpOwo+ID4+ICAJaWYgKElTX0VSUihsdmRzLT5z dXBwbHkpKSB7Cj4gPj4gIAkJcmV0ID0gUFRSX0VSUihsdmRzLT5zdXBwbHkpOwo+ID4+IC0JCWRl dl9lcnIobHZkcy0+ZGV2LCAiZmFpbGVkIHRvIHJlcXVlc3QgcmVndWxhdG9yOiAlZFxuIiwgcmV0 KTsKPiA+PiAtCQlyZXR1cm4gcmV0Owo+ID4+ICsKPiA+PiArCQlpZiAocmV0ICE9IC1FTk9ERVYp IHsKPiA+PiArCQkJZGV2X2VycihsdmRzLT5kZXYsICJmYWlsZWQgdG8gcmVxdWVzdCByZWd1bGF0 b3I6ICVkXG4iLCByZXQpOwo+ID4+ICsJCQlyZXR1cm4gcmV0Owo+ID4gCj4gPiBJIHdvdWxkbid0 IHByaW50IGFuIGVycm9yIG1lc3NhZ2UgaWYgcmV0ID09IC1FUFJPQkVfREVGRVIuCj4gPiAKPiA+ PiArCQl9IGVsc2Ugewo+ID4+ICsJCQlsdmRzLT5zdXBwbHkgPSBOVUxMOwo+ID4+ICsJCX0KPiA+ PiAgCX0KPiA+IAo+ID4gSG93IGFib3V0Cj4gPiAKPiA+IAlsdmRzLT5zdXBwbHkgPSBkZXZtX3Jl Z3VsYXRvcl9nZXRfb3B0aW9uYWwobHZkcy0+ZGV2LCAicG93ZXIiKTsKPiA+IAlpZiAoSVNfRVJS KGx2ZHMtPnN1cHBseSkpIHsKPiA+IAkJcmV0ID0gUFRSX0VSUihsdmRzLT5zdXBwbHkpOwo+ID4g CQlpZiAocmV0ICE9IC1FTk9ERVYpIHsKPiA+IAkJCWlmIChyZXQgPT0gLUVQUk9CRV9ERUZFUikK PiAKPiBJIGd1ZXNzIHRoYXQgd291bGQgYmUgIT0gLUVQUk9CRV9ERUZFUgoKT2YgY291cnNlLCBt eSBiYWQuCgo+ID4gCQkJCWRldl9lcnIobHZkcy0+ZGV2LCAiZmFpbGVkIHRvIHJlcXVlc3QgcmVn dWxhdG9yOiAlZFxuIiwgcmV0KTsKPiA+IAkJCXJldHVybiByZXQ7Cj4gPiAJCX0KPiA+IAkJCj4g PiAJCWx2ZHMtPnN1cHBseSA9IE5VTEw7Cj4gPiAJfQo+IAo+IE90aGVyd2lzZSwgaXQgd29ya3Mg Zm9yIG1lLgo+IAo+ID4gTXkgcHJlZmVyZW5jZSwgaG93ZXZlciwgd291bGQgYmUgZm9yIGRldm1f cmVndWxhdG9yX2dldF9vcHRpb25hbCgpIHRvCj4gPiByZXR1cm4gTlVMTCB3aGVuIG5vIHJlZ3Vs YXRvciBpcyBwcmVzZW50LiBUaGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbgo+ID4gcmV0dXJucyAt RU5PREVWIGluIG11bHRpcGxlIGNhc2VzLCBtYWtpbmcgaXQgaW1wb3NzaWJsZSB0byBwcm9wZXJs eQo+ID4gZGlzY3JpbWluYXRlIGJldHdlZW4gaGF2aW5nIG5vIHJlZ3VsYXRvciBhbmQgbm90IGJl aW5nIGFibGUgdG8gZ2V0IHRoZQo+ID4gcmVndWxhdG9yIGR1ZSB0byBhbiBlcnJvci4KPiAKPiBJ dCB3b3VsZCBmZWVsIG1vcmUgaW50dWl0aXZlIHRvIG1lIHRvbywgYnV0IGl0IHdvdWxkIGFsc28g cmVxdWlyZSB0bwo+IGZpeCBtb3N0IG9mIHRoZSBjYWxsIHNpdGVzIHRoYXQgd291bGQgaGF2ZSBh IHNpbWlsYXIgcGF0dGVybi4KCk9mIGNvdXJzZS4gSSBkb24ndCBtZWFuIHdlIG5lZWQgdG8gZGVs YXkgdGhpcyBwYXRjaCwgYnV0IEkgc3RpbGwgdGhpbmsgaXQgCndvdWxkIGJlIGEgZ29vZCBBUEkg aW1wcm92ZW1lbnQgdGhhdCBjb3VsZCBiZSBkZXZlbG9wZWQgc2VwYXJhdGVseSAoYW5kIG9mIApj b3Vyc2UgSSB3b3VsZG4ndCBjb21wbGFpbiBpZiB5b3Ugdm9sdW50ZWVyZWQgOy0pKS4KCi0tIApS ZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==