From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CB3C3F2C6 for ; Wed, 4 Mar 2020 02:38:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A511B2073D for ; Wed, 4 Mar 2020 02:38:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="E5eg/7QZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A511B2073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 067546EAA2; Wed, 4 Mar 2020 02:38:38 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id EF37B6EAA2 for ; Wed, 4 Mar 2020 02:38:36 +0000 (UTC) X-UUID: 966109f9695a4bcab70ef04ffe4ec9cf-20200304 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=gwG234eP2pizyd5C4jAhNxs4bxHFKwNJ44qV05ygkU8=; b=E5eg/7QZDpv5h2ta9LKJCC6rY+h2jMFCp5gc8+FzR2rIN1+EfWe+rkZRQm5eItDOeqyLaXG6aLYg/DFCoQOdZAxkCuizz/MftbkUGy44kwSERlsOQOWHLBU2Z6cmNrkcfYi+U2cS7v9jil+ACIy9PAkWOdbosleC1tDw9/Yanpc=; X-UUID: 966109f9695a4bcab70ef04ffe4ec9cf-20200304 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 249110076; Wed, 04 Mar 2020 10:38:33 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 4 Mar 2020 10:37:32 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 4 Mar 2020 10:37:52 +0800 Message-ID: <1583289512.32049.3.camel@mtksdaap41> Subject: Re: [PATCH v4 05/13] soc: mediatek: cmdq: return send msg error code From: CK Hu To: Dennis YC Hsieh Date: Wed, 4 Mar 2020 10:38:32 +0800 In-Reply-To: <1583233125-7827-6-git-send-email-dennis-yc.hsieh@mediatek.com> References: <1583233125-7827-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1583233125-7827-6-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, wsd_upstream@mediatek.com, David Airlie , Jassi Brar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, HS Liao , Rob Herring , linux-mediatek@lists.infradead.org, Houlong Wei , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Dennis: On Tue, 2020-03-03 at 18:58 +0800, Dennis YC Hsieh wrote: > Return error code to client if send message fail, > so that client has chance to error handling. > Reviewed-by: CK Hu > Signed-off-by: Dennis YC Hsieh > Fixes: 576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 2e1bc513569b..98f23ba3ba47 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -351,7 +351,9 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > spin_unlock_irqrestore(&client->lock, flags); > } > > - mbox_send_message(client->chan, pkt); > + err = mbox_send_message(client->chan, pkt); > + if (err < 0) > + return err; > /* We can send next packet immediately, so just call txdone. */ > mbox_client_txdone(client->chan, 0); > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel