From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB6BAC10F28 for ; Mon, 9 Mar 2020 08:14:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1F1420728 for ; Mon, 9 Mar 2020 08:14:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="TvTU+oyq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1F1420728 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 81BD66E359; Mon, 9 Mar 2020 08:13:43 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id BC9776E2BE for ; Mon, 9 Mar 2020 07:55:44 +0000 (UTC) X-UUID: 7119ba7b7a6e46bcb84bdaed4b5b366d-20200309 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=d0wnLlS3PKlRwicESnqS4F2qX7BxraxwO4F/6cuzvFM=; b=TvTU+oyqCuvB/dpVbfvu0kKeOdvaGuR0TXe4LK1eGwi+8IKZUxta4cn+iy/5g+zeKnkRjwu+zxKtOpDKhPOj8g83vj3cYLKgXzbFFMCAWt7WKoAAPWeeqSD4hxIZdJM8Dz8JxsMHj2HNr8FsY6UMor/pZY3sCobhsi8+7X0TdxI=; X-UUID: 7119ba7b7a6e46bcb84bdaed4b5b366d-20200309 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1475847732; Mon, 09 Mar 2020 15:55:40 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 9 Mar 2020 15:54:27 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 9 Mar 2020 15:55:55 +0800 Message-ID: <1583740539.3995.15.camel@mtksdaap41> Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 From: Nick Fan To: Steven Price Date: Mon, 9 Mar 2020 15:55:39 +0800 In-Reply-To: <20200306144336.GA9234@arm.com> References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> <1583462055.4947.6.camel@mtksdaap41> <20200306144336.GA9234@arm.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Approved-At: Mon, 09 Mar 2020 08:13:37 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , Nicolas Boichat , Tomeu Vizoso , Devicetree List , David Airlie , Liam Girdwood , dri-devel , lkml , Sj Huang , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Hsin-Yi Wang , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 2020-03-06 at 14:43 +0000, Steven Price wrote: > On Fri, Mar 06, 2020 at 02:13:08PM +0000, Rob Herring wrote: > > On Thu, Mar 5, 2020 at 8:34 PM Nick Fan wrote: > > > > > > Sorry for my late reply. > > > I have checked internally. > > > The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D > > > domain. > > > > > > If the naming too confusing, we can change this name to > > > MT8183_POWER_DOMAIN_MFG_CORE2 for consistency. > > > > Can you clarify what's in each domain? Are there actually 3 shader > > cores (IIRC, that should be discoverable)? > > The cover letter from Nicolas includes: > > > [ 501.321752] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1 > > 0x7 is three bits set, so it certainly looks like there are 3 shader > cores. Of course I wouldn't guarantee that it is as simple as each power > domain has a shader core in. The job manager and tiler also need to be > powered somehow, so they are either sharing with a shader core or > there's something more complex going on. > > Steve > There are actually five power domains in total for MT8183 GPU. There are 3 shader cores in MT8183. They can be listed as following for each power domain: 1.MT8183_POWER_DOMAIN_MFG_ASYNC : SOC bus logic 2.MT8183_POWER_DOMAIN_MFG : GPU job manager & tiler 3.MT8183_POWER_DOMAIN_MFG_CORE0 : GPU shader core 0 4.MT8183_POWER_DOMAIN_MFG_CORE1 : GPU shader core 1 5.MT8183_POWER_DOMAIN_MFG_2D : GPU shader core 2 There are other power domain dependency can be reference in the following link. https://lkml.org/lkml/2019/2/1/166 You can check the power domain dependencies as following ========================================================== +static const struct scp_subdomain scp_subdomain_mt8183[] = { + {MT8183_POWER_DOMAIN_MFG_ASYNC, MT8183_POWER_DOMAIN_MFG}, + {MT8183_POWER_DOMAIN_MFG, MT8183_POWER_DOMAIN_MFG_2D}, + {MT8183_POWER_DOMAIN_MFG, MT8183_POWER_DOMAIN_MFG_CORE0}, + {MT8183_POWER_DOMAIN_MFG, MT8183_POWER_DOMAIN_MFG_CORE1}, ========================================================== Thanks Nick Fan _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel