From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC13C43331 for ; Wed, 25 Mar 2020 23:00:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B48B20737 for ; Wed, 25 Mar 2020 23:00:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="r8lv1lYl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B48B20737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCF856E851; Wed, 25 Mar 2020 23:00:35 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id 850D46E850 for ; Wed, 25 Mar 2020 23:00:34 +0000 (UTC) X-UUID: 912b85233133436b97f8670a161a9b7c-20200326 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zRMHb+7lQ/kxPsZpJcKWipHS7+03jckwS7Gwba6WOEM=; b=r8lv1lYlGPHABlJA5/YvzkJB1hF9pK/v1LICPxxSO5nZCcv32OHDOmvHfEUd+znkTB995rws7hJHYTPnlQWT66hkirsOEUbpu6uo/53tSXJAnbFi1jeFk6/PbpDCO4Wf0oNaFpj8AaxKx8TQ4lQM+ym1wlIa1AHmIXg9f2JoVyc=; X-UUID: 912b85233133436b97f8670a161a9b7c-20200326 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1687820606; Thu, 26 Mar 2020 07:00:31 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 26 Mar 2020 07:00:28 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 26 Mar 2020 07:00:21 +0800 Message-ID: <1585177223.26117.1.camel@mtksdaap41> Subject: Re: [PATCH] drm/mediatek: Remove debug messages for function calls From: CK Hu To: Enric Balletbo i Serra Date: Thu, 26 Mar 2020 07:00:23 +0800 In-Reply-To: <20200226112723.649954-1-enric.balletbo@collabora.com> References: <20200226112723.649954-1-enric.balletbo@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Collabora Kernel ML , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Enric: On Wed, 2020-02-26 at 12:27 +0100, Enric Balletbo i Serra wrote: > Equivalent information can be nowadays obtained using function tracer. > > Signed-off-by: Enric Balletbo i Serra > --- Acked-by: CK Hu > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 5 ----- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 -- > 2 files changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index a236499123aa..882c690d3f13 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -192,7 +192,6 @@ static int mtk_crtc_ddp_clk_enable(struct mtk_drm_crtc *mtk_crtc) > int ret; > int i; > > - DRM_DEBUG_DRIVER("%s\n", __func__); > for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) { > ret = clk_prepare_enable(mtk_crtc->ddp_comp[i]->clk); > if (ret) { > @@ -212,7 +211,6 @@ static void mtk_crtc_ddp_clk_disable(struct mtk_drm_crtc *mtk_crtc) > { > int i; > > - DRM_DEBUG_DRIVER("%s\n", __func__); > for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) > clk_disable_unprepare(mtk_crtc->ddp_comp[i]->clk); > } > @@ -257,7 +255,6 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) > int ret; > int i; > > - DRM_DEBUG_DRIVER("%s\n", __func__); > if (WARN_ON(!crtc->state)) > return -EINVAL; > > @@ -298,7 +295,6 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) > goto err_mutex_unprepare; > } > > - DRM_DEBUG_DRIVER("mediatek_ddp_ddp_path_setup\n"); > for (i = 0; i < mtk_crtc->ddp_comp_nr - 1; i++) { > mtk_ddp_add_comp_to_path(mtk_crtc->config_regs, > mtk_crtc->ddp_comp[i]->id, > @@ -348,7 +344,6 @@ static void mtk_crtc_ddp_hw_fini(struct mtk_drm_crtc *mtk_crtc) > struct drm_crtc *crtc = &mtk_crtc->base; > int i; > > - DRM_DEBUG_DRIVER("%s\n", __func__); > for (i = 0; i < mtk_crtc->ddp_comp_nr; i++) { > mtk_ddp_comp_stop(mtk_crtc->ddp_comp[i]); > if (i == 1) > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 17f118ee0e57..4934834977b3 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -570,7 +570,6 @@ static int mtk_drm_sys_suspend(struct device *dev) > int ret; > > ret = drm_mode_config_helper_suspend(drm); > - DRM_DEBUG_DRIVER("mtk_drm_sys_suspend\n"); > > return ret; > } > @@ -582,7 +581,6 @@ static int mtk_drm_sys_resume(struct device *dev) > int ret; > > ret = drm_mode_config_helper_resume(drm); > - DRM_DEBUG_DRIVER("mtk_drm_sys_resume\n"); > > return ret; > } _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel