From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61892C433E1 for ; Tue, 2 Jun 2020 07:16:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBAB4206A2 for ; Tue, 2 Jun 2020 07:16:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="D/a54sh9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBAB4206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 802B36E181; Tue, 2 Jun 2020 07:16:28 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id EC29589E59 for ; Mon, 1 Jun 2020 02:41:19 +0000 (UTC) X-UUID: ffb75a9db1e344dbaa7f25d2fc04a721-20200601 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=5OOtmndFogETs8MsnbhnGCSCp5lzPK/Ub28tiH9HSm4=; b=D/a54sh9osEHpX5XVThxMncpCglXBCKrRh9zE44kXnu85UCznYciTAcSGelRgu4qi6W3+3Kmj3t+WWXP9A6fm4L3jbePDoQ2hAfuACLbPzSKs9I9leIMDKKikzb8JBeSXT5FP9Sm78jAN+yrspHh2CEiOLkUq5FJv7H6+87lq5A=; X-UUID: ffb75a9db1e344dbaa7f25d2fc04a721-20200601 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 2059801762; Mon, 01 Jun 2020 10:41:15 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 1 Jun 2020 10:41:08 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 1 Jun 2020 10:41:07 +0800 Message-ID: <1590979273.15486.0.camel@mtkswgap22> Subject: Re: [PATCH v6] support gce on mt6779 platform From: Dennis-YC Hsieh To: Jassi Brar Date: Mon, 1 Jun 2020 10:41:13 +0800 In-Reply-To: References: <1590685491-17107-1-git-send-email-dennis-yc.hsieh@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 23F5E0BF1671CC4EE062D7B349A502EB7F010BB185DCAB11634C1C6C2FE40B6C2000:8 X-MTK: N X-Mailman-Approved-At: Tue, 02 Jun 2020 07:16:26 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Devicetree List , wsd_upstream@mediatek.com, David Airlie , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, HS Liao , Rob Herring , linux-mediatek@lists.infradead.org, Houlong Wei , Matthias Brugger , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jassi, Thanks for your comment On Sat, 2020-05-30 at 15:34 -0500, Jassi Brar wrote: > On Thu, May 28, 2020 at 12:05 PM Dennis YC Hsieh > wrote: > > > > This patch support gce on mt6779 platform. > > > > Change since v5: > > - spearate address shift code in client helper and mailbox controller > > - separate write_s/write_s_mask and write_s_value/write_s_mask_value so that > > client can decide use mask or not > > - fix typo in header > > > > Change since v4: > > - do not clear disp event again in drm driver > > - symbolize value 1 to jump relative > > > > [... snip ...] > > > > > > > > Dennis YC Hsieh (16): > > dt-binding: gce: add gce header file for mt6779 > > mailbox: cmdq: variablize address shift in platform > > mailbox: cmdq: support mt6779 gce platform definition > > mailbox: mediatek: cmdq: clear task in channel before shutdown > > soc: mediatek: cmdq: return send msg error code > > soc: mediatek: cmdq: add address shift in jump > > soc: mediatek: cmdq: add assign function > > soc: mediatek: cmdq: add write_s function > > soc: mediatek: cmdq: add write_s_mask function > > soc: mediatek: cmdq: add read_s function > > soc: mediatek: cmdq: add write_s value function > > soc: mediatek: cmdq: add write_s_mask value function > > soc: mediatek: cmdq: export finalize function > > soc: mediatek: cmdq: add jump function > > soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api > > soc: mediatek: cmdq: add set event function > > > > .../devicetree/bindings/mailbox/mtk-gce.txt | 8 +- > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +- > > drivers/mailbox/mtk-cmdq-mailbox.c | 101 ++++++-- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 163 ++++++++++++- > > include/dt-bindings/gce/mt6779-gce.h | 222 ++++++++++++++++++ > > include/linux/mailbox/mtk-cmdq-mailbox.h | 10 +- > > include/linux/soc/mediatek/mtk-cmdq.h | 125 +++++++++- > > > Please break the patchset into two. The lower mailbox related changes > with soc changes on top. Ok, I'll separate patches into two patchset, thanks. Regards, Dennis > > thanks _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel