From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 34/37] drm: Replace 'format->format' comparisons to just 'format' comparisons Date: Sat, 19 Nov 2016 04:56:56 +0200 Message-ID: <1593371.tkbCZ4xNF7@avalon> References: <1479498793-31021-1-git-send-email-ville.syrjala@linux.intel.com> <1479498793-31021-35-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 503DA6E27E for ; Sat, 19 Nov 2016 02:56:44 +0000 (UTC) In-Reply-To: <1479498793-31021-35-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: ville.syrjala@linux.intel.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVmlsbGUsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIEZyaWRheSAxOCBOb3YgMjAx NiAyMTo1MzoxMCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IAo+IFJhdGhl ciB0aGFuIGNvbXBhcmUgdGhlIGZvcm1hdCB1MzJzIG9mIHR3byBmb3JtYXQgaW5mb3MsIHdlIGNh biBkaXJlY2x0eQo+IGNvbXBhcmUgdGhlIGZvcm1hdCBpbmZvIHBvaW50ZXJzIHRoZW1zZWx2ZXMu IE5vcmFtbGx5IGFsbCB0aGUgLT5mb3JtYXQKPiBwb2ludGVycyBhbGwgcG9pbnQgdG8gc29td2Vo ZXJlIGluIHRoZSBiaWcgYXJyYXksIHNvIHRoaXMgaXMgYSB2YWxpZAo+IHdheSB0byB0ZXN0IGZv ciBlcXVhbGl0eS4KPiAKPiBBbHNvIGRyaXZlcnMgbWF5IHdhbnQgdG8gcG9pbnQgLT5mb3JtYXQg YXQgYSBwcml2YXRlIGZvcm1hdCBpbmZvIHN0cnVjdAo+IGluc3RlYWQgKGVnLiBmb3Igc3BlY2lh bCBjb21wcmVzc2VkIGZvcm1hdHMgd2l0aCBleHRyYSBwbGFuZXMpLCBzbwo+IGp1c3QgY29tcGFy aW5nIHRoZSBwaXhlbCBmb3JtYXQgdmFsdWVzIHdvdWxkbid0IG5lY2Vzc2FyaXRseSBldmVuIHdv cmsuCj4gQnV0IGNvbXBhcmluZyB0aGUgcG9pbnRlcnMgd2lsbCBhbHNvIHRha2UgY2FyZSBvZiB0 aGF0IGNhc2UuCj4gCj4gQEAKPiBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICphOwo+IHN0cnVjdCBk cm1fZnJhbWVidWZmZXIgKmI7Cj4gQEAKPiAoCj4gLSBhLT5mb3JtYXQtPmZvcm1hdCAhPSBiLT5m b3JtYXQtPmZvcm1hdAo+ICsgYS0+Zm9ybWF0ICE9IGItPmZvcm1hdAo+IAo+IC0gYS0+Zm9ybWF0 LT5mb3JtYXQgPT0gYi0+Zm9ybWF0LT5mb3JtYXQKPiArIGEtPmZvcm1hdCA9PSBiLT5mb3JtYXQK PiApCj4gCj4gQEAKPiBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICphOwo+IHN0cnVjdCBkcm1fcGxh bmVfc3RhdGUgKmI7Cj4gQEAKPiAoCj4gLSBhLT5mYi0+Zm9ybWF0LT5mb3JtYXQgIT0gYi0+ZmIt PmZvcm1hdC0+Zm9ybWF0Cj4gKyBhLT5mYi0+Zm9ybWF0ICE9IGItPmZiLT5mb3JtYXQKPiAKPiAt IGEtPmZiLT5mb3JtYXQtPmZvcm1hdCA9PSBiLT5mYi0+Zm9ybWF0LT5mb3JtYXQKPiArIGEtPmZi LT5mb3JtYXQgPT0gYi0+ZmItPmZvcm1hdAo+ICkKPiAKPiBAQAo+IHN0cnVjdCBkcm1fY3J0YyAq Y3J0YzsKPiBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICp4Owo+IEBACj4gKAo+IC0gY3J0Yy0+cHJp bWFyeS0+ZmItPmZvcm1hdC0+Zm9ybWF0ICE9IHgtPmZvcm1hdC0+Zm9ybWF0Cj4gKyBjcnRjLT5w cmltYXJ5LT5mYi0+Zm9ybWF0ICE9IHgtPmZvcm1hdAo+IAo+IC0geC0+Zm9ybWF0LT5mb3JtYXQg IT0gY3J0Yy0+cHJpbWFyeS0+ZmItPmZvcm1hdC0+Zm9ybWF0Cj4gKyB4LT5mb3JtYXQgIT0gY3J0 Yy0+cHJpbWFyeS0+ZmItPmZvcm1hdAo+ICkKPiAKPiBAQAo+IHN0cnVjdCBkcm1fbW9kZV9zZXQg KnNldDsKPiBAQAo+IC0gc2V0LT5mYi0+Zm9ybWF0LT5mb3JtYXQgIT0gc2V0LT5jcnRjLT5wcmlt YXJ5LT5mYi0+Zm9ybWF0LT5mb3JtYXQKPiArIHNldC0+ZmItPmZvcm1hdCAhPSBzZXQtPmNydGMt PnByaW1hcnktPmZiLT5mb3JtYXQKPiAKPiBDYzogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5w aW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IFN1Z2dlc3RlZC1ieTogTGF1cmVudCBQaW5jaGFy dCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1i eTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoK PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FybWFkYS9hcm1hZGFfY3J0Yy5jICAgICAgfCAyICst Cj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Y19oZWxwZXIuYyAgICAgICAgIHwgMyArLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jICAgICAgICAgICAgICAgfCAyICstCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyAgICAgIHwgMiArLQo+ICBkcml2ZXJzL2dw dS9kcm0vaW14L2lwdXYzLXBsYW5lLmMgICAgICAgICB8IDYgKysrLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9tc20vbWRwL21kcDUvbWRwNV9wbGFuZS5jIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0v dGlsY2RjL3RpbGNkY19wbGFuZS5jICAgICB8IDIgKy0KPiAgNyBmaWxlcyBjaGFuZ2VkLCA5IGlu c2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYXJtYWRhL2FybWFkYV9jcnRjLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9hcm1hZGEvYXJt YWRhX2NydGMuYyBpbmRleCA1MmUxMzlkYzllMzguLmJhZWJmMzc3NWY2MAo+IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hcm1hZGEvYXJtYWRhX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9hcm1hZGEvYXJtYWRhX2NydGMuYwo+IEBAIC05OTYsNyArOTk2LDcgQEAgc3RhdGlj IGludCBhcm1hZGFfZHJtX2NydGNfcGFnZV9mbGlwKHN0cnVjdCBkcm1fY3J0Ywo+ICpjcnRjLCBp bnQgcmV0Owo+IAo+ICAJLyogV2UgZG9uJ3Qgc3VwcG9ydCBjaGFuZ2luZyB0aGUgcGl4ZWwgZm9y bWF0ICovCj4gLQlpZiAoZmItPmZvcm1hdC0+Zm9ybWF0ICE9IGNydGMtPnByaW1hcnktPmZiLT5m b3JtYXQtPmZvcm1hdCkKPiArCWlmIChmYi0+Zm9ybWF0ICE9IGNydGMtPnByaW1hcnktPmZiLT5m b3JtYXQpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gCj4gIAl3b3JrID0ga21hbGxvYyhzaXplb2Yo KndvcmspLCBHRlBfS0VSTkVMKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9j cnRjX2hlbHBlci5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMgaW5kZXgg OTRiY2UwYjQ2MmFhLi45ZDAwN2Y1Zjk3MzIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2RybV9jcnRjX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2hlbHBl ci5jCj4gQEAgLTU4OCw4ICs1ODgsNyBAQCBpbnQgZHJtX2NydGNfaGVscGVyX3NldF9jb25maWco c3RydWN0IGRybV9tb2RlX3NldCAqc2V0KQo+IGlmIChzZXQtPmNydGMtPnByaW1hcnktPmZiID09 IE5VTEwpIHsKPiAgCQkJRFJNX0RFQlVHX0tNUygiY3J0YyBoYXMgbm8gZmIsIGZ1bGwgbW9kZSBz ZXRcbiIpOwo+ICAJCQltb2RlX2NoYW5nZWQgPSB0cnVlOwo+IC0JCX0gZWxzZSBpZiAoc2V0LT5m Yi0+Zm9ybWF0LT5mb3JtYXQgIT0KPiAtCQkJICAgc2V0LT5jcnRjLT5wcmltYXJ5LT5mYi0+Zm9y bWF0LT5mb3JtYXQpIHsKPiArCQl9IGVsc2UgaWYgKHNldC0+ZmItPmZvcm1hdCAhPSBzZXQtPmNy dGMtPnByaW1hcnktPmZiLT5mb3JtYXQpIAp7Cj4gIAkJCW1vZGVfY2hhbmdlZCA9IHRydWU7Cj4g IAkJfSBlbHNlCj4gIAkJCWZiX2NoYW5nZWQgPSB0cnVlOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiBpbmRl eCBhYzFlMDZkZjcyODAuLjFkOTA1MjA0NTdkNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZHJtX3BsYW5lLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiBAQCAt ODU0LDcgKzg1NCw3IEBAIGludCBkcm1fbW9kZV9wYWdlX2ZsaXBfaW9jdGwoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPiAgCWlmIChyZXQpCj4gIAkJZ290byBvdXQ7Cj4gCj4gLQlpZiAoY3J0Yy0+ cHJpbWFyeS0+ZmItPmZvcm1hdC0+Zm9ybWF0ICE9IGZiLT5mb3JtYXQtPmZvcm1hdCkgewo+ICsJ aWYgKGNydGMtPnByaW1hcnktPmZiLT5mb3JtYXQgIT0gZmItPmZvcm1hdCkgewo+ICAJCURSTV9E RUJVR19LTVMoIlBhZ2UgZmxpcCBpcyBub3QgYWxsb3dlZCB0byBjaGFuZ2UgZnJhbWUgYnVmZmVy Cj4gZm9ybWF0LlxuIik7IHJldCA9IC1FSU5WQUw7Cj4gIAkJZ290byBvdXQ7Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGluZGV4IGY1ZjlmMTQyMmQ2OS4uN2I3MTM1YmUzYjll Cj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEyMTQ4LDcg KzEyMTQ4LDcgQEAgc3RhdGljIGludCBpbnRlbF9jcnRjX3BhZ2VfZmxpcChzdHJ1Y3QgZHJtX2Ny dGMKPiAqY3J0YywgcmV0dXJuIC1FQlVTWTsKPiAKPiAgCS8qIENhbid0IGNoYW5nZSBwaXhlbCBm b3JtYXQgdmlhIE1JIGRpc3BsYXkgZmxpcHMuICovCj4gLQlpZiAoZmItPmZvcm1hdC0+Zm9ybWF0 ICE9IGNydGMtPnByaW1hcnktPmZiLT5mb3JtYXQtPmZvcm1hdCkKPiArCWlmIChmYi0+Zm9ybWF0 ICE9IGNydGMtPnByaW1hcnktPmZiLT5mb3JtYXQpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gCj4g IAkvKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLXBsYW5lLmMKPiBi L2RyaXZlcnMvZ3B1L2RybS9pbXgvaXB1djMtcGxhbmUuYyBpbmRleCAwYjk0NWYwNzczNDQuLjhi NTI5NGQ0N2NlZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLXBsYW5l LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLXBsYW5lLmMKPiBAQCAtMjgxLDcg KzI4MSw3IEBAIHN0YXRpYyBpbnQgaXB1X3BsYW5lX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX3Bs YW5lCj4gKnBsYW5lLCAqLwo+ICAJaWYgKG9sZF9mYiAmJiAoc3RhdGUtPnNyY193ICE9IG9sZF9z dGF0ZS0+c3JjX3cgfHwKPiAgCQkJICAgICAgc3RhdGUtPnNyY19oICE9IG9sZF9zdGF0ZS0+c3Jj X2ggfHwKPiAtCQkJICAgICAgZmItPmZvcm1hdC0+Zm9ybWF0ICE9IG9sZF9mYi0+Zm9ybWF0LT5m b3JtYXQpKQo+ICsJCQkgICAgICBmYi0+Zm9ybWF0ICE9IG9sZF9mYi0+Zm9ybWF0KSkKPiAgCQlj cnRjX3N0YXRlLT5tb2RlX2NoYW5nZWQgPSB0cnVlOwo+IAo+ICAJZWJhID0gZHJtX3BsYW5lX3N0 YXRlX3RvX2ViYShzdGF0ZSk7Cj4gQEAgLTMxNSw3ICszMTUsNyBAQCBzdGF0aWMgaW50IGlwdV9w bGFuZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFuZQo+ICpwbGFuZSwgaWYgKHZibyAmIDB4 NyB8fCB2Ym8gPiAweGZmZmZmOCkKPiAgCQkJcmV0dXJuIC1FSU5WQUw7Cj4gCj4gLQkJaWYgKG9s ZF9mYiAmJiAoZmItPmZvcm1hdC0+Zm9ybWF0ID09IG9sZF9mYi0+Zm9ybWF0LT5mb3JtYXQpKSAK ewo+ICsJCWlmIChvbGRfZmIgJiYgKGZiLT5mb3JtYXQgPT0gb2xkX2ZiLT5mb3JtYXQpKSB7Cj4g IAkJCW9sZF92Ym8gPSBkcm1fcGxhbmVfc3RhdGVfdG9fdmJvKG9sZF9zdGF0ZSk7Cj4gIAkJCWlm ICh2Ym8gIT0gb2xkX3ZibykKPiAgCQkJCWNydGNfc3RhdGUtPm1vZGVfY2hhbmdlZCA9IHRydWU7 Cj4gQEAgLTMzMiw3ICszMzIsNyBAQCBzdGF0aWMgaW50IGlwdV9wbGFuZV9hdG9taWNfY2hlY2so c3RydWN0IGRybV9wbGFuZQo+ICpwbGFuZSwgaWYgKHVibyAmIDB4NyB8fCB1Ym8gPiAweGZmZmZm OCkKPiAgCQkJcmV0dXJuIC1FSU5WQUw7Cj4gCj4gLQkJaWYgKG9sZF9mYiAmJiAoZmItPmZvcm1h dC0+Zm9ybWF0ID09IG9sZF9mYi0+Zm9ybWF0LT5mb3JtYXQpKSAKewo+ICsJCWlmIChvbGRfZmIg JiYgKGZiLT5mb3JtYXQgPT0gb2xkX2ZiLT5mb3JtYXQpKSB7Cj4gIAkJCW9sZF91Ym8gPSBkcm1f cGxhbmVfc3RhdGVfdG9fdWJvKG9sZF9zdGF0ZSk7Cj4gIAkJCWlmICh1Ym8gIT0gb2xkX3VibykK PiAgCQkJCWNydGNfc3RhdGUtPm1vZGVfY2hhbmdlZCA9IHRydWU7Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDUvbWRwNV9wbGFuZS5jCj4gYi9kcml2ZXJzL2dwdS9k cm0vbXNtL21kcC9tZHA1L21kcDVfcGxhbmUuYyBpbmRleAo+IGI5MGU5ZTQ5NzI2MC4uNmVjYzZi YzFmNTMxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDUvbWRwNV9w bGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9tZHAvbWRwNS9tZHA1X3BsYW5lLmMK PiBAQCAtMzQwLDcgKzM0MCw3IEBAIHN0YXRpYyBpbnQgbWRwNV9wbGFuZV9hdG9taWNfY2hlY2so c3RydWN0IGRybV9wbGFuZQo+ICpwbGFuZSwgaWYgKHBsYW5lX2VuYWJsZWQoc3RhdGUpICYmIHBs YW5lX2VuYWJsZWQob2xkX3N0YXRlKSkgewo+ICAJCS8qIHdlIGNhbm5vdCBjaGFuZ2UgU01QIGJs b2NrIGNvbmZpZ3VyYXRpb24gZHVyaW5nIHNjYW5vdXQ6ICovCj4gIAkJYm9vbCBmdWxsX21vZGVz ZXQgPSBmYWxzZTsKPiAtCQlpZiAoc3RhdGUtPmZiLT5mb3JtYXQtPmZvcm1hdCAhPSBvbGRfc3Rh dGUtPmZiLT5mb3JtYXQtCj5mb3JtYXQpIHsKPiArCQlpZiAoc3RhdGUtPmZiLT5mb3JtYXQgIT0g b2xkX3N0YXRlLT5mYi0+Zm9ybWF0KSB7Cj4gIAkJCURCRygiJXM6IHBpeGVsX2Zvcm1hdCBjaGFu Z2UhIiwgbWRwNV9wbGFuZS0+bmFtZSk7Cj4gIAkJCWZ1bGxfbW9kZXNldCA9IHRydWU7Cj4gIAkJ fQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19wbGFuZS5jCj4g Yi9kcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19wbGFuZS5jIGluZGV4IDRiNzUxOWRmZDFi OS4uYmEwZDY2YzBkOGFjCj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90 aWxjZGNfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS90aWxjZGMvdGlsY2RjX3BsYW5l LmMKPiBAQCAtNzcsNyArNzcsNyBAQCBzdGF0aWMgaW50IHRpbGNkY19wbGFuZV9hdG9taWNfY2hl Y2soc3RydWN0IGRybV9wbGFuZQo+ICpwbGFuZSwgfQo+IAo+ICAJaWYgKHN0YXRlLT5mYiAmJiBv bGRfc3RhdGUtPmZiICYmCj4gLQkgICAgc3RhdGUtPmZiLT5mb3JtYXQtPmZvcm1hdCAhPSBvbGRf c3RhdGUtPmZiLT5mb3JtYXQtPmZvcm1hdCkgewo+ICsJICAgIHN0YXRlLT5mYi0+Zm9ybWF0ICE9 IG9sZF9zdGF0ZS0+ZmItPmZvcm1hdCkgewo+ICAJCWRldl9kYmcocGxhbmUtPmRldi0+ZGV2LAo+ ICAJCQkiJXMoKTogcGl4ZWwgZm9ybWF0IGNoYW5nZSByZXF1aXJlcyBtb2RlX2NoYW5nZVxuIiwK PiAgCQkJX19mdW5jX18pOwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK