From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakob Bornecrantz Subject: Re: [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION Date: Thu, 5 Jan 2012 08:40:15 -0800 (PST) Message-ID: <1601013654.1715112.1325781615896.JavaMail.root@zimbra-prod-mbox-2.vmware.com> References: <1325780183-23690-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1325780183-23690-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: przanoni@gmail.com Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org ----- Original Message ----- > From: Paulo Zanoni > > This ioctl is used to signal the drivers that the screen is rotated, > not to make the drivers rotate the screen. > - add a driver-specific "rotation_set" function > - implement Intel's rotation_set by setting the right values to the > PIPECONF registers. > > The idea is that when user-space does rotation, it can call this > ioctl to inform the Kernel that we have a rotation. This feature is > needed by the KVMr feature of VPro. > > Signed-off-by: Paulo Zanoni Couldn't this be done by just adding a property instead of a ioctl? Also the name make it sound like you are setting the rotation and not just setting a hint, so the word hit should probably be in the name. Cheers Jakob.