From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] fbdev: fbmem: fix memory access if logo is bigger than the screen Date: Fri, 8 Feb 2019 18:41:42 +0100 Message-ID: <16025871-3918-e9be-e6af-de9831cdc064@samsung.com> References: <20190128100435.759-1-martink@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190128100435.759-1-martink@posteo.de> Sender: linux-kernel-owner@vger.kernel.org To: Martin Kepplinger Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, manfred.schlaegl@ginzinger.com, linux-kernel@vger.kernel.org, Martin Kepplinger List-Id: dri-devel@lists.freedesktop.org On 01/28/2019 11:04 AM, Martin Kepplinger wrote: > From: Manfred Schlaegl > > There is no clipping on the x or y axis for logos larger that the framebuffer > size. Therefore: a logo bigger than screen size leads to invalid memory access: > > [ 1.254664] Backtrace: > [ 1.254728] [] (cfb_imageblit) from [] (fb_show_logo+0x620/0x684) > [ 1.254763] r10:00000003 r9:00027fd8 r8:c6a40000 r7:c6a36e50 r6:00000000 r5:c06b81e4 > [ 1.254774] r4:c6a3e800 > [ 1.254810] [] (fb_show_logo) from [] (fbcon_switch+0x3fc/0x46c) > [ 1.254842] r10:c6a3e824 r9:c6a3e800 r8:00000000 r7:c6a0c000 r6:c070b014 r5:c6a3e800 > [ 1.254852] r4:c6808c00 > [ 1.254889] [] (fbcon_switch) from [] (redraw_screen+0xf0/0x1e8) > [ 1.254918] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:c070d5a0 r5:00000080 > [ 1.254928] r4:c6808c00 > [ 1.254961] [] (redraw_screen) from [] (do_bind_con_driver+0x194/0x2e4) > [ 1.254991] r9:00000000 r8:00000000 r7:00000014 r6:c070d5a0 r5:c070d5a0 r4:c070d5a0 > > So prevent displaying a logo bigger than screen size and avoid invalid > memory access. > > Signed-off-by: Manfred Schlaegl > Signed-off-by: Martin Kepplinger Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics