From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD6CC55179 for ; Fri, 30 Oct 2020 08:23:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F14322223F for ; Fri, 30 Oct 2020 08:23:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="jFAcBTi+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F14322223F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E14176E99D; Fri, 30 Oct 2020 08:23:21 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [1.203.163.81]) by gabe.freedesktop.org (Postfix) with ESMTP id 308BC6E953 for ; Fri, 30 Oct 2020 06:24:15 +0000 (UTC) X-UUID: 8232f4ff14204ef7b469d3635da84219-20201030 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=YW4q5ZJRm8kC2ou+oovRsbefAl2EDK2GL+44143nPrc=; b=jFAcBTi+hXNJeRD5HTU1aX1W+EMS+wc3DC7HxNTwO50DR5FPFf3vleREos23czHpyqwjXiPbe69iH5jLRSNF/SkTjp4P6JuAk1roNb698mndZeeYXShsvclNskLOE/xc/XYAx791fCYeKROldR0jfMcAWcRsC0bfhbV0RV+1/j0=; X-UUID: 8232f4ff14204ef7b469d3635da84219-20201030 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 355014566; Fri, 30 Oct 2020 14:24:12 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N2.mediatek.inc (172.27.4.72) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 30 Oct 2020 14:24:09 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 30 Oct 2020 14:24:08 +0800 Message-ID: <1604039049.31607.13.camel@mhfsdcap03> Subject: Re: [PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder From: Chunfeng Yun To: Chun-Kuang Hu Date: Fri, 30 Oct 2020 14:24:09 +0800 In-Reply-To: <20201029152702.533-3-chunkuang.hu@kernel.org> References: <20201029152702.533-1-chunkuang.hu@kernel.org> <20201029152702.533-3-chunkuang.hu@kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 1C109F125DCD51B7526C344C915E61B96ACE847500F15FDE08582526232B511C2000:8 X-MTK: N X-Mailman-Approved-At: Fri, 30 Oct 2020 08:23:17 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , linux-mediatek@lists.infradead.org, Matthias Brugger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 2020-10-29 at 23:27 +0800, Chun-Kuang Hu wrote: > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_mipi_dsi_phy driver into phy driver folder. > > Signed-off-by: Chun-Kuang Hu > --- > drivers/gpu/drm/mediatek/Kconfig | 7 ------- > drivers/gpu/drm/mediatek/Makefile | 6 ------ > drivers/phy/mediatek/Kconfig | 7 +++++++ > drivers/phy/mediatek/Makefile | 5 +++++ > .../mediatek/phy-mtk-mipi-dsi-mt8173.c} | 2 +- > .../mediatek/phy-mtk-mipi-dsi-mt8183.c} | 2 +- > .../mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} | 2 +- > .../mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} | 0 > 8 files changed, 15 insertions(+), 16 deletions(-) > rename drivers/{gpu/drm/mediatek/mtk_mt8173_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8173.c} (99%) > rename drivers/{gpu/drm/mediatek/mtk_mt8183_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8183.c} (99%) > rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} (99%) > rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} (100%) Reviewed-by: Chunfeng Yun Please add phy maintaniner "Vinod Koul " Thanks > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index 24c4890a6e65..2976d21e9a34 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -28,10 +28,3 @@ config DRM_MEDIATEK_HDMI > select PHY_MTK_HDMI > help > DRM/KMS HDMI driver for Mediatek SoCs > - > -config PHY_MTK_MIPI_DSI > - tristate "Mediatek MIPI-DSI-PHY Driver" > - depends on ARCH_MEDIATEK && OF > - select GENERIC_PHY > - help > - Support MIPI DSI PHY for Mediatek SoCs. > diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile > index baa188000543..a892edec5563 100644 > --- a/drivers/gpu/drm/mediatek/Makefile > +++ b/drivers/gpu/drm/mediatek/Makefile > @@ -19,9 +19,3 @@ mediatek-drm-hdmi-objs := mtk_cec.o \ > mtk_hdmi_ddc.o > > obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o > - > -phy-mtk-mipi-dsi-drv-objs := mtk_mipi_tx.o \ > - mtk_mt8173_mipi_tx.o \ > - mtk_mt8183_mipi_tx.o > - > -obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > index 50c5e9306e19..574b8e6398d2 100644 > --- a/drivers/phy/mediatek/Kconfig > +++ b/drivers/phy/mediatek/Kconfig > @@ -42,3 +42,10 @@ config PHY_MTK_HDMI > select GENERIC_PHY > help > Support HDMI PHY for Mediatek SoCs. > + > +config PHY_MTK_MIPI_DSI > + tristate "MediaTek MIPI-DSI Driver" > + depends on ARCH_MEDIATEK && OF > + select GENERIC_PHY > + help > + Support MIPI DSI for Mediatek SoCs. > diff --git a/drivers/phy/mediatek/Makefile b/drivers/phy/mediatek/Makefile > index 6325e38709ed..ace660fbed3a 100644 > --- a/drivers/phy/mediatek/Makefile > +++ b/drivers/phy/mediatek/Makefile > @@ -11,3 +11,8 @@ phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt8173.o > obj-$(CONFIG_PHY_MTK_HDMI) += phy-mtk-hdmi-drv.o > + > +phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o > +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o > +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o > +obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c > similarity index 99% > rename from drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c > index f18db14d8b63..7a847954594f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c > @@ -4,7 +4,7 @@ > * Author: jitao.shi > */ > > -#include "mtk_mipi_tx.h" > +#include "phy-mtk-mipi-dsi.h" > > #define MIPITX_DSI_CON 0x00 > #define RG_DSI_LDOCORE_EN BIT(0) > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c > similarity index 99% > rename from drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c > index 9f3e55aeebb2..99108426d57c 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c > @@ -4,7 +4,7 @@ > * Author: jitao.shi > */ > > -#include "mtk_mipi_tx.h" > +#include "phy-mtk-mipi-dsi.h" > > #define MIPITX_LANE_CON 0x000c > #define RG_DSI_CPHY_T1DRV_EN BIT(0) > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > similarity index 99% > rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.c > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.c > index f2a892e16c27..18c481251f04 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c > @@ -3,7 +3,7 @@ > * Copyright (c) 2015 MediaTek Inc. > */ > > -#include "mtk_mipi_tx.h" > +#include "phy-mtk-mipi-dsi.h" > > inline struct mtk_mipi_tx *mtk_mipi_tx_from_clk_hw(struct clk_hw *hw) > { > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.h b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h > similarity index 100% > rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.h > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel