From: Tian Tao <tiantao6@hisilicon.com>
To: <jsarha@ti.com>, <tomi.valkeinen@ti.com>, <airlied@linux.ie>,
<daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/tidss: Use the new api devm_drm_irq_install
Date: Tue, 8 Dec 2020 20:36:09 +0800 [thread overview]
Message-ID: <1607430969-1663-1-git-send-email-tiantao6@hisilicon.com> (raw)
Use devm_drm_irq_install to register interrupts so that
drm_irq_uninstall is not needed to be called.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/tidss/tidss_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
index 66e3c86e..e68f2de 100644
--- a/drivers/gpu/drm/tidss/tidss_drv.c
+++ b/drivers/gpu/drm/tidss/tidss_drv.c
@@ -173,7 +173,7 @@ static int tidss_probe(struct platform_device *pdev)
goto err_runtime_suspend;
}
- ret = drm_irq_install(ddev, irq);
+ ret = devm_drm_irq_install(ddev, irq);
if (ret) {
dev_err(dev, "drm_irq_install failed: %d\n", ret);
goto err_runtime_suspend;
@@ -219,8 +219,6 @@ static int tidss_remove(struct platform_device *pdev)
drm_atomic_helper_shutdown(ddev);
- drm_irq_uninstall(ddev);
-
#ifndef CONFIG_PM
/* If we don't have PM, we need to call suspend manually */
dispc_runtime_suspend(tidss->dispc);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-12-09 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 12:36 Tian Tao [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-08 7:50 [PATCH] drm/tidss: Use the new api devm_drm_irq_install Tian Tao
2020-12-08 11:21 ` kernel test robot
2020-12-09 0:48 ` Daniel Vetter
2020-12-09 11:29 ` Tomi Valkeinen
2020-12-09 11:56 ` Daniel Vetter
2020-12-09 12:06 ` Tomi Valkeinen
2020-12-09 12:08 ` Daniel Vetter
2020-12-09 12:41 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1607430969-1663-1-git-send-email-tiantao6@hisilicon.com \
--to=tiantao6@hisilicon.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox