From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 0/3] Add dt support for exynos hdmiphy settings Date: Wed, 14 Aug 2013 14:33:32 +0200 Message-ID: <1607453.XABlJNFXXk@amdc1227> References: <1376377771-9325-1-git-send-email-s.shirish@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DBD643A4D for ; Wed, 14 Aug 2013 05:33:41 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MRI00CXFTK2O210@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 14 Aug 2013 13:33:38 +0100 (BST) In-reply-to: <1376377771-9325-1-git-send-email-s.shirish@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: shirish@chromium.org, Shirish S List-Id: dri-devel@lists.freedesktop.org Hi Shirish, On Tuesday 13 of August 2013 12:39:27 Shirish S wrote: > For various revision of chipset if the signal pattern is changed for > every board, then the phy setting need to be updated correspondingly by > measuring the signal. > With the hdmiphy settings fixed in the driver the only way currently is > to either add a new structure or add compile time option. > To avoid this, we can move the same to dt, wherin we can have different > dt files for every revision. This patchset can be considered as an > initiative towards achieving the same for exynos 5250 and can be later > extended to future chipsets. > Also this patchset moves the entire structure to dt file as-is in the > driver and hence we can find all the hex values, which are not logically > explained similar to driver. > > Shirish S (3): > ARM: dts: smdk5250: Add hdmi phy settings > ARM: dts: arndale: Add hdmi phy settings > drm: exynos: hdmi: Add dt support for hdmiphy settings > > .../devicetree/bindings/video/exynos_hdmi.txt | 18 +- > arch/arm/boot/dts/exynos5250-arndale.dts | 120 ++++++++++++ > arch/arm/boot/dts/exynos5250-smdk5250.dts | 120 ++++++++++++ > drivers/gpu/drm/exynos/exynos_hdmi.c | 191 > +++++++------------- 4 files changed, 320 insertions(+), 129 > deletions(-) Since this series is related to Exynos platform files, please also Cc the linux-samsung-soc mailing list and Kukjin Kim. Same goes for device tree bindings. If you change anything related to device tree, you need to post your patches to devicetree@vger.kernel.org mailing list. Ccing device tree maintainers is also a good practice. Please resend this series with above two issues addressed. Best regards, Tomasz