From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8106C433E0 for ; Fri, 25 Dec 2020 03:00:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E2A122D57 for ; Fri, 25 Dec 2020 03:00:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E2A122D57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C8D689A5E; Fri, 25 Dec 2020 03:00:54 +0000 (UTC) X-Greylist: delayed 302 seconds by postgrey-1.36 at gabe; Fri, 25 Dec 2020 03:00:52 UTC Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 6165389A62 for ; Fri, 25 Dec 2020 03:00:52 +0000 (UTC) X-UUID: f39dde36f6554575bfe9647bab75f588-20201225 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=e6d/ZDiJzN/PkyONx34VeYu401D2YFYejNJdKEUj+M8=; b=rGV4kVVbuRihJ66sD7/ZRky2URSc0stGY+sBnXmscc150r6Eib1miZHR853pk+gWHP1rAC/ApB8fDqvBwr733xsLhuvBKwvyBcs7HDefVkd2Kwxg7UHpTtBHUgAnildg9IUQUo1gWbaSQxjCD/DC9LHEV3ZpQG6/xNNgWNUN6SU=; X-UUID: f39dde36f6554575bfe9647bab75f588-20201225 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1913141489; Fri, 25 Dec 2020 10:55:45 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs06n1.mediatek.inc (172.21.101.129) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Dec 2020 10:55:44 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 25 Dec 2020 10:55:44 +0800 Message-ID: <1608864944.19292.3.camel@mtksdaap41> Subject: Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type From: CK Hu To: Huijuan Xie , Chun-Kuang Hu , Philipp Zabel Date: Fri, 25 Dec 2020 10:55:44 +0800 In-Reply-To: <1608803643-7351-1-git-send-email-huijuan.xie@mediatek.com> References: <1608803643-7351-1-git-send-email-huijuan.xie@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: srv_heupstream@mediatek.com, David Airlie , stonea168@163.com, cawa.cheng@mediatek.com, dri-devel@lists.freedesktop.org, sj.huang@mediatek.com, linux-mediatek@lists.infradead.org, Matthias Brugger , yingjoe.chen@mediatek.com, eddie.huang@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" + Chun-Kuang, Philipp: This mail has been sent to dri devel and linux mediatek, but why it does not exist in mail lists? Regards, CK On Thu, 2020-12-24 at 17:54 +0800, Huijuan Xie wrote: > The interrupt trigger is already set by OF. When do devm_request_irq() > in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type > again. > > Signed-off-by: Huijuan Xie > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 4a188a9..1d62489 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) > goto err_unregister_host; > } > > - irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW); > ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq, > - IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi); > + IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi); > if (ret) { > dev_err(&pdev->dev, "failed to request mediatek dsi irq\n"); > goto err_unregister_host; _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel