From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown Date: Thu, 18 Apr 2019 10:32:52 +0200 Message-ID: <16214989.ofMSVjYgR7@phil> References: <20190402113753.10118-1-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190402113753.10118-1-heiko@sntech.de> Sender: stable-owner@vger.kernel.org To: hjc@rock-chips.com Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Vicente Bergas , Jeffy Chen , Robin Murphy , Marc Zyngier , Brian Norris , Doug Anderson , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Am Dienstag, 2. April 2019, 13:37:53 CEST schrieb Heiko Stuebner: > From: Vicente Bergas > > As explained by Robin Murphy: > > the IOMMU shutdown disables paging, so if the VOP is still > > scanning out then that will result in whatever IOVAs it was using now going > > straight out onto the bus as physical addresses. > > We had a more radical approach before in commit > 7f3ef5dedb14 ("drm/rockchip: Allow driver to be shutdown on reboot/kexec") > but that resulted in new warnings and oopses on shutdown on rk3399 > chromeos devices. > > So second try is resurrecting Vicentes shutdown change which should > achieve the same result but in a less drastic way. > > Fixes: 63238173b2fa ("Revert drm/rockchip: Allow driver to be shutdown on reboot/kexec") > Cc: Jeffy Chen > Cc: Robin Murphy > Cc: Marc Zyngier > Cc: Brian Norris > Cc: Doug Anderson > Cc: stable@vger.kernel.org > Suggested-by: JeffyChen > Suggested-by: Robin Murphy > Signed-off-by: Vicente Bergas > [adapted commit message to explain the history] > Signed-off-by: Heiko Stuebner applied to drm-misc-next Not fixes, to give it more exposure this time. It still has a stable tag so should nevertheless trickle down to stable in time as well. Thanks for all the testing Heiko