public inbox for dri-devel@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: robin.murphy@arm.com, jeffy.chen@rock-chips.com,
	dri-devel@lists.freedesktop.org, tfiga@chromium.org,
	linux-rockchip@lists.infradead.org,
	enric.balletbo@collabora.co.uk, stable@vger.kernel.org,
	tomeu.vizoso@collabora.co.uk, ezequiel@collabora.com
Subject: Re: [PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed
Date: Mon, 18 Jun 2018 10:19:46 +0200	[thread overview]
Message-ID: <1637509.0BUGQyR5Xn@diego> (raw)
In-Reply-To: <edc71874-4517-c097-c851-d60565f06817@arm.com>

Hi Marc,

Am Mittwoch, 13. Juni 2018, 15:01:27 CEST schrieb Marc Zyngier:
> On 12/06/18 14:20, Heiko Stuebner wrote:
> > From: Sandy Huang <hjc@rock-chips.com>
> > 
> > The vop irq is shared between vop and iommu and irq probing in the
> > iommu driver moved to the probe function recently. This can in some
> > cases lead to a stall if the irq is triggered while the vop driver
> > still has it disabled, but the vop irq handler gets called.
> > 
> > But there is no real need to disable the irq, as the vop can simply
> > also track its enabled state and ignore irqs in that case.
> > For this we can simply check the power-domain state of the vop,
> > similar to how the iommu driver does it.
> > 
> > So remove the enable/disable handling and add appropriate condition
> > to the irq handler.
> > 
> > changes in v2:
> > - move to just check the power-domain state
> > - add clock handling
> > changes in v3:
> > - clarify comment to speak of runtime-pm not power-domain
> > changes in v4:
> > - address Marc's comments (clk-enable WARN_ON and style improvement)
> > 
> > Fixes: d0b912bd4c23 ("iommu/rockchip: Request irqs in rk_iommu_probe()")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > Tested-by: Ezequiel Garcia <ezequiel@collabora.com>
> 
> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>

could I ask you to also look at patch1 of this series, to give it an
Ack or Review? drm-misc documentation very strongly suggests [0]
to have at least another set of eyes on a patch and so far noone
came forward ;-)

This of course also applies to everybody else in the Cc list :-D .


Thanks
Heiko


[0] https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html#merge-criteria


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-06-18  8:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 13:20 [PATCH v4 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change Heiko Stuebner
2018-06-12 13:20 ` [PATCH v4 1/2] drm/rockchip: vop: split out core clock enablement into separate functions Heiko Stuebner
2018-06-18  9:44   ` Tomasz Figa
2018-06-12 13:20 ` [PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed Heiko Stuebner
2018-06-13 13:01   ` Marc Zyngier
2018-06-18  8:19     ` Heiko Stübner [this message]
2018-06-19  8:38       ` Marc Zyngier
2018-06-18 13:09 ` [PATCH v4 0/2] drm/rockchip: try to fix vblank hang resulting from iommu irq change Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1637509.0BUGQyR5Xn@diego \
    --to=heiko@sntech.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=enric.balletbo@collabora.co.uk \
    --cc=ezequiel@collabora.com \
    --cc=jeffy.chen@rock-chips.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=tfiga@chromium.org \
    --cc=tomeu.vizoso@collabora.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox