Re: [PATCH 1/4] drm: add generic zpos property

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
	fabien.dessenne@st.com,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	vincent.abriou@st.com,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/4] drm: add generic zpos property
Date: Thu, 12 May 2016 22:06:54 +0300	[thread overview]
Message-ID: <1638804.ANJKIQ8pGq@avalon> (raw)
In-Reply-To: <20160512133607.GW27098@phenom.ffwll.local>

On Thursday 12 May 2016 15:36:07 Daniel Vetter wrote:
> On Thu, May 12, 2016 at 12:28:19PM +0200, Benjamin Gaignard wrote:
> > From: Marek Szyprowski <m.szyprowski@samsung.com>
> > 
> > This patch adds support for generic plane's zpos property property with
> > well-defined semantics:
> > - added zpos properties to plane and plane state structures
> > - added helpers for normalizing zpos properties of given set of planes
> > - well defined semantics: planes are sorted by zpos values and then plane
> > 
> >   id value if zpos equals
> > 
> > Normalized zpos values are calculated automatically when generic
> > muttable zpos property has been initialized. Drivers can simply use
> > plane_state->normalized_zpos in their atomic_check and/or plane_update
> > callbacks without any additional calls to DRM core.
> > 
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > 
> > Compare to Marek's original patch zpos property is now specific to each
> > plane and no more to the core.
> > Normalize function take care of the range of per plane defined range
> > before set normalized_zpos.
> > 
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> > 
> > Cc: Inki Dae <inki.dae@samsung.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Cc: Joonyoung Shim <jy0922.shim@samsung.com>
> > Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
> > Cc: Andrzej Hajda <a.hajda@samsung.com>
> > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> > Cc: Gustavo Padovan <gustavo@padovan.org>
> > Cc: vincent.abriou@st.com
> > Cc: fabien.dessenne@st.com
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> When resending you must have a changelog somewhere. At elast in the cover
> letter, better is per-patch. Otherwise reviewers need to dig out the old
> threads and compare themselves.

And please update the subject as well to include the version number. You can 
use

$ git format-patch --cover --subject-prefix 'PATCH vX'

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel