From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC 1/7] drm/omap: Use devm_kzalloc() to allocate omap_drm_private Date: Mon, 04 Sep 2017 12:41:57 +0300 Message-ID: <1644746.ebjSkL3KDI@avalon> References: <20170829073218.11097-1-peter.ujfalusi@ti.com> <4935903.PPgScnvqmu@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 053E28921E for ; Mon, 4 Sep 2017 09:41:59 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Ujfalusi Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgUGV0ZXIsCgpPbiBNb25kYXksIDQgU2VwdGVtYmVyIDIwMTcgMTI6MTM6NDAgRUVTVCBQZXRl ciBVamZhbHVzaSB3cm90ZToKPiBPbiAyMDE3LTA5LTAxIDE0OjEwLCBMYXVyZW50IFBpbmNoYXJ0 IHdyb3RlOgo+ID4gT24gVHVlc2RheSwgMjkgQXVndXN0IDIwMTcgMTA6MzI6MTIgRUVTVCBQZXRl ciBVamZhbHVzaSB3cm90ZToKPiA+PiBJdCBtYWtlcyB0aGUgY2xlYW51cCBwYXRocyBhIGJpdCBj bGVhbmVyLgo+ID4gCj4gPiBCdXQgaXQgYWxzbyBnb2VzIGFnYWluc3QgYSBwcm9wZXIgaW1wbGVt ZW50YXRpb24gb2Ygb2JqZWN0IGxpZmV0aW1lCj4gPiBtYW5hZ2VtZW50IDotKCBJbiBEUk0gZHJp dmVyIHByaXZhdGUgc3RydWN0dXJlcyBhcmUgYWNjZXNzaWJsZSBmcm9tIGZpbGUKPiA+IG9wZXJh dGlvbnMsIGFuZCBtdXN0IHRodXMgYmUgcmVmZXJlbmNlLWNvdW50ZWQgYW5kIG9ubHkgZnJlZWQg d2hlbiB0aGUKPiA+IGxhc3QgdXNlcnNwYWNlIHVzZXIgZ29lcyBhd2F5LiBUaGlzIG1heSBiZSBh ZnRlciB0aGUgZGV2bV8qIHJlc291cmNlcyBhcmUKPiA+IHJlbGVhc2VkIHJpZ2h0IGFmdGVyIHRo ZSAucmVtb3ZlKCkgb3BlcmF0aW9uIGlzIGNhbGxlZC4gVXNpbmcKPiA+IGRldm1fa3phbGxvYygp IHdvdWxkIHRodXMgbWFrZSBpdCBpbXBvc3NpYmxlIHRvIHByb3Blcmx5IHJlZmVyZW5jZS1jb3Vu dAo+ID4gb3VyIGRhdGEgc3RydWN0dXJlcy4KPiAKPiBIcm0sIG5vdCBzdXJlIGlmIEkgZm9sbG93 IHlvdSBvbiB0aGlzLgo+IEJlZm9yZSB0aGlzIHBhdGNoIHRoZSAncHJpdicgd2FzIGZyZWVkIHVw IGluIHBkZXZfcmVtb3ZlKCkuIFdpdGggdGhpcwo+IHBhdGNoIHRoZSAncHJpdicgaXMgZ29pbmcg dG8gYmUgZnJlZWQgdXAgYWZ0ZXIgdGhlIHBkZXZfcmVtb3ZlKCkgaGFzCj4gcmV0dXJuZWQsIHNv IHRoZSAncHJpdicgd291bGQgYmUgYXZhaWxhYmxlIGxvbmdlciB0aGFuIGJlZm9yZSBhcyB3ZQo+ IGNvbnZlcnRlZCBpdCBhcyBtYW5hZ2VkIHJlc291cmNlLgo+IAo+IElmIHdoYXQgeW91IGFyZSBz YXlpbmcgaXMgdHJ1ZSwgdGhlbiB3ZSBhbHJlYWR5IGhhdmUgdGhlIHNhbWUgaXNzdWUgYW5kCj4g SSBkb24ndCBzZWUgaG93IHRoaXMgY291bGQgaGF2ZSBiZWVuIHdvcmtpbmcgb3IgbmVlZCB0byB3 b3JrLiBJZiB5b3UKPiByZW1vdmUgdGhlIGRyaXZlciBhbmQgeW91IG5lZWQgdG8ga2VlcCB0aGUg cHJpdmF0ZSBkYXRhIGF2YWlsYWJsZSBhZnRlcgo+IHRoZSBkcml2ZXIgaGFzIGJlZW4gdW5sb2Fk ZWQsIHdobyBpcyBnb2luZyB0byBmcmVlIHRoYXQgdXA/CgpBdCB0aGUgbW9tZW50IHRoZSBtZW1v cnkgaXMgZnJlZWQgYXQgLnJlbW92ZSgpIHRpbWUsIHdoaWNoIGNhbiBsZWFkIHRvIG1lbW9yeSAK Y29ycnVwdGlvbiBpZiBhIHVzZXIgaGFzIGEgaGFuZGxlIG9uIHRoZSBkZXZpY2UgKGZvciBpbnN0 YW5jZSBhbiBvcGVuIGZpbGUgCmhhbmRsZSB0aGF0IGlzIHRoZW4gY2xvc2UoKWQpLiBGaXhpbmcg dGhpcyByZXF1aXJlcyBtb3ZpbmcgbWVtb3J5IGZyZWUgdG8gdGhlIApkcm1fZHJpdmVyOjpyZWxl YXNlKCkgaGFuZGxlci4gZGV2bV9remFsbG9jKCkgZ29lcyBpbiB0aGUgd3JvbmcgZGlyZWN0aW9u LgoKPiA+PiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBVamZhbHVzaSA8cGV0ZXIudWpmYWx1c2lAdGku Y29tPgo+ID4+IC0tLQo+ID4+IAo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Ry di5jIHwgMTkgKysrKysrKy0tLS0tLS0tLS0tLQo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPiA+PiAKPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYwo+ID4+IGIvZHJpdmVycy9ncHUvZHJtL29tYXBk cm0vb21hcF9kcnYuYyBpbmRleCA5YjNjMzZiNDgzNTYuLjkwMzUxMGQ4MDU0ZQo+ID4+IDEwMDY0 NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZHJ2LmMKPiA+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jCj4gPj4gQEAgLTU0OCwxOSArNTQ4 LDE3IEBAIHN0YXRpYyBpbnQgcGRldl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQo+ID4+IAo+ID4+ICAJCXJldHVybiByZXQ7Cj4gPj4gIAkKPiA+PiAgCX0KPiA+PiAKPiA+PiAr CXByaXYgPSBkZXZtX2t6YWxsb2MoJnBkZXYtPmRldiwgc2l6ZW9mKCpwcml2KSwgR0ZQX0tFUk5F TCk7Cj4gPj4gKwlpZiAoIXByaXYpCj4gPj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gPj4gKwo+ID4+ IAo+ID4+ICAJb21hcF9jcnRjX3ByZV9pbml0KCk7Cj4gPj4gIAkKPiA+PiAgCXJldCA9IG9tYXBf Y29ubmVjdF9kc3NkZXZzKCk7Cj4gPj4gIAlpZiAocmV0KQo+ID4+ICAJCj4gPj4gIAkJZ290byBl cnJfY3J0Y191bmluaXQ7Cj4gPj4gCj4gPj4gLQkvKiBBbGxvY2F0ZSBhbmQgaW5pdGlhbGl6ZSB0 aGUgZHJpdmVyIHByaXZhdGUgc3RydWN0dXJlLiAqLwo+ID4+IC0JcHJpdiA9IGt6YWxsb2Moc2l6 ZW9mKCpwcml2KSwgR0ZQX0tFUk5FTCk7Cj4gPj4gLQlpZiAoIXByaXYpIHsKPiA+PiAtCQlyZXQg PSAtRU5PTUVNOwo+ID4+IC0JCWdvdG8gZXJyX2Rpc2Nvbm5lY3RfZHNzZGV2czsKPiA+PiAtCX0K PiA+PiAtCj4gPj4gKwkvKiBJbml0aWFsaXplIHRoZSBkcml2ZXIgcHJpdmF0ZSBzdHJ1Y3R1cmUu ICovCj4gPj4gCj4gPj4gIAlwcml2LT5kaXNwY19vcHMgPSBkaXNwY19nZXRfb3BzKCk7Cj4gPj4g IAkKPiA+PiAgCXNvYyA9IHNvY19kZXZpY2VfbWF0Y2gob21hcGRybV9zb2NfZGV2aWNlcyk7Cj4g Pj4gCj4gPj4gQEAgLTU3NCw3ICs1NzIsNyBAQCBzdGF0aWMgaW50IHBkZXZfcHJvYmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+PiAKPiA+PiAgCWRkZXYgPSBkcm1fZGV2X2FsbG9j KCZvbWFwX2RybV9kcml2ZXIsICZwZGV2LT5kZXYpOwo+ID4+ICAJaWYgKElTX0VSUihkZGV2KSkg ewo+ID4+ICAJCj4gPj4gIAkJcmV0ID0gUFRSX0VSUihkZGV2KTsKPiA+PiAKPiA+PiAtCQlnb3Rv IGVycl9mcmVlX3ByaXY7Cj4gPj4gKwkJZ290byBlcnJfZGVzdHJveV93cTsKPiA+PiAKPiA+PiAg CX0KPiA+PiAgCQo+ID4+ICAJZGRldi0+ZGV2X3ByaXZhdGUgPSBwcml2Owo+ID4+IAo+ID4+IEBA IC02MjQsMTAgKzYyMiw4IEBAIHN0YXRpYyBpbnQgcGRldl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ID4+IAo+ID4+ICBlcnJfZnJlZV9kcm1fZGV2Ogo+ID4+ICAJb21hcF9n ZW1fZGVpbml0KGRkZXYpOwo+ID4+ICAJZHJtX2Rldl91bnJlZihkZGV2KTsKPiA+PiAKPiA+PiAt ZXJyX2ZyZWVfcHJpdjoKPiA+PiAKPiA+PiArZXJyX2Rlc3Ryb3lfd3E6Cj4gPj4gIAlkZXN0cm95 X3dvcmtxdWV1ZShwcml2LT53cSk7Cj4gPj4gCj4gPj4gLQlrZnJlZShwcml2KTsKPiA+PiAKPiA+ PiAtZXJyX2Rpc2Nvbm5lY3RfZHNzZGV2czoKPiA+PiAgCW9tYXBfZGlzY29ubmVjdF9kc3NkZXZz KCk7Cj4gPj4gIAo+ID4+ICBlcnJfY3J0Y191bmluaXQ6Cj4gPj4gIAlvbWFwX2NydGNfcHJlX3Vu aW5pdCgpOwo+ID4+IAo+ID4+IEBAIC02NTksNyArNjU1LDYgQEAgc3RhdGljIGludCBwZGV2X3Jl bW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4+IAo+ID4+ICAJZHJtX2Rldl91 bnJlZihkZGV2KTsKPiA+PiAgCQo+ID4+ICAJZGVzdHJveV93b3JrcXVldWUocHJpdi0+d3EpOwo+ ID4+IAo+ID4+IC0Ja2ZyZWUocHJpdik7Cj4gPj4gCj4gPj4gIAlvbWFwX2Rpc2Nvbm5lY3RfZHNz ZGV2cygpOwo+ID4+ICAJb21hcF9jcnRjX3ByZV91bmluaXQoKTsKCi0tIApSZWdhcmRzLAoKTGF1 cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==