From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult Date: Wed, 28 Jun 2017 11:23:33 +0300 Message-ID: <16471365.0zTRHk5KOq@avalon> References: <20170627203843.27004-1-laurent.pinchart+renesas@ideasonboard.com> <20170628081614.uuwx7i6rc4qvx62z@phenom.ffwll.local> <20170628082033.d6sykvllhzmmopm6@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A0536E505 for ; Wed, 28 Jun 2017 08:23:32 +0000 (UTC) In-Reply-To: <20170628082033.d6sykvllhzmmopm6@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Neil Armstrong , m@freedesktop.org, Liviu Dudau , dri-devel@lists.freedesktop.org, Thierry Reding , Gerd Hoffmann , Daniel Vetter , Kyungmin Park , Boris Brezillon , Thomas Hellstrom , Laurent Pinchart , Alexey Brodkin , Xinliang Liu , Xinwei Kong , Tomi Valkeinen , Mali DP Maintainers , Dave Airlie , Chen Feng , Jyri Sarha , Vincent Abriou , VMware Graphics , Alison Wang List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLAoKT24gV2VkbmVzZGF5IDI4IEp1biAyMDE3IDEwOjIwOjMzIERhbmllbCBWZXR0 ZXIgd3JvdGU6Cj4gT24gV2VkLCBKdW4gMjgsIDIwMTcgYXQgMTA6MTY6MTRBTSArMDIwMCwgRGFu aWVsIFZldHRlciB3cm90ZToKPiA+IE9uIFR1ZSwgSnVuIDI3LCAyMDE3IGF0IDExOjM4OjM1UE0g KzAzMDAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4gSGVsbG8sCj4gPj4gCj4gPj4gVGhl IGF0b21pYyBoZWxwZXJzIGZhdm91ciB0aGUgLmVuYWJsZSgpIGFuZCAuYXRvbWljX2Rpc2FibGUo KSBDUlRDCj4gPj4gaGVscGVyIG9wZXJhdGlvbnMsIGJ1dCBzdGlsbCBzdXBwb3J0IHRoZSBsZWdh Y3kgLnByZXBhcmUoKSwgLmNvbW1pdCgpLAo+ID4+IC5kaXNhYmxlKCkgYW5kIC5kcG1zKCkgb3Bl cmF0aW9ucy4gU29tZSBkcml2ZXJzIGhhdmUgYmVlbiB1cGRhdGVkLCBidXQKPiA+PiBtb3N0IHN0 aWxsIHVzZSB2YXJpb3VzIGNvbWJpbmF0aW9uIG9mIG5ldyBhbmQgbGVnYWN5IG9wZXJhdGlvbnMs Cj4gPj4gbGVhZGluZyB0byBjb25mdXNpb24gYW1vbmcgbmV3IGRldmVsb3BlcnMgd2hlbiB0aGV5 IHJlYWQgdGhlIGNvZGUuCj4gPj4gCj4gPj4gVG8gYXZvaWQgY2FyZ28tY3VsdCB1c2Ugb2YgdGhl IGxlZ2FjeSBvcGVyYXRpb25zLCB0aGlzIHBhdGNoIHNlcmllcwo+ID4+IG1hc3MtdXBkYXRlcyBh bGwgYXRvbWljIGRyaXZlcnMgdG8gdXNlIHRoZSBuZXcgQ1JUQyBhdG9taWMgaGVscGVyCj4gPj4g b3BlcmF0aW9ucy4KPiA+PiAKPiA+PiBJbiBhZGRpdGlvbiwgcGF0Y2ggNy84IGFkZHMgYW4gb2xk IHN0YXRlIHBvaW50ZXIgYXJndW1lbnQgdG8gdGhlIENSVEMKPiA+PiAuZW5hYmxlKCkgaGVscGVy IG9wZXJhdGlvbiwgYW5kIHJlbmFtZSBpdCB0byAuYXRvbWljX2VuYWJsZSgpIGZvcgo+ID4+IGNv bnNpc3RlbmN5IHdpdGggLmF0b21pY19kaXNhYmxlKCkuIFRoZXNlIHR3byBjaGFuZ2VzIGNvdWxk IGhhdmUgYmVlbgo+ID4+IHNwbGl0IGluIHNlcGFyYXRlIHBhdGNoLCBidXQgYXMgdGhleSBhcmUg c2ltcGxlIGFuZCB0b3VjaCB0aGUgc2FtZQo+ID4+IGxhcmdlIG51bWJlciBvZiBmaWxlcywga2Vl cGluZyB0aGUgdHdvIGNoYW5nZXMgYXMgb25lIGlzIHNpbXBsZXIgYW5kCj4gPj4gbGVzcyBlcnJv ci1wcm9uZS4KPiA+PiAKPiA+PiBUaGUgcGF0Y2hlcyBhcmUgYmFzZWQgb24gdG9wIG9mIHRoZSBk cm0tbWlzYy1uZXh0IGJyYW5jaCBhbmQgaGF2ZSBiZWVuCj4gPj4gY29tcGlsZS10ZXN0ZWQgb25s eSBleGNlcHQgZm9yIHJjYXItZHUtZHJtIHRoYXQgaGFzIGJlZW4gdGVzdGVkIG9uIHJlYWwKPiA+ PiBoYXJkd2FyZS4gR2l2ZW4gdGhlIGhpZ2ggcmlzayBvZiBjb25mbGljdHMgSSB3b3VsZCBsaWtl IHRvIGdldCB0aGVtCj4gPiA+IG1lcmdlZCBhcyBzb29uIGFzIHBvc3NpYmxlIChhZnRlciwgb2Yg Y291cnNlLCBwcm9wZXIgcmV2aWV3IGFuZAo+ID4+IHRlc3RpbmcpLgo+ID4gCj4gPiBNYWtlcyBz ZW5zZSwgc28gSSB3ZW50IGFoZWFkIGFuZCBwdWxsZWQgaW4gcGF0Y2hlcyAxLTYuIEkgdGhpbmsg NyY4IG5lZWQgYQo+ID4gYml0IG1vcmUgc29ha2luZyB0byBnYXRoZXIgYWNrcywgaWYgb25seSBm b3IgYXdlYXJlbmVzcy4gUGx1cyBhIGJpdCBtb3JlCj4gPiBrZXJuZWwtZG9jIHBvbGlzaCBpbW8u Cj4gCj4gT24gdGhlIGtlcm5lbC1kb2MgcG9saXNoOiBHcmVwcGluZyBmb3IgZHJtX2NydGNfaGVs cGVyX2Z1bmNzXC5lbmFibGUgYW5kCj4gXC5kaXNhYmxlIGJyb3VnaHQgdXAgYSBmZXcgcmVmZXJl bmNlcyB0aGF0IG5lZWQgdG8gYmUgdXBkYXRlZCBpbiB5b3VyCj4gcGF0Y2hlcyA3JjguCgpJIGhh ZCBqdXN0IG5vdGljZWQgdGhhdCB0b28sIGFuZCB3aWxsIGZpeCBpdCBpbiB2MiBvZiA3LzggYW5k IDgvOC4gSSdsbCB3YWl0IApmb3IgbW9yZSBhY2tzIGJlZm9yZSByZXBvc3RpbmcuCgo+ID4+IExh dXJlbnQgUGluY2hhcnQgKDgpOgo+ID4+ICAgZHJtOiBhcmNwZ3U6IFJlbW92ZSBDUlRDIC5jb21t aXQoKSBoZWxwZXIgb3BlcmF0aW9uCj4gPj4gICBkcm06IGFyY3BndTogUmVtb3ZlIENSVEMgLnBy ZXBhcmUoKSBoZWxwZXIgb3BlcmF0aW9uCj4gPj4gICBkcm06IHF4bDogUmVtb3ZlIHVudXNlZCBD UlRDIC5kcG1zKCkgaGVscGVyIG9wZXJhdGlvbgo+ID4+ICAgZHJtOiBxeGw6IFJlcGxhY2UgQ1JU QyAuY29tbWl0KCkgaGVscGVyIG9wZXJhdGlvbiB3aXRoIC5lbmFibGUoKQo+ID4+ICAgZHJtOiB2 bXdnZng6IFJlbW92ZSB1bm5lZWRlZCBDUlRDIC5wcmVwYXJlKCkgaGVscGVyIG9wZXJhdGlvbgo+ ID4+ICAgZHJtOiB2bXdnZng6IFJlcGxhY2UgQ1JUQyAuY29tbWl0KCkgaGVscGVyIG9wZXJhdGlv biB3aXRoIC5lbmFibGUoKQo+ID4+ICAgZHJtOiBBZGQgb2xkIHN0YXRlIHBvaW50ZXIgdG8gQ1JU QyAuZW5hYmxlKCkgaGVscGVyIGZ1bmN0aW9uCj4gPj4gICBkcm06IENvbnZlcnQgYXRvbWljIGRy aXZlcnMgZnJvbSBDUlRDIC5kaXNhYmxlKCkgdG8gLmF0b21pY19kaXNhYmxlKCkKPiA+PiAgCj4g Pj4gIGRyaXZlcnMvZ3B1L2RybS9hcmMvYXJjcGd1X2NydGMuYyAgICAgICAgICAgICAgIHwgMTIg KysrKy0tLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2FybS9oZGxjZF9jcnRjLmMgICAgICAgICAg ICAgICAgfCAxMCArKysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2NydGMu YyAgICAgICAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vYXRtZWwt aGxjZGMvYXRtZWxfaGxjZGNfY3J0Yy5jICB8IDEwICsrKystLS0KPiA+PiAgZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWNfaGVscGVyLmMgICAgICAgICAgICAgfCAgNyArKystLQo+ID4+ICBkcml2 ZXJzL2dwdS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmMgICAgICAgICB8IDEwICsrKystLS0K PiA+PiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2NydGMuYyAgICAgICAgfCAx MCArKysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9mc2wtZGN1L2ZzbF9kY3VfZHJtX2NydGMu YyAgICAgIHwgIDUgKystLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hp Ym1jX2RybV9kZS5jICB8IDEwICsrKystLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNv bi9raXJpbi9raXJpbl9kcm1fYWRlLmMgfCAxMCArKysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2Ry bS9pbXgvaXB1djMtY3J0Yy5jICAgICAgICAgICAgICAgIHwgIDUgKystLQo+ID4+ICBkcml2ZXJz L2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMgICAgICAgICB8IDEwICsrKystLS0KPiA+ PiAgZHJpdmVycy9ncHUvZHJtL21lc29uL21lc29uX2NydGMuYyAgICAgICAgICAgICAgfCAxMCAr KysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDQvbWRwNF9jcnRjLmMgICAg ICAgIHwgMTAgKysrKy0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL21kcC9tZHA1L21kcDVf Y3J0Yy5jICAgICAgICB8IDEwICsrKystLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v b21hcF9jcnRjLmMgICAgICAgICAgICAgfCAxMCArKysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2Ry bS9xeGwvcXhsX2Rpc3BsYXkuYyAgICAgICAgICAgICAgIHwgMTUgKysrKy0tLS0tLQo+ID4+ICBk cml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYyAgICAgICAgICB8IDEwICsrKyst LS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyAgICAg fCAxMCArKysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2NydGMuYyAgICAgICAg ICAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vc3RtL2x0ZGMuYyAg ICAgICAgICAgICAgICAgICAgICB8IDEwICsrKystLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL3N1 bjRpL3N1bjRpX2NydGMuYyAgICAgICAgICAgICAgfCAxMCArKysrLS0tCj4gPj4gIGRyaXZlcnMv Z3B1L2RybS90ZWdyYS9kYy5jICAgICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4+ ICBkcml2ZXJzL2dwdS9kcm0vdGlsY2RjL3RpbGNkY19jcnRjLmMgICAgICAgICAgICB8IDE2ICsr KysrKysrKy0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2NydGMuYyAgICAgICAgICAg ICAgICAgIHwgMTAgKysrKy0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVf ZGlzcGxheS5jICAgICAgICB8IDEwICsrKystLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dm eC92bXdnZnhfbGR1LmMgICAgICAgICAgICAgfCAyNyArKysrKystLS0tLS0tLS0tLS0KPiA+PiAg ZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfc2Nybi5jICAgICAgICAgICAgfCAxNCArKysr Ky0tLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfc3RkdS5jICAgICAgICAg ICAgfCAxMCArKysrLS0tCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS96dGUvenhfdm91LmMgICAgICAg ICAgICAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4+ICBpbmNsdWRlL2RybS9kcm1fbW9kZXNldF9o ZWxwZXJfdnRhYmxlcy5oICAgICAgICB8IDM4ICsrKysrKysrKy0tLS0tLS0tLQo+ID4+ICAzMSBm aWxlcyBjaGFuZ2VkLCAyMDQgaW5zZXJ0aW9ucygrKSwgMTU1IGRlbGV0aW9ucygtKQoKLS0gClJl Z2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK