From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback Date: Thu, 12 Jul 2018 14:37:04 +0300 Message-ID: <1668395.xiXQ9REbAx@avalon> References: <20180712083635.7472-1-mahesh1.kumar@intel.com> <20180712083635.7472-6-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180712083635.7472-6-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTWFoZXNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHVyc2RheSwgMTIgSnVs eSAyMDE4IDExOjM2OjMwIEVFU1QgTWFoZXNoIEt1bWFyIHdyb3RlOgo+IFRoaXMgcGF0Y2ggaW1w bGVtZW50cyAidmVyaWZ5X2NyY19zb3VyY2UiIGNhbGxiYWNrIGZ1bmN0aW9uIGZvcgo+IHJjYXIg ZHJtIGRyaXZlci4KPiAKPiBDaGFuZ2VzIFNpbmNlIFYxOgo+ICAtIGF2b2lkIGR1cGxpY2F0aW9u IG9mIGNvZGUKPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWhlc2ggS3VtYXIgPG1haGVzaDEua3VtYXJA aW50ZWwuY29tPgo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IExh dXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiBSZXZp ZXdlZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVs LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMgfCA2 NiArKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1MyBp bnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1 L3JjYXJfZHVfY3J0Yy5jIGluZGV4IDE1ZGM5Y2FhMTI4Yi4uNzEyNDkxODM3MmY4Cj4gMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYwo+IEBAIC03NTYsMTcgKzc1Niw2 NiBAQCBzdGF0aWMgdm9pZCByY2FyX2R1X2NydGNfZGlzYWJsZV92Ymxhbmsoc3RydWN0Cj4gZHJt X2NydGMgKmNydGMpIHJjcnRjLT52YmxhbmtfZW5hYmxlID0gZmFsc2U7Cj4gIH0KPiAKPiArc3Rh dGljIGludCByY2FyX2R1X2dldF9wbGFuZV9pbmRleChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCgpQ bGVhc2UgcGFzcyBhIHN0cnVjdCByY2FyX2R1X2NydGMgcG9pbnRlciB0byB0aGlzIGZ1bmN0aW9u LCBhcyBjYWxsZXJzIHNob3VsZCAKYWxyZWFkeSBoYXZlIGl0IChvciBjYW4gZWFzaWx5IGNvbXB1 dGUgaXQpLgoKPiArCQkJCSAgIGNvbnN0IGNoYXIgKnNvdXJjZV9uYW1lLAo+ICsJCQkJICAgdW5z aWduZWQgaW50ICppbmRleCkKCkkgdGhpbmsgeW91IGNhbiBzaW1wbGlmeSB0aGlzIGJ5IHJldHVy bmluZyB0aGUgaW5kZXgsIHdoaWNoIGlzIGFsd2F5cyAKcG9zaXRpdmUsIG9yIGEgbmVnYXRpdmUg ZXJyb3IgY29kZSBpbiBjYXNlIG9mIGVycm9yLgoKSSB0aGluayB5b3UgY291bGQgc2hhcmUgZXZl biBtb3JlIGNvZGUgaWYgeW91IG5hbWVkIHRoaXMgZnVuY3Rpb24gCnJjYXJfZHVfY3J0Y19wYXJz ZV9jcmNfc291cmNlKCkgYW5kIHJldHVybmVkIGJvdGggdGhlIGluZGV4IGFuZCB0aGUgCnZzcDFf ZHVfY3JjX3NvdXJjZSAob25lIG9mIHRoZW0gdGhyb3VnaCBhIHBvaW50ZXIpLgoKPiArewo+ICsJ c3RydWN0IHJjYXJfZHVfY3J0YyAqcmNydGMgPSB0b19yY2FyX2NydGMoY3J0Yyk7Cj4gKwl1bnNp Z25lZCBpbnQgaTsKPiArCWludCByZXQgPSAwOwoKTm8gbmVlZCB0byBpbml0aWFsaXplIHJldCB0 byAwLgoKPiArCj4gKwlyZXQgPSBrc3RydG91aW50KHNvdXJjZV9uYW1lICsgc3RybGVuKCJwbGFu ZSIpLCAxMCwgaW5kZXgpOwoKVGhpcyBhc3N1bWVzIHRoYXQgdGhlIGNhbGxlciB3aWxsIGFsd2F5 cyBlbnN1cmUgdGhhdCBzb3VyY2VfbmFtIHN0YXJ0cyB3aXRoIAoicGxhbmUiLCBvdGhlcndpc2Ug eW91IGNvdWxkIGFjY2VzcyB0aGUgc3RyaW5nIGJleW9uZCBpdHMgZW5kLiBUaGlzIHBhdGNoIGlz IApmaW5lLCBidXQgaXQgd291bGQgYmUgZWFzeSB0byB1c2UgdGhlIGZ1bmN0aW9uIGVycm9uZW91 c2x5IGluIHRoZSBmdXR1cmUuIEhvdyAKYWJvdXQgbW92aW5nIHRoZSBzdHJzdGFydHMoc291cmNl X25hbWUsICJwbGFuZSIpIGNoZWNrIGF0IHRoZSBiZWdpbm5pbmcgb2YgCnRoaXMgZnVuY3Rpb24g PwoKPiArCWlmIChyZXQgPCAwKQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJZm9yIChpID0gMDsg aSA8IHJjcnRjLT52c3AtPm51bV9wbGFuZXM7ICsraSkgewo+ICsJCWlmICgqaW5kZXggPT0gcmNy dGMtPnZzcC0+cGxhbmVzW2ldLnBsYW5lLmJhc2UuaWQpIHsKPiArCQkJKmluZGV4ID0gaTsKPiAr CQkJYnJlYWs7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCWlmIChpID49IHJjcnRjLT52c3AtPm51bV9w bGFuZXMpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsK PiArc3RhdGljIGludCByY2FyX2R1X2NydGNfdmVyaWZ5X2NyY19zb3VyY2Uoc3RydWN0IGRybV9j cnRjICpjcnRjLAo+ICsJCQkJCSAgY29uc3QgY2hhciAqc291cmNlX25hbWUsCj4gKwkJCQkJICBz aXplX3QgKnZhbHVlc19jbnQpCj4gK3sKPiArCWludCByZXQ7Cj4gKwl1bnNpZ25lZCBpbnQgaW5k ZXg7CgpQbGVhc2Ugc29ydCB2YXJpYWJsZSBkZWNsYXJhdGlvbnMgcm91Z2hseSBieSBsaW5lIGxl bmd0aCB0byBtYXRjaCB0aGUgc3R5bGUgb2YgCnRoZSBkcml2ZXIuCgpZb3UgbmVlZCBhIGJsYW5r IGxpbmUgaGVyZS4KCj4gKwkvKgo+ICsJICogUGFyc2UgdGhlIHNvdXJjZSBuYW1lLiBTdXBwb3J0 ZWQgdmFsdWVzIGFyZSAicGxhbmUldSIgdG8gY29tcHV0ZSB0aGUKPiArCSAqIENSQyBvbiBhbiBp bnB1dCBwbGFuZSAoJXUgaXMgdGhlIHBsYW5lIElEKSwgYW5kICJhdXRvIiB0byBjb21wdXRlIHRo ZQo+ICsJICogQ1JDIG9uIHRoZSBjb21wb3NlciAoVlNQKSBvdXRwdXQuCj4gKwkgKi8KPiArCWlm ICghc291cmNlX25hbWUgfHwgIXN0cmNtcChzb3VyY2VfbmFtZSwgImF1dG8iKSkgewoKQ2FuIHNv dXJjZV9uYW1lIGJlIE5VTEwgaGVyZSA/Cgo+ICsJCWdvdG8gb3V0Owo+ICsJfSBlbHNlIGlmIChz dHJzdGFydHMoc291cmNlX25hbWUsICJwbGFuZSIpKSB7Cj4gKwkJcmV0ID0gcmNhcl9kdV9nZXRf cGxhbmVfaW5kZXgoY3J0Yywgc291cmNlX25hbWUsICZpbmRleCk7Cj4gKwkJaWYgKHJldCA8IDAp Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwl9IGVsc2Ugewo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJ fQo+ICsKPiArb3V0Ogo+ICsJKnZhbHVlc19jbnQgPSAxOwo+ICsJcmV0dXJuIDA7Cj4gK30KPiAr Cj4gIHN0YXRpYyBpbnQgcmNhcl9kdV9jcnRjX3NldF9jcmNfc291cmNlKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YywKPiAgCQkJCSAgICAgICBjb25zdCBjaGFyICpzb3VyY2VfbmFtZSwKPiAgCQkJCSAg ICAgICBzaXplX3QgKnZhbHVlc19jbnQpCj4gIHsKPiAtCXN0cnVjdCByY2FyX2R1X2NydGMgKnJj cnRjID0gdG9fcmNhcl9jcnRjKGNydGMpOwo+ICAJc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVf Y3R4IGN0eDsKPiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiAgCXN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiAgCWVudW0gdnNwMV9kdV9jcmNfc291cmNlIHNv dXJjZTsKPiAgCXVuc2lnbmVkIGludCBpbmRleCA9IDA7Cj4gLQl1bnNpZ25lZCBpbnQgaTsKPiAg CWludCByZXQ7Cj4gCj4gIAkvKgo+IEBAIC03ODEsMTkgKzgzMCw5IEBAIHN0YXRpYyBpbnQgcmNh cl9kdV9jcnRjX3NldF9jcmNfc291cmNlKHN0cnVjdCBkcm1fY3J0Ywo+ICpjcnRjLCB9IGVsc2Ug aWYgKHN0cnN0YXJ0cyhzb3VyY2VfbmFtZSwgInBsYW5lIikpIHsKPiAgCQlzb3VyY2UgPSBWU1Ax X0RVX0NSQ19QTEFORTsKPiAKPiAtCQlyZXQgPSBrc3RydG91aW50KHNvdXJjZV9uYW1lICsgc3Ry bGVuKCJwbGFuZSIpLCAxMCwgJmluZGV4KTsKPiArCQlyZXQgPSByY2FyX2R1X2dldF9wbGFuZV9p bmRleChjcnRjLCBzb3VyY2VfbmFtZSwgJmluZGV4KTsKPiAgCQlpZiAocmV0IDwgMCkKPiAgCQkJ cmV0dXJuIHJldDsKPiAtCj4gLQkJZm9yIChpID0gMDsgaSA8IHJjcnRjLT52c3AtPm51bV9wbGFu ZXM7ICsraSkgewo+IC0JCQlpZiAoaW5kZXggPT0gcmNydGMtPnZzcC0+cGxhbmVzW2ldLnBsYW5l LmJhc2UuaWQpIHsKPiAtCQkJCWluZGV4ID0gaTsKPiAtCQkJCWJyZWFrOwo+IC0JCQl9Cj4gLQkJ fQo+IC0KPiAtCQlpZiAoaSA+PSByY3J0Yy0+dnNwLT5udW1fcGxhbmVzKQo+IC0JCQlyZXR1cm4g LUVJTlZBTDsKPiAgCX0gZWxzZSB7Cj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gQEAgLTg2 MSw2ICs5MDAsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9jcnRjX2Z1bmNzIGNydGNfZnVu Y3NfZ2VuMyA9IHsKPiAgCS5lbmFibGVfdmJsYW5rID0gcmNhcl9kdV9jcnRjX2VuYWJsZV92Ymxh bmssCj4gIAkuZGlzYWJsZV92YmxhbmsgPSByY2FyX2R1X2NydGNfZGlzYWJsZV92YmxhbmssCj4g IAkuc2V0X2NyY19zb3VyY2UgPSByY2FyX2R1X2NydGNfc2V0X2NyY19zb3VyY2UsCj4gKwkudmVy aWZ5X2NyY19zb3VyY2UgPSByY2FyX2R1X2NydGNfdmVyaWZ5X2NyY19zb3VyY2UsCj4gIH07Cj4g Cj4gIC8qIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=