From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] qxl: fix null-pointer crash during suspend
Date: Tue, 02 Oct 2018 13:05:50 +0300
Message-ID: <1688275.zophSNHJ2k@avalon>
References: <20180904202747.14968-1-peter@lekensteyn.nl>
 <20181002081422.GH11082@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
 [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 497026E0CC
 for <dri-devel@lists.freedesktop.org>; Tue,  2 Oct 2018 10:05:36 +0000 (UTC)
In-Reply-To: <20181002081422.GH11082@phenom.ffwll.local>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Alan Jenkins <alan.christopher.jenkins@gmail.com>, Peter Wu <peter@lekensteyn.nl>, Dave Airlie <airlied@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

SGVsbG8sCgpPbiBUdWVzZGF5LCAyIE9jdG9iZXIgMjAxOCAxMToxNDoyMiBFRVNUIERhbmllbCBW
ZXR0ZXIgd3JvdGU6Cj4gT24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMTA6Mjc6NDdQTSArMDIwMCwg
UGV0ZXIgV3Ugd3JvdGU6Cj4gPiAiY3J0Yy0+aGVscGVyX3ByaXZhdGUiIGlzIG5vdCBpbml0aWFs
aXplZCBieSB0aGUgUVhMIGRyaXZlciBhbmQgdGh1cyB0aGUKPiAKPiBUaGlzIGlzIHN0aWxsIGlu
aXRpYWxpemVkLCBpdCdzIHRoZSAtPmRpc2FibGUgdGhhdCBnb2VzIGJvb20uIEF0IGxlYXN0IHRo
ZQo+IGNhbGwgdG8gZHJtX2NydGNfaGVscGVyX2FkZCBpcyBzdGlsbCB0aGVyZS4gVGhlIC0+ZGlz
YWJsZSB3YXMgcmVtb3ZlZCBpbjoKPiAKPiBjb21taXQgNjQ1ODE3MTRiNThiYzNlMTZlZGU4ZGMz
N2EwMjVjM2FhMGUwZWVmMQo+IEF1dGhvcjogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5j
aGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gRGF0ZTogICBGcmkgSnVuIDMwIDEyOjM2
OjQ1IDIwMTcgKzAzMDAKPiAKPiAgICAgZHJtOiBDb252ZXJ0IGF0b21pYyBkcml2ZXJzIGZyb20g
Q1JUQyAuZGlzYWJsZSgpIHRvIC5hdG9taWNfZGlzYWJsZSgpCj4gCj4gRml4ZXM6IDY0NTgxNzE0
YjU4YiAoImRybTogQ29udmVydCBhdG9taWMgZHJpdmVycyBmcm9tIENSVEMgLmRpc2FibGUoKSB0
bwo+IC5hdG9taWNfZGlzYWJsZSgpIikgQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIHY0
LjE0Kwo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNo
Pgo+IAo+IEknbGwgbGV0IEdlcmQgcGljayB0aGlzIG9uZSB1cCwgYWZ0ZXIgc29tZSB0ZXN0aW5n
LiBBbHNvIGFkZGluZyBMYXVyZW50LgoKU29ycnkgZm9yIGJyZWFraW5nIGl0IDotKCBQbGVhc2Ug
bGV0IG1lIGtub3cgaWYgdGhlcmUncyBzb21ldGhpbmcgSSBjYW4gZG8gdG8gCmhlbHAuCgo+ID4g
ImNydGNfZnVuY3MtPmRpc2FibGUiIGNhbGwgd291bGQgY3Jhc2ggKHJlc3VsdGluZyBpbiBzdXNw
ZW5kIGZhaWx1cmUpLgo+ID4gRml4IHRoaXMgYnkgY29udmVydGluZyB0aGUgc3VzcGVuZC9yZXN1
bWUgZnVuY3Rpb25zIHRvIHVzZSB0aGUKPiA+IGRybV9tb2RlX2NvbmZpZ19oZWxwZXJfKiBoZWxw
ZXJzLgo+ID4gCj4gPiBUZXN0ZWQgc3lzdGVtIHNsZWVwIHdpdGggUUVNVSAzLjAgdXNpbmcgImVj
aG8gbWVtID4gL3N5cy9wb3dlci9zdGF0ZSIuCj4gPiAKPiA+IER1cmluZyBzdXNwZW5kIHRoZSBm
b2xsb3dpbmcgbWVzc2FnZSBpcyB2aXNpYmxlIGZyb20gUUVNVToKPiA+ICAgICBzcGljZS9zZXJ2
ZXIvZGlzcGxheS1jaGFubmVsLmM6MjQyNTpkaXNwbGF5X2NoYW5uZWxfdmFsaWRhdGVfc3VyZmFj
ZToKPiA+ICAgICBjYW52YXMgYWRkcmVzcyBpcyAweDdmZDA1ZGE2ODMwOCBmb3IgMCAoYW5kIGlz
IE5VTEwpCj4gPiAgICAgc3BpY2Uvc2VydmVyL2Rpc3BsYXktY2hhbm5lbC5jOjI0MjY6ZGlzcGxh
eV9jaGFubmVsX3ZhbGlkYXRlX3N1cmZhY2U6Cj4gPiAgICAgZmFpbGVkIG9uIDA+IAo+ID4gVGhp
cyBzZWVtcyB0byBiZSB0cmlnZ2VyZWQgYnkgUVhMX0lPX05PVElGWV9DTUQgYWZ0ZXIKPiA+IFFY
TF9JT19ERVNUUk9ZX1BSSU1BUllfQVNZTkMsIGJ1dCBhc2lkZSBmcm9tIHRoZSB3YXJuaW5nIHRo
aW5ncyBzdGlsbAo+ID4gc2VlbSB0byB3b3JrICh0ZXN0ZWQgd2l0aCBib3RoIHRoZSBHVEsgYW5k
IC1zcGljZSBvcHRpb25zKS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgV3UgPHBldGVy
QGxla2Vuc3RleW4ubmw+Cj4gPiAtLS0KPiA+IEhpLAo+ID4gCj4gPiBJIGZvdW5kIHRoaXMgaXNz
dWUgd2hpbGUgdHJ5aW5nIHRvIHN1c3BlbmQgYSBWTSB0aGF0IHVzZXMgUVhMLiBJbiBvcmRlciB0
bwo+ID4gc2VlIHRoZSBzdGFjayB0cmFjZSBvdmVyIHNlcmlhbCwgYm9vdCB3aXRoIG5vX2NvbnNv
bGVfc3VzcGVuZC4gU2VhcmNoaW5nCj4gPiBmb3IgInF4bF9kcm1fZnJlZXplIiBzaG93ZWQgb25l
IHJlY2VudCByZXBvcnQgZnJvbSBBbGFuOgo+ID4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci84
OTFlMzM0Yy1jZjE5LTAzMmMtYjk5Ni01OWFjMTY2ZmNkZTFAZ21haWwuY29tCj4gPiAKPiA+IEtp
bmQgcmVnYXJkcywKPiA+IFBldGVyCj4gPiAtLS0KPiA+IAo+ID4gIGRyaXZlcnMvZ3B1L2RybS9x
eGwvcXhsX2Rydi5jIHwgMjYgKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUg
Y2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAt
LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL3F4
bC9xeGxfZHJ2LmMKPiA+IGluZGV4IDI0NDVlNzVjZjdlYS4uZDAwZjQ1ZWVkMDNjIDEwMDY0NAo+
ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZHJ2LmMKPiA+ICsrKyBiL2RyaXZlcnMv
Z3B1L2RybS9xeGwvcXhsX2Rydi5jCj4gPiBAQCAtMTM2LDIwICsxMzYsMTEgQEAgc3RhdGljIGlu
dCBxeGxfZHJtX2ZyZWV6ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gCj4gPiAgewo+ID4g
IAo+ID4gIAlzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IGRldi0+cGRldjsKPiA+ICAJc3RydWN0IHF4
bF9kZXZpY2UgKnFkZXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ID4gCj4gPiAtCXN0cnVjdCBkcm1f
Y3J0YyAqY3J0YzsKPiA+IC0KPiA+IC0JZHJtX2ttc19oZWxwZXJfcG9sbF9kaXNhYmxlKGRldik7
Cj4gPiAtCj4gPiAtCWNvbnNvbGVfbG9jaygpOwo+ID4gLQlxeGxfZmJkZXZfc2V0X3N1c3BlbmQo
cWRldiwgMSk7Cj4gPiAtCWNvbnNvbGVfdW5sb2NrKCk7Cj4gPiArCWludCByZXQ7Cj4gPiAKPiA+
IC0JLyogdW5waW4gdGhlIGZyb250IGJ1ZmZlcnMgKi8KPiA+IC0JbGlzdF9mb3JfZWFjaF9lbnRy
eShjcnRjLCAmZGV2LT5tb2RlX2NvbmZpZy5jcnRjX2xpc3QsIGhlYWQpIHsKPiA+IC0JCWNvbnN0
IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVuY3MgKmNydGNfZnVuY3MgPSBjcnRjLQo+aGVscGVy
X3ByaXZhdGU7Cj4gPiAtCQlpZiAoY3J0Yy0+ZW5hYmxlZCkKPiA+IC0JCQkoKmNydGNfZnVuY3Mt
PmRpc2FibGUpKGNydGMpOwo+ID4gLQl9Cj4gPiArCXJldCA9IGRybV9tb2RlX2NvbmZpZ19oZWxw
ZXJfc3VzcGVuZChkZXYpOwo+ID4gKwlpZiAocmV0KQo+ID4gKwkJcmV0dXJuIHJldDsKPiA+IAo+
ID4gIAlxeGxfZGVzdHJveV9tb25pdG9yc19vYmplY3QocWRldik7Cj4gPiAgCXF4bF9zdXJmX2V2
aWN0KHFkZXYpOwo+ID4gCj4gPiBAQCAtMTc1LDE0ICsxNjYsNyBAQCBzdGF0aWMgaW50IHF4bF9k
cm1fcmVzdW1lKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiBib29sIHRoYXcpPiAKPiA+ICAJ
fQo+ID4gIAkKPiA+ICAJcXhsX2NyZWF0ZV9tb25pdG9yc19vYmplY3QocWRldik7Cj4gPiAKPiA+
IC0JZHJtX2hlbHBlcl9yZXN1bWVfZm9yY2VfbW9kZShkZXYpOwo+ID4gLQo+ID4gLQljb25zb2xl
X2xvY2soKTsKPiA+IC0JcXhsX2ZiZGV2X3NldF9zdXNwZW5kKHFkZXYsIDApOwo+ID4gLQljb25z
b2xlX3VubG9jaygpOwo+ID4gLQo+ID4gLQlkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZShkZXYp
Owo+ID4gLQlyZXR1cm4gMDsKPiA+ICsJcmV0dXJuIGRybV9tb2RlX2NvbmZpZ19oZWxwZXJfcmVz
dW1lKGRldik7Cj4gPiAKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIGludCBxeGxfcG1fc3VzcGVu
ZChzdHJ1Y3QgZGV2aWNlICpkZXYpCgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoK
Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl
bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp
c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=