From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71693C4167D for ; Fri, 10 Nov 2023 20:42:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E962210E10B; Fri, 10 Nov 2023 20:42:53 +0000 (UTC) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id B385810E10B for ; Fri, 10 Nov 2023 20:42:51 +0000 (UTC) Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3b3e13fc1f7so1412083b6e.0 for ; Fri, 10 Nov 2023 12:42:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648971; x=1700253771; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EYRGPcRyh2b3fkqQmyXc07beY1rNkEkbKXxns94N0UA=; b=q4+lIOi2rLLqGhHlVOITSnX/6TcdG4FFzNKNTMSQhXuLFWVpEnJMTap7Kx1UTT4qWu LYv05gTykzyHNdAhqnPdrrTo+Xo1U6muUtXSp7eSwPBwUqx9kiEZ4nGQHUpmTpKsmB7z YG21JVotZv4uJRCSDJzcyjhZ+6ezftc177nowmzj5NPQzt5qmEQrw7hv+sE1VKeYL6wX +nRU4q67fXImw20D6pqNqBUh17IbUDCgFhBkXpw5JvAxyu1fKHK9JkuRYVsaKlXYp2OL VKm2vD+sA+o7Ie2WDVoG6EIiAj8mzaIuUG7qmt15u3ZlpjrqTVv9d1Z4j+dSMG0YgA3X 6Ndg== X-Gm-Message-State: AOJu0Yzw9XW0i+GOiCmVekN7hKxv7i8rgM5C4dFjZvE0LcGS0wq3UKbe 296PT4xHzP23EyURcfAIOw== X-Google-Smtp-Source: AGHT+IEbpkkUwMS8m0HRQeTKdMYwXj4e9rjshafhVsgnG4tRletjT6wKTUFDB5opO1qLTOQnh19aYQ== X-Received: by 2002:a05:6808:23cb:b0:3b6:d617:a6f7 with SMTP id bq11-20020a05680823cb00b003b6d617a6f7mr539897oib.3.1699648970928; Fri, 10 Nov 2023 12:42:50 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id x26-20020a54401a000000b003b2e3e0284fsm42223oie.53.2023.11.10.12.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:42:50 -0800 (PST) Received: (nullmailer pid 397808 invoked by uid 1000); Fri, 10 Nov 2023 20:42:48 -0000 Date: Fri, 10 Nov 2023 14:42:48 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH 10/17] dt-bindings: iio: samsung, exynos-adc: add specific compatibles for existing SoC Message-ID: <169964896802.397769.16770997428730838541.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108104343.24192-11-krzysztof.kozlowski@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Alim Akhtar , Alexandre Belloni , linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, Tomasz Figa , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-i2c@vger.kernel.org, Sylwester Nawrocki , linux-rtc@vger.kernel.org, Krzysztof Kozlowski , Jiri Slaby , Lee Jones , Jaehoon Chung , linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Ulf Hansson , devicetree@vger.kernel.org, Conor Dooley , Andi Shyti , linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, Mark Brown , Maxime Ripard , Sam Protsenko , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Liam Girdwood , Rob Herring , Thomas Zimmermann , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 08 Nov 2023 11:43:36 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > Acked-by: Rob Herring