From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frediano Ziglio Subject: Re: [PATCH] Do not loop on ERESTARTSYS using interruptible waits Date: Fri, 22 May 2015 09:58:10 -0400 (EDT) Message-ID: <1702166382.3247503.1432303090162.JavaMail.zimbra@redhat.com> References: <1591625424.1112688.1432028990916.JavaMail.zimbra@redhat.com> <163000764.1114319.1432029294390.JavaMail.zimbra@redhat.com> <20150522115805.GR20750@edamame.cdg.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150522115805.GR20750@edamame.cdg.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spice-devel-bounces@lists.freedesktop.org Sender: "Spice-devel" To: Christophe Fergeau Cc: David Airlie , spice-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie List-Id: dri-devel@lists.freedesktop.org Cj4gCj4gSGV5LAo+IAo+IE9uIFR1ZSwgTWF5IDE5LCAyMDE1IGF0IDA1OjU0OjU0QU0gLTA0MDAs IEZyZWRpYW5vIFppZ2xpbyB3cm90ZToKPiA+IFRoaXMgcHJvYmxlbSBoYXBwZW5zIHVzaW5nIEtN UyBzdXJmYWNlcyBhbmQgUVhMIGRyaXZlci4KPiA+IFRvIGVhc3kgcmVwcm9kdWNlIHVzZSBLREUg UGxhc21hICh3aGljaCB1c2Ugc3VyZmFjZXMgYSBsb3QpIGFuZCBhc3N1cmUKPiA+IHlvdSBhcmUg dXNpbmcgS01TIHN1cmZhY2VzIChRWEwgZHJpdmVyIG9uIEZlZG9yYS9SZWRIYXQgaGFzIGEgcGF0 Y2ggdG8KPiA+IHN0b3AgdXNpbmcgdGhlbSkuIE9wZW4gc29tZSBjb21wbGV4IGFwcGxpY2F0aW9u IGxpa2UgTGlicmVPZmZpY2UgYW5kCj4gPiBhZnRlciBhIHdoaWxlIHlvdXIgbWFjaGluZSBnZXQg c3R1Y2sgdXNpbmcgMTAwJSBDUFUgb24gWG9yZy4KPiA+IFRoZSBwcm9ibGVtIG9jY3VycyBhcyBj cmVhdGluZyBuZXcgc3VyZmFjZXMgbm90IGludGVycnVwdGlibGUgd2FpdAo+ID4gYXJlIHVzZWQg aG93ZXZlciBpbnN0ZWFkIG9mIHJldHVybmluZyBFUkVTVEFSVFNZUyBiYWNrIHRvIHVzZXJzcGFj ZQo+ID4geW91IHRyeSB0byBsb29wIGJ1dCB3YWl0IHJvdXRpbmVzIGFsd2F5cyBrZWVwIHJldHVy bmluZyBFUkVTVEFSVFNZUwo+ID4gb25jZSB0aGUgc2lnbmFsIGlzIG1hcmtlZC4KPiA+IE9uIG91 dCBvZiBtZW1vcnkgY29uZGl0aW9ucyBUVE0gbW9kdWxlIHRyeSB0byBtb3ZlIG9iamVjdHMgdG8g c3lzdGVtCj4gPiBtZW1vcnkgYW5kIFFYTCBhc3N1cmUgc3VyZmFjZSBpcyB1cGRhdGVkIGJlZm9y ZSB0aGUgbW92ZS4KPiA+IFRoZSBmaXggaGFuZGxlIGRpZmZlcmVudGx5IHRoaXMgY2FzZSB1c2lu ZyBubyBpbnRlcnJ1cHRpYmxlIHdhaXQgc28KPiA+IHdhaXQgZnVuY3Rpb25zIHdpbGwgd2FpdCBp bnN0ZWFkIG9mIHJldHVybmluZyBFUkVTVEFSVFNZUy4KPiA+IE5vdGUgdGhlIHdoZW4gdGhlIGxv b3Agb2NjdXJzIGRyaXZlciB3aWxsIHNlbmQgYSBsb3Qgb2YgdXBkYXRlIHJlcXVlc3RzCj4gPiBj YXVzaW5nIG1vcmUgQ1BVIHVzYWdlIG9uIFFlbXUgc2lkZSB0b28uCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IEZyZWRpYW5vIFppZ2xpbyA8ZnppZ2xpb0ByZWRoYXQuY29tPgo+ID4gLS0tCj4gPiAg cXhsL3F4bF9jbWQuYyAgIHwgMTIgKysrLS0tLS0tLS0tCj4gPiAgcXhsL3F4bF9kcnYuaCAgIHwg IDIgKy0KPiA+ICBxeGwvcXhsX2lvY3RsLmMgfCAgMiArLQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwg NSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9kcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9jbWQuYyBiL3F4bC9xeGxfY21k LmMKPiA+IGluZGV4IDk3ODIzNjQuLmJkNTQwNGUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vcXhsL3F4bF9jbWQuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfY21k LmMKPiA+IEBAIC0zMTcsMTQgKzMxNywxMSBAQCBzdGF0aWMgdm9pZCB3YWl0X2Zvcl9pb19jbWQo c3RydWN0IHF4bF9kZXZpY2UgKnFkZXYsCj4gPiB1aW50OF90IHZhbCwgbG9uZyBwb3J0KQo+ID4g IHsKPiA+ICAJaW50IHJldDsKPiA+ICAKPiA+IC1yZXN0YXJ0Ogo+ID4gIAlyZXQgPSB3YWl0X2Zv cl9pb19jbWRfdXNlcihxZGV2LCB2YWwsIHBvcnQsIGZhbHNlKTsKPiA+IC0JaWYgKHJldCA9PSAt RVJFU1RBUlRTWVMpCj4gPiAtCQlnb3RvIHJlc3RhcnQ7Cj4gCj4gSSB0aGluayB0aGlzIG9uZSBp cyBub3QgZGlyZWN0bHkgcmVsYXRlZCB0byB0aGUgZml4LCBidXQgY2FuIGJlIHJlbW92ZWQKPiBi ZWNhdXNlIHdhaXRfZm9yX2lvX2NtZF91c2VyKHFkZXYsIHZhbCwgcG9ydCwgZmFsc2UpOyB3aWxs IGNhbGwKPiB3YWl0X2V2ZW50X3RpbWVvdXQoKSB3aGljaCBjYW5ub3QgcmV0dXJuIEVSRVNUQVJU U1lTPyBPciB3YXMgdGhpcyBsb29wCj4gY2F1c2luZyBpc3N1ZXMgdG9vPwo+IAoKWWVzLCBidXQg aXQgaGFzIHRoZSBzYW1lIGlzc3VlLiBUcnkgdGlsbCBFUkVTVEFSVFNZUyBhcmUgZ29uZS4KQ3Vy cmVudGx5IHBlcmhhcHMgbm90IGJyb2tlbiBidXQgcHJvbmUgdG8gaGF2ZSBzYW1lIGlzc3VlLgoK PiA+ICB9Cj4gPiAgCj4gPiAgaW50IHF4bF9pb191cGRhdGVfYXJlYShzdHJ1Y3QgcXhsX2Rldmlj ZSAqcWRldiwgc3RydWN0IHF4bF9ibyAqc3VyZiwKPiA+IC0JCQljb25zdCBzdHJ1Y3QgcXhsX3Jl Y3QgKmFyZWEpCj4gPiArCQkJY29uc3Qgc3RydWN0IHF4bF9yZWN0ICphcmVhLCBib29sIGludHIp Cj4gPiAgewo+ID4gIAlpbnQgc3VyZmFjZV9pZDsKPiA+ICAJdWludDMyX3Qgc3VyZmFjZV93aWR0 aCwgc3VyZmFjZV9oZWlnaHQ7Cj4gPiBAQCAtMzUwLDcgKzM0Nyw3IEBAIGludCBxeGxfaW9fdXBk YXRlX2FyZWEoc3RydWN0IHF4bF9kZXZpY2UgKnFkZXYsIHN0cnVjdAo+ID4gcXhsX2JvICpzdXJm LAo+ID4gIAltdXRleF9sb2NrKCZxZGV2LT51cGRhdGVfYXJlYV9tdXRleCk7Cj4gPiAgCXFkZXYt PnJhbV9oZWFkZXItPnVwZGF0ZV9hcmVhID0gKmFyZWE7Cj4gPiAgCXFkZXYtPnJhbV9oZWFkZXIt PnVwZGF0ZV9zdXJmYWNlID0gc3VyZmFjZV9pZDsKPiA+IC0JcmV0ID0gd2FpdF9mb3JfaW9fY21k X3VzZXIocWRldiwgMCwgUVhMX0lPX1VQREFURV9BUkVBX0FTWU5DLCB0cnVlKTsKPiA+ICsJcmV0 ID0gd2FpdF9mb3JfaW9fY21kX3VzZXIocWRldiwgMCwgUVhMX0lPX1VQREFURV9BUkVBX0FTWU5D LCBpbnRyKTsKPiA+ICAJbXV0ZXhfdW5sb2NrKCZxZGV2LT51cGRhdGVfYXJlYV9tdXRleCk7Cj4g PiAgCXJldHVybiByZXQ7Cj4gPiAgfQo+ID4gQEAgLTU4OCwxMCArNTg1LDcgQEAgaW50IHF4bF91 cGRhdGVfc3VyZmFjZShzdHJ1Y3QgcXhsX2RldmljZSAqcWRldiwgc3RydWN0Cj4gPiBxeGxfYm8g KnN1cmYpCj4gPiAgCXJlY3QucmlnaHQgPSBzdXJmLT5zdXJmLndpZHRoOwo+ID4gIAlyZWN0LnRv cCA9IDA7Cj4gPiAgCXJlY3QuYm90dG9tID0gc3VyZi0+c3VyZi5oZWlnaHQ7Cj4gPiAtcmV0cnk6 Cj4gPiAtCXJldCA9IHF4bF9pb191cGRhdGVfYXJlYShxZGV2LCBzdXJmLCAmcmVjdCk7Cj4gPiAt CWlmIChyZXQgPT0gLUVSRVNUQVJUU1lTKQo+ID4gLQkJZ290byByZXRyeTsKPiA+ICsJcmV0ID0g cXhsX2lvX3VwZGF0ZV9hcmVhKHFkZXYsIHN1cmYsICZyZWN0LCBmYWxzZSk7Cj4gCj4gTXkgdW5k ZXJzdGFuZGluZyBpcyB0aGF0IHRoZSBmaXggaXMgdGhpcyBodW5rPyBJZiBzbywgdGhpcyBjb3Vs ZCBiZSBtYWRlCj4gbW9yZSBvYnZpb3VzIHdpdGggYW4gaW50ZXJtZWRpYXRlIGNvbW1pdCBhZGRp bmcgdGhlICdib29sIGludHInIGFyZyB0bwo+IHF4bF9pb191cGRhdGVfYXJlYSBhbmQgb25seSBj YWxsaW5nIGl0IHdpdGggJ3RydWUnIGluIHRoZSBhcHByb3ByaWF0ZQo+IHBsYWNlcy4KPiBUaGlz IGNvZGUgcGF0aCBpcyBvbmx5IHRyaWdnZXJlZCBmcm9tIHF4bF9zdXJmYWNlX2V2aWN0KCkgd2hp Y2ggSSBhc3N1bWUKPiBpcyBub3QgbmVjZXNzYXJpbHkgZWFzaWx5IGludGVycnVwdGlibGUsIHNv IHRoaXMgY2hhbmdlIG1ha2VzIHNlbnNlIHRvCj4gbWUuIEhvd2V2ZXIgaXQgd291bGQgYmUgbXVj aCBiZXR0ZXIgdG8gZ2V0IGEgcmV2aWV3IGZyb20gRGF2ZSBBaXJsaWUgOykKPiAKPiBDaHJpc3Rv cGhlCj4gCgpBcmUgeW91IGFza2luZyBpZiBqdXN0IHJlbW92aW5nIHRoZSBsb29wIHdvdWxkIGZp eCB0aGUgaXNzdWU/ClNvIHlvdSBhcmUgcHJvcG9zaW5nIGEgZmlyc3QgcGF0Y2ggdGhhdCBhZGQg dGhlIGFyZ3VtZW50IGFsd2F5cyBwYXNzaW5nIHRydWUgYW5kIGFub3RoZXIgdGhhdCBjaGFuZ2Ug c29tZSBjYWxscyB0byBmYWxzZT8gSXQgbWFrZSBzZW5zZSBidXQgc3RpbGwgdGhlIGxvb3Agc2hv dWxkIGJlIHJlbW92ZWQuCgpGcmVkaWFubwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpTcGljZS1kZXZlbCBtYWlsaW5nIGxpc3QKU3BpY2UtZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9zcGljZS1kZXZlbAo=