From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: treding@nvidia.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: bridge/dw-hdmi: Remove pre_enable/post_disable dummy funcs
Date: Wed, 30 Mar 2016 19:06:01 +0300 [thread overview]
Message-ID: <1731460.LyGa4dFdtf@avalon> (raw)
In-Reply-To: <1459329804-10488-1-git-send-email-architt@codeaurora.org>
Hi Archit,
Thank you for the patch.
On Wednesday 30 Mar 2016 14:53:24 Archit Taneja wrote:
> We don't need to keep empty callbacks for the (pre/post) enable/disable
> drm_bridge ops anymore. Remove the nop callback used here for
> pre_enable and post_disable ops.
>
> Signed-off-by: Archit Taneja <architt@codeaurora.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/dw-hdmi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c
> b/drivers/gpu/drm/bridge/dw-hdmi.c index 9795b724..c9d9412 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -1413,11 +1413,6 @@ static void dw_hdmi_bridge_enable(struct drm_bridge
> *bridge) mutex_unlock(&hdmi->mutex);
> }
>
> -static void dw_hdmi_bridge_nop(struct drm_bridge *bridge)
> -{
> - /* do nothing */
> -}
> -
> static enum drm_connector_status
> dw_hdmi_connector_detect(struct drm_connector *connector, bool force)
> {
> @@ -1536,8 +1531,6 @@ static const struct drm_connector_helper_funcs
> dw_hdmi_connector_helper_funcs = static const struct drm_bridge_funcs
> dw_hdmi_bridge_funcs = {
> .enable = dw_hdmi_bridge_enable,
> .disable = dw_hdmi_bridge_disable,
> - .pre_enable = dw_hdmi_bridge_nop,
> - .post_disable = dw_hdmi_bridge_nop,
> .mode_set = dw_hdmi_bridge_mode_set,
> };
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-03-30 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 9:23 [PATCH] drm: bridge/dw-hdmi: Remove pre_enable/post_disable dummy funcs Archit Taneja
2016-03-30 9:55 ` Daniel Vetter
2016-03-30 16:06 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1731460.LyGa4dFdtf@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox