From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH 12/17] drm/sun4i: Add CCSC property to DE2 configuration Date: Tue, 28 Nov 2017 20:02:26 +0800 Message-ID: <1763fe2cf572135ef030a26a32b907d7@aosc.io> References: <20171127205750.19277-1-jernej.skrabec@siol.net> <20171127205750.19277-13-jernej.skrabec@siol.net> Reply-To: icenowy-h8G6r0blFSE@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20171127205750.19277-13-jernej.skrabec-gGgVlfcn5nU@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jernej Skrabec Cc: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: dri-devel@lists.freedesktop.org =E5=9C=A8 2017-11-28 04:57=EF=BC=8CJernej Skrabec =E5=86=99=E9=81=93=EF=BC= =9A > Base addresses of channel output CSC (CCSC) depends whether mixer in > question is first or second and if it is second, if supports VEP or=20 > not. > This new property will tell which set of base addresses to take. >=20 > 0 - first mixer or second mixer with VEP support > 1 - second mixer without VEP support Maxime, I think here the ID of the mixer matters. P.S. I didn't found any SoC with a second mixer with VEP currently Thanks! >=20 > Signed-off-by: Jernej Skrabec > --- > drivers/gpu/drm/sun4i/sun8i_mixer.c | 1 + > drivers/gpu/drm/sun4i/sun8i_mixer.h | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c > b/drivers/gpu/drm/sun4i/sun8i_mixer.c > index 7c9c87a0535b..2276eff8798d 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c > @@ -622,6 +622,7 @@ static const struct sun8i_mixer_cfg=20 > sun8i_v3s_mixer_cfg =3D { > .vi_num =3D 2, > .ui_num =3D 1, > .scaler_mask =3D 0x3, > + .ccsc =3D 0, Jernej, the lowlevel_sun8iw8/de_feat.c in the BSP DE2 source code claims that V3/V3s have no VEP support even for mixer0. > }; >=20 > static const struct of_device_id sun8i_mixer_of_table[] =3D { > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h > b/drivers/gpu/drm/sun4i/sun8i_mixer.h > index 355a45e6cfb4..4fcf1653e345 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h > @@ -136,6 +136,7 @@ struct sun8i_mixer_cfg { > int vi_num; > int ui_num; > int scaler_mask; > + int ccsc; > }; >=20 > struct sun8i_mixer { --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.