Re: [v7 0/9] Add HDR Metadata Parsing and handling in DRM layer

["Sharma, Shashank" <shashank.sharma@intel.com>]

Hello Uma,

V7 looks good to me, please feel free to use for the whole series:

Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>

Regards

Shashank

On 4/3/2019 1:50 AM, Uma Shankar wrote:
> This patch series enables HDR support in drm. It basically defines
> HDR metadata structures, property to pass content (after blending)
> metadata from user space compositors to driver.
>
> Dynamic Range and Mastering infoframe creation and sending.
>
> ToDo:
> 1. We need to get the color framework in place for all planes
>     which support HDR content in hardware. This is already in progres
>     and patches are out for review in mailing list.
> 2. UserSpace/Compositors: Blending policies and metadata blob
>     creation and passing to driver. Work is already in progress
>     by Intel's middleware teams on wayland and the patches for
>     the same are in review.
>
> Please review and share your feedbacks/suggestions.
>
> Note: The intention for these patches is to get a design feedback on
> the uapi changes, generic property design and infoframe handling.
> This cannot get merged as of now without the userspace support in place.
>
> A POC has already been developed by Ville based on wayland. Please refer
> below link to see the component interactions and usage:
> https://lists.freedesktop.org/archives/wayland-devel/2017-December/036403.html
>
> v2: Updated Ville's POC changes to the patch series.Incorporated cleanups
> and fixes from Ville. Rebase on latest drm-tip.
>
> v3: Fixed a warning causing builds to break on CI. No major change.
>
> v4: Addressed Shashank's review comments.
>
> v5: Rebase on top of Ville's infoframe refactoring changes. Fixed non modeset
> case for HDR metadata update. Dropped a redundant patch.
>
> v6: Addressed Shashank's review comments and added RB's received.
>
> v7: Squashed 2 patches, dropped 1 change and addressed Brian Starkey's and
> Shashank's review comments.
>
> Note: Media driver and VAAPI changes for HDR are already out, with compositors
> changes also expected to land soon. Weston changes already floated and reviews
> started in community and is in active development along with GL efforts.
>
> Uma Shankar (7):
>    drm: Add HDR source metadata property
>    drm: Parse HDR metadata info from EDID
>    drm: Enable HDR infoframe support
>    drm/i915: Attach HDR metadata property to connector
>    drm/i915: Write HDR infoframe and send to panel
>    drm/i915:Enabled Modeset when HDR Infoframe changes
>    drm/i915: Set Infoframe for non modeset case for HDR
>
> Ville Syrjälä (2):
>    drm/i915: Add HLG EOTF
>    drm/i915: Enable infoframes on GLK+ for HDR
>
>   drivers/gpu/drm/drm_atomic.c        |   2 +
>   drivers/gpu/drm/drm_atomic_uapi.c   |  13 +++
>   drivers/gpu/drm/drm_connector.c     |   6 ++
>   drivers/gpu/drm/drm_edid.c          | 102 ++++++++++++++++++++
>   drivers/gpu/drm/i915/i915_reg.h     |   4 +
>   drivers/gpu/drm/i915/intel_atomic.c |  14 ++-
>   drivers/gpu/drm/i915/intel_ddi.c    |  13 +++
>   drivers/gpu/drm/i915/intel_drv.h    |   1 +
>   drivers/gpu/drm/i915/intel_hdmi.c   |  79 ++++++++++++++-
>   drivers/video/hdmi.c                | 186 ++++++++++++++++++++++++++++++++++++
>   include/drm/drm_connector.h         |  10 ++
>   include/drm/drm_edid.h              |   5 +
>   include/drm/drm_mode_config.h       |   6 ++
>   include/linux/hdmi.h                |  38 ++++++++
>   include/uapi/drm/drm_mode.h         |  22 +++++
>   15 files changed, 496 insertions(+), 5 deletions(-)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel