From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBCC0C55174 for ; Sun, 2 Aug 2026 19:33:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DC9D810E117; Sun, 2 Aug 2026 19:33:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="HH4I9Pcm"; dkim-atps=neutral X-Greylist: delayed 337 seconds by postgrey-1.36 at gabe; Sun, 02 Aug 2026 19:33:48 UTC Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3F8F10E117 for ; Sun, 2 Aug 2026 19:33:48 +0000 (UTC) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785698887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ih17u19AEzHyVVPvha5pFDpYhRKd9u+uawUawKr9oxY=; b=HH4I9Pcm/SBcXwV76O4Zr3TEewgiBxIxBBXpqQM8Bxx6pbnHqmdspVGXVoRm/tgt+ZRxhP Wkq2QgEeZnDBB73o9s4NOq1KfotlJUZUu9J7K8JDW1REDwfinGozamxxiHbS4lLkZI2pCQ 7/57U/olWMrrVRTQ9kGqYX0jVopHcEs= From: Igor Korotin To: Danilo Krummrich , Gary Guo Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Miguel Ojeda , Boqun Feng , =?utf-8?q?Bj=C3=B6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?utf-8?q?=C3=96zkan?= , FUJITA Tomonori , David Airlie , Simona Vetter , Bjorn Helgaas , Krzysztof =?utf-8?q?Wilczy=C5=84ski?= , Abdiel Janulgue , Robin Murphy , Dave Ertman , Ira Weiny , Leon Romanovsky , Len Brown , Rob Herring , Saravana Kannan , Viresh Kumar , Michal Wilczynski , Drew Fustini , Guo Ren , Fu Wei , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: (subset) [PATCH v2 00/11] rust: driver: use pointers instead of indices for ID info Date: Sun, 02 Aug 2026 20:27:50 +0100 Message-ID: <178569887068.1652.14450480404285948832@linux.dev> In-Reply-To: <20260730210149.1117242-2-dakr@kernel.org> References: <20260629-id_info-v2-0-56fccbe9c5ef@garyguo.net> <20260730210149.1117242-2-dakr@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Danilo, Sorry for the silence -- I was offline for personal reasons for about two weeks from the 16th, and missed this before it got applied. Checked 6-9/11 now: the i2c bits are correct. Unlike PCI/USB, i2c has no dynamic-ID (new_id) mechanism, so i2c_match_id() can only ever return a pointer that IdArray::new() actually populated -- the plain info_unchecked() (not _opt) in i2c_id_info() is the right call, not an oversight. Cheers Igor