From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: daniel.vetter@ffwll.ch, tomi.valkeinen@ti.com,
hoegsberg@gmail.com, abrodkin@synopsys.com,
dri-devel@lists.freedesktop.org, liviu.dudau@arm.com,
jsarha@ti.com
Subject: Re: [PATCH v4 05/11] drm/atomic: Use drm_framebuffer_print_info()
Date: Thu, 02 Nov 2017 06:44:14 +0200 [thread overview]
Message-ID: <1785726.EHvfikzvta@avalon> (raw)
In-Reply-To: <20171030162945.58063-6-noralf@tronnes.org>
Hi Noralf,
Thank you for the patch.
On Monday, 30 October 2017 18:29:39 EET Noralf Trønnes wrote:
> Use drm_framebuffer_print_info() to print framebuffer info in
> drm_atomic_plane_print_state(). This will give optional GEM info as well.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/drm_atomic.c | 18 +++---------------
> 1 file changed, 3 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 6c9c4a8e09af..6d626355ba4e 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -33,6 +33,7 @@
> #include <linux/sync_file.h>
>
> #include "drm_crtc_internal.h"
> +#include "drm_internal.h"
>
> void __drm_crtc_commit_free(struct kref *kref)
> {
> @@ -934,21 +935,8 @@ static void drm_atomic_plane_print_state(struct
> drm_printer *p, drm_printf(p, "plane[%u]: %s\n", plane->base.id,
> plane->name);
> drm_printf(p, "\tcrtc=%s\n", state->crtc ? state->crtc->name : "(null)");
> drm_printf(p, "\tfb=%u\n", state->fb ? state->fb->base.id : 0);
> - if (state->fb) {
> - struct drm_framebuffer *fb = state->fb;
> - int i, n = fb->format->num_planes;
> - struct drm_format_name_buf format_name;
> -
> - drm_printf(p, "\t\tformat=%s\n",
> - drm_get_format_name(fb->format->format, &format_name));
> - drm_printf(p, "\t\t\tmodifier=0x%llx\n", fb->modifier);
> - drm_printf(p, "\t\tsize=%dx%d\n", fb->width, fb->height);
> - drm_printf(p, "\t\tlayers:\n");
> - for (i = 0; i < n; i++) {
> - drm_printf(p, "\t\t\tpitch[%d]=%u\n", i, fb->pitches[i]);
> - drm_printf(p, "\t\t\toffset[%d]=%u\n", i, fb->offsets[i]);
> - }
> - }
> + if (state->fb)
> + drm_framebuffer_print_info(p, 2, state->fb);
> drm_printf(p, "\tcrtc-pos=" DRM_RECT_FMT "\n", DRM_RECT_ARG(&dest));
> drm_printf(p, "\tsrc-pos=" DRM_RECT_FP_FMT "\n", DRM_RECT_FP_ARG(&src));
> drm_printf(p, "\trotation=%x\n", state->rotation);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-02 4:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 16:29 [PATCH v4 00/11] drm/framebuffer: Add framebuffer debugfs file Noralf Trønnes
2017-10-30 16:29 ` [PATCH v4 01/11] drm/vma-manager: drm_vma_node_start() constify argument Noralf Trønnes
2017-11-02 4:29 ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 02/11] drm/framebuffer: drm_framebuffer_read_refcount() " Noralf Trønnes
2017-11-02 4:30 ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 03/11] drm/print: Add drm_printf_indent() Noralf Trønnes
2017-11-02 4:32 ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 04/11] drm/framebuffer: Add framebuffer debugfs file Noralf Trønnes
2017-11-02 4:43 ` Laurent Pinchart
2017-11-02 14:12 ` Noralf Trønnes
2017-10-30 16:29 ` [PATCH v4 05/11] drm/atomic: Use drm_framebuffer_print_info() Noralf Trønnes
2017-11-02 4:44 ` Laurent Pinchart [this message]
2017-10-30 16:29 ` [PATCH v4 06/11] drm/cma-helper: Add drm_gem_cma_print_info() Noralf Trønnes
2017-11-04 7:54 ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 07/11] drm/arc: Use drm_gem_cma_print_info() Noralf Trønnes
2017-10-31 16:17 ` Alexey Brodkin
2017-10-31 18:15 ` Ville Syrjälä
2017-11-04 7:55 ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 08/11] drm/arm/hdlcd: " Noralf Trønnes
2017-10-31 9:49 ` Liviu Dudau
2017-11-04 7:55 ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 09/11] drm/tilcdc: " Noralf Trønnes
2017-10-31 15:09 ` Jyri Sarha
2017-11-04 7:56 ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 10/11] drm/tinydrm: " Noralf Trønnes
2017-11-04 7:56 ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 11/11] drm/cma-helper: Remove drm_fb_cma_debugfs_show() Noralf Trønnes
2017-10-31 10:35 ` Daniel Vetter
2017-11-04 7:58 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1785726.EHvfikzvta@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=abrodkin@synopsys.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegsberg@gmail.com \
--cc=jsarha@ti.com \
--cc=liviu.dudau@arm.com \
--cc=noralf@tronnes.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox