dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm/omap: Fail probe if irq registration fails
Date: Fri, 05 Jan 2018 16:34:02 +0200	[thread overview]
Message-ID: <1851227.3D7IugeCxC@avalon> (raw)
In-Reply-To: <50a32bad6a2bf029100e00d06fa8d26805235213.1514807171.git.jsarha@ti.com>

Hi Jyri,

Thank you for the patch.

On Monday, 1 January 2018 13:55:10 EET Jyri Sarha wrote:
> Call to omap_drm_irq_install() may fail with an error code. In such a
> case the driver probe should fail.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> ---
>  drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
> b/drivers/gpu/drm/omapdrm/omap_drv.c index dd68b25..5fe2fcb 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -321,9 +321,9 @@ static int omap_modeset_init(struct drm_device *dev)
> 
>  	drm_mode_config_reset(dev);
> 
> -	omap_drm_irq_install(dev);
> +	ret = omap_drm_irq_install(dev);
> 
> -	return 0;
> +	return ret;

Nitpicking, how about just

	return omap_drm_irq_install(dev);

? With this changed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  }
> 
>  /*

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-01-05 14:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01 11:55 [PATCH v2 0/3] drm/omap: Make omapdss API more generic + related patches Jyri Sarha
2018-01-01 11:55 ` [PATCH v2 1/3] drm/omap: Fail probe if irq registration fails Jyri Sarha
2018-01-05 14:34   ` Laurent Pinchart [this message]
2018-01-01 11:55 ` [PATCH v2 2/3] drm/omap: Add get_ovl_name() and get_mgr_name() to dispc_ops Jyri Sarha
     [not found] ` <be6c356220bbd92eef49d03e9a8359eae5a8df4a.1514807171.git.jsarha@ti.com>
2018-01-04 11:17   ` [PATCH v2 3/3] drm/omap: Make omapdss API more generic Tomi Valkeinen
2018-01-07 20:14     ` Jyri Sarha
2018-01-08  8:30       ` Tomi Valkeinen
2018-01-04 11:21 ` [PATCH v2 0/3] drm/omap: Make omapdss API more generic + related patches Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1851227.3D7IugeCxC@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox