From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kazlauskas, Nicholas" Subject: Re: [PATCH 5/7] drm/amd/display: Use proper enum conversion functions Date: Thu, 25 Jul 2019 16:14:25 +0000 Message-ID: <18b343ab-8834-ea86-1bca-974f23b60b16@amd.com> References: <20190704055217.45860-1-natechancellor@gmail.com> <20190704055217.45860-6-natechancellor@gmail.com> <20190719031647.GA84028@archlinux-threadripper> <5f0e8332-50ae-cc9c-1a12-5a097c51297d@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5f0e8332-50ae-cc9c-1a12-5a097c51297d-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Li, Sun peng (Leo)" , "Deucher, Alexander" , "Koenig, Christian" , "Zhou, David(ChunMing)" , "Wentland, Harry" , Rex Zhu , "Quan, Evan" Cc: David Airlie , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "clang-built-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Nathan Chancellor List-Id: dri-devel@lists.freedesktop.org T24gNy8yNS8xOSAxMjowMCBQTSwgTGksIFN1biBwZW5nIChMZW8pIHdyb3RlOg0KPiANCj4gDQo+ IE9uIDIwMTktMDctMTggMTE6MTYgcC5tLiwgTmF0aGFuIENoYW5jZWxsb3Igd3JvdGU6DQo+PiBP biBXZWQsIEp1bCAwMywgMjAxOSBhdCAxMDo1MjoxNlBNIC0wNzAwLCBOYXRoYW4gQ2hhbmNlbGxv ciB3cm90ZToNCj4+PiBjbGFuZyB3YXJuczoNCj4+Pg0KPj4+IGRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1Ly4uL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbV9wcF9zbXUuYzozMzY6ODoNCj4+ PiB3YXJuaW5nOiBpbXBsaWNpdCBjb252ZXJzaW9uIGZyb20gZW51bWVyYXRpb24gdHlwZSAnZW51 bSBzbXVfY2xrX3R5cGUnDQo+Pj4gdG8gZGlmZmVyZW50IGVudW1lcmF0aW9uIHR5cGUgJ2VudW0g YW1kX3BwX2Nsb2NrX3R5cGUnDQo+Pj4gWy1XZW51bS1jb252ZXJzaW9uXQ0KPj4+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGNfdG9fc211X2Nsb2NrX3R5cGUoY2xr X3R5cGUpLA0KPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fg0KPj4+IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1Ly4uL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbV9wcF9zbXUuYzo0MjE6MTQ6DQo+Pj4g d2FybmluZzogaW1wbGljaXQgY29udmVyc2lvbiBmcm9tIGVudW1lcmF0aW9uIHR5cGUgJ2VudW0N Cj4+PiBhbWRfcHBfY2xvY2tfdHlwZScgdG8gZGlmZmVyZW50IGVudW1lcmF0aW9uIHR5cGUgJ2Vu dW0gc211X2Nsa190eXBlJw0KPj4+IFstV2VudW0tY29udmVyc2lvbl0NCj4+PiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRjX3RvX3BwX2Nsb2NrX3R5cGUoY2xrX3R5 cGUpLA0KPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+DQo+Pj4NCj4+PiBUaGVyZSBhcmUgZnVuY3Rpb25zIHRv IHByb3Blcmx5IGNvbnZlcnQgYmV0d2VlbiBhbGwgb2YgdGhlc2UgdHlwZXMsIHVzZQ0KPj4+IHRo ZW0gc28gdGhlcmUgYXJlIG5vIGxvbmdlciBhbnkgd2FybmluZ3MuDQo+Pj4NCj4+PiBGaXhlczog YTQzOTEzZWE1MGE1ICgiZHJtL2FtZC9wb3dlcnBsYXk6IGFkZCBmdW5jdGlvbiBnZXRfY2xvY2tf YnlfdHlwZV93aXRoX2xhdGVuY3kgZm9yIG5hdmkxMCIpDQo+Pj4gRml4ZXM6IGU1ZTRlMjIzOTFj MiAoImRybS9hbWQvcG93ZXJwbGF5OiBhZGQgaW50ZXJmYWNlIHRvIGdldCBjbG9jayBieSB0eXBl IHdpdGggbGF0ZW5jeSBmb3IgZGlzcGxheSAodjIpIikNCj4+PiBMaW5rOiBodHRwczovL2dpdGh1 Yi5jb20vQ2xhbmdCdWlsdExpbnV4L2xpbnV4L2lzc3Vlcy81ODYNCj4+PiBTaWduZWQtb2ZmLWJ5 OiBOYXRoYW4gQ2hhbmNlbGxvciA8bmF0ZWNoYW5jZWxsb3JAZ21haWwuY29tPg0KPj4+IC0tLQ0K Pj4+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG1fcHBf c211LmMgfCA0ICsrLS0NCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pDQo+Pj4NCj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9k aXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG1fcHBfc211LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1k L2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbV9wcF9zbXUuYw0KPj4+IGluZGV4IGVhYzA5YmZl M2JlMi4uMGY3NmNmZmY5ZDliIDEwMDY0NA0KPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv ZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtX3BwX3NtdS5jDQo+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG1fcHBfc211LmMNCj4+PiBAQCAt MzMzLDcgKzMzMyw3IEBAIGJvb2wgZG1fcHBfZ2V0X2Nsb2NrX2xldmVsc19ieV90eXBlKA0KPj4+ ICAgCQl9DQo+Pj4gICAJfSBlbHNlIGlmIChhZGV2LT5zbXUuZnVuY3MgJiYgYWRldi0+c211LmZ1 bmNzLT5nZXRfY2xvY2tfYnlfdHlwZSkgew0KPj4+ICAgCQlpZiAoc211X2dldF9jbG9ja19ieV90 eXBlKCZhZGV2LT5zbXUsDQo+Pj4gLQkJCQkJICBkY190b19zbXVfY2xvY2tfdHlwZShjbGtfdHlw ZSksDQo+Pj4gKwkJCQkJICBkY190b19wcF9jbG9ja190eXBlKGNsa190eXBlKSwNCj4gDQo+IHNt dV9mdW5jcy0+Z2V0X2Nsb2NrX2J5X3R5cGUgZG9lc24ndCBzZWVtIHRvIGJlIGhvb2tlZCB1cCBh bnl3aGVyZSwNCj4gc28gdGhpcyBsb29rcyB0byBiZSB0aGUgbW9zdCBjb3JyZWN0Lg0KPiANCj4g QWx0aG91Z2ggaXQgbWFrZXMgbW9yZSBzZW5zZSB0byB1c2Ugc211X2Nsa190eXBlcyBoZXJlIHJh dGhlciB0aGFuDQo+IGFtZF9wcF9jbG9ja190eXBlIC0gYW55IHJlYXNvbiB3aHkgdGhpcyBpc24n dCB0aGUgY2FzZT8NCj4gDQo+Pj4gICAJCQkJCSAgJnBwX2Nsa3MpKSB7DQo+Pj4gICAJCQlnZXRf ZGVmYXVsdF9jbG9ja19sZXZlbHMoY2xrX3R5cGUsIGRjX2Nsa3MpOw0KPj4+ICAgCQkJcmV0dXJu IHRydWU7DQo+Pj4gQEAgLTQxOCw3ICs0MTgsNyBAQCBib29sIGRtX3BwX2dldF9jbG9ja19sZXZl bHNfYnlfdHlwZV93aXRoX2xhdGVuY3koDQo+Pj4gICAJCQlyZXR1cm4gZmFsc2U7DQo+Pj4gICAJ fSBlbHNlIGlmIChhZGV2LT5zbXUucHB0X2Z1bmNzICYmIGFkZXYtPnNtdS5wcHRfZnVuY3MtPmdl dF9jbG9ja19ieV90eXBlX3dpdGhfbGF0ZW5jeSkgew0KPj4+ICAgCQlpZiAoc211X2dldF9jbG9j a19ieV90eXBlX3dpdGhfbGF0ZW5jeSgmYWRldi0+c211LA0KPj4+IC0JCQkJCQkgICAgICAgZGNf dG9fcHBfY2xvY2tfdHlwZShjbGtfdHlwZSksDQo+Pj4gKwkJCQkJCSAgICAgICBkY190b19zbXVf Y2xvY2tfdHlwZShjbGtfdHlwZSksDQo+IA0KPiBUaGlzIGlzIHNsaWdodGx5IGNvbmNlcm5pbmcu IFRoZSBmdW5jdGlvbnMgYXJlIGRvaW5nIHRoZSByaWdodCB0aGluZywNCj4gYnV0IGFtZF9wcF9j bG9ja190eXBlIGRvZXNuJ3QgbWFwIDEtMSB0byBzbXVfY2xrX3R5cGUuLi4gSW4gYW55IGNhc2Us DQo+IHRoaXMgbG9va3MgZ29vZCB0byBtZS4NCj4gDQo+IFJldmlld2VkLWJ5OiBMZW8gTGkgPHN1 bnBlbmcubGlAYW1kLmNvbT4NCg0KTG9va3MgbW9zdGx5IGxpa2UgdGhlIHRhYmxlIGp1c3QgbmVl ZHMgdG8gYmUgc2l6ZWQgcHJvcGVybHk6DQoNCglzdGF0aWMgaW50IGRjX2Nsa190eXBlX21hcFtd ID0gew0KLT4NCglzdGF0aWMgaW50IGRjX2Nsa190eXBlX21hcFtETV9QUF9DTE9DS19UWVBFX05V TV9UWVBFU10gPSB7DQoNCndoZXJlIERNX1BQX0NMT0NLX1RZUEVfTlVNX1RZUEVTIHdvdWxkIGJl IGFkZGVkIHRvIGVudW0gZG1fcHBfY2xvY2tfdHlwZS4NCg0KT3IgaXQgY291bGQganVzdCB1c2Ug YSBzd2l0Y2ggdGFibGUgaW5zdGVhZCwgbGlrZSB0aGUgb3RoZXIgZnVuY3Rpb24gZG9lcy4NCg0K TmljaG9sYXMgS2F6bGF1c2thcw0KDQoNCj4gDQo+Pj4gICAJCQkJCQkgICAgICAgJnBwX2Nsa3Mp KQ0KPj4+ICAgCQkJcmV0dXJuIGZhbHNlOw0KPj4+ICAgCX0NCj4+PiAtLSANCj4+PiAyLjIyLjAN Cj4+Pg0KPj4NCj4+IEdlbnRsZSBwaW5nIGZvciByZXZpZXcsIHRoaXMgaXMgdGhlIGxhc3QgcmVt YWluaW5nIHdhcm5pbmcgdGhhdCBJIHNlZQ0KPj4gZnJvbSBhbWRncHUgb24gbmV4dC0yMDE5MDcx OC4NCj4+DQo+PiBDaGVlcnMsDQo+PiBOYXRoYW4NCj4+DQo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QNCj4g ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KPiBodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA0KPiANCg0KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4