From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC][PATCH 1/3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally Date: Tue, 22 Nov 2016 10:27:42 +0200 Message-ID: <1926540.Y3AOuWnbYN@avalon> References: <1479775052-28194-1-git-send-email-john.stultz@linaro.org> <1961666.AZMl081OYz@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AA316E1EA for ; Tue, 22 Nov 2016 08:27:26 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: lkml , "dri-devel@lists.freedesktop.org" , Wolfram Sang List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKCk9uIFR1ZXNkYXkgMjIgTm92IDIwMTYgMDA6MTY6NTUgSm9obiBTdHVsdHogd3Jv dGU6Cj4gT24gVHVlLCBOb3YgMjIsIDIwMTYgYXQgMTI6MTQgQU0sIExhdXJlbnQgUGluY2hhcnQg d3JvdGU6Cj4gPiBPbiBNb25kYXkgMjEgTm92IDIwMTYgMTY6Mzc6MzAgSm9obiBTdHVsdHogd3Jv dGU6Cj4gPj4gSW4gY2hhc2luZyBkb3duIGlzc3VlcyB3aXRoIEVESUQgcHJvYmluZywgSSBmb3Vu ZCBzb21lCj4gPj4gZHVwbGljYXRlZCBidXQgaW5jb21wbGV0ZSBsb2dpYyB1c2VkIHRvIHBvd2Vy IHRoZSBjaGlwIG9uIGFuZAo+ID4+IG9mZi4KPiA+PiAKPiA+PiBUaGlzIHBhdGNoIHJlZmFjdG9y cyB0aGUgYWR2NzUxMV9wb3dlcl9vbi9vZmYgZnVuY3Rpb25zLCBzbwo+ID4+IHRoZXkgY2FuIGJl IHVzZWQgZm9yIGludGVybmFsIG5lZWRzLCBhbmQgcmVwbGFjZXMgZHVwbGljYXRpdmUKPiA+PiBs b2dpYyB0aGF0IHBvd2VycyB0aGUgY2hpcCBvbiBhbmQgb2ZmIGFyb3VuZCB0aGUgRURJRCBwcm9i aW5nCj4gPj4gd2l0aCB0aGUgY29tbW9uIGxvZ2ljLgo+ID4+IAo+ID4+IENjOiBEYXZpZCBBaXJs aWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPj4gQ2M6IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29k ZWF1cm9yYS5vcmc+Cj4gPj4gQ2M6IFdvbGZyYW0gU2FuZyA8d3NhK3JlbmVzYXNAc2FuZy1lbmdp bmVlcmluZy5jb20+Cj4gPj4gQ2M6IExhcnMtUGV0ZXIgQ2xhdXNlbiA8bGFyc0BtZXRhZm9vLmRl Pgo+ID4+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2Fy ZC5jb20+Cj4gPj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+PiBTaWdu ZWQtb2ZmLWJ5OiBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4KPiA+PiAtLS0K PiA+PiAKPiA+PiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMg fCAzMCArKysrKysrKystLS0tLS0tLS0tLS0tCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNl cnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKPiA+PiAKPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMKPiA+PiBiL2RyaXZlcnMvZ3B1 L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jIGluZGV4IDhkYmE3MjkuLmIyNDBlMDUK PiA+PiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2 NzUxMV9kcnYuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3 NTExX2Rydi5jCj4gPj4gQEAgLTMyNSw3ICszMjUsNyBAQCBzdGF0aWMgdm9pZCBhZHY3NTExX3Nl dF9saW5rX2NvbmZpZyhzdHJ1Y3QgYWR2NzUxMQo+ID4+ICphZHY3NTExLCBhZHY3NTExLT5yZ2Ig PSBjb25maWctPmlucHV0X2NvbG9yc3BhY2UgPT0gSERNSV9DT0xPUlNQQUNFX1JHQjsKPiA+PiAK PiA+PiAgfQo+ID4+IAo+ID4+IC1zdGF0aWMgdm9pZCBhZHY3NTExX3Bvd2VyX29uKHN0cnVjdCBh ZHY3NTExICphZHY3NTExKQo+ID4+ICtzdGF0aWMgdm9pZCBfX2Fkdjc1MTFfcG93ZXJfb24oc3Ry dWN0IGFkdjc1MTEgKmFkdjc1MTEpCj4gPj4gIHsKPiA+PiAgICAgICBhZHY3NTExLT5jdXJyZW50 X2VkaWRfc2VnbWVudCA9IC0xOwo+ID4+IAo+ID4+IEBAIC0zNDMsNiArMzQzLDcgQEAgc3RhdGlj IHZvaWQgYWR2NzUxMV9wb3dlcl9vbihzdHJ1Y3QgYWR2NzUxMSAqYWR2NzUxMSkKPiA+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICBBRFY3NTExX0lOVDFfRERDX0VSUk9SKTsKPiA+PiAgICAg ICB9Cj4gPj4gCj4gPj4gKwo+ID4gCj4gPiBUaGlzIGlzbid0IG5lZWRlZC4KPiAKPiBBcG9sb2dp ZXMuIEkgc2F3IHRoaXMgcmlnaHQgYWZ0ZXIgSSBzZW50IGl0IQo+IAo+ID4+ICAgICAgIC8qCj4g Pj4gICAgICAgICogUGVyIHNwZWMgaXQgaXMgYWxsb3dlZCB0byBwdWxzZSB0aGUgSFBEIHNpZ25h bCB0byBpbmRpY2F0ZSB0aGF0Cj4gPj4gICAgICAgIHRoZQo+ID4+ICAgICAgICAqIEVESUQgaW5m b3JtYXRpb24gaGFzIGNoYW5nZWQuIFNvbWUgbW9uaXRvcnMgZG8gdGhpcyB3aGVuIHRoZXkKPiA+ PiB3YWtldXAKPiA+PiBAQCAtMzYyLDExICszNjMsMTUgQEAgc3RhdGljIHZvaWQgYWR2NzUxMV9w b3dlcl9vbihzdHJ1Y3QgYWR2NzUxMQo+ID4+ICphZHY3NTExKQo+ID4+IAo+ID4+ICAgICAgIGlm IChhZHY3NTExLT50eXBlID09IEFEVjc1MzMpCj4gPj4gICAgICAgICAgICAgICBhZHY3NTMzX2Rz aV9wb3dlcl9vbihhZHY3NTExKTsKPiA+PiArfQo+ID4+IAo+ID4+ICtzdGF0aWMgdm9pZCBhZHY3 NTExX3Bvd2VyX29uKHN0cnVjdCBhZHY3NTExICphZHY3NTExKQo+ID4+ICt7Cj4gPj4gKyAgICAg X19hZHY3NTExX3Bvd2VyX29uKGFkdjc1MTEpOwo+ID4+ICAgICAgIGFkdjc1MTEtPnBvd2VyZWQg PSB0cnVlOwo+ID4+ICB9Cj4gPj4gCj4gPj4gLXN0YXRpYyB2b2lkIGFkdjc1MTFfcG93ZXJfb2Zm KHN0cnVjdCBhZHY3NTExICphZHY3NTExKQo+ID4+ICtzdGF0aWMgdm9pZCBfX2Fkdjc1MTFfcG93 ZXJfb2ZmKHN0cnVjdCBhZHY3NTExICphZHY3NTExKQo+ID4+ICB7Cj4gPj4gICAgICAgLyogVE9E Tzogc2V0dXAgYWRkaXRpb25hbCBwb3dlciBkb3duIG1vZGVzICovCj4gPj4gICAgICAgcmVnbWFw X3VwZGF0ZV9iaXRzKGFkdjc1MTEtPnJlZ21hcCwgQURWNzUxMV9SRUdfUE9XRVIsCj4gPj4gQEAg LTM3Niw3ICszODEsMTEgQEAgc3RhdGljIHZvaWQgYWR2NzUxMV9wb3dlcl9vZmYoc3RydWN0IGFk djc1MTEKPiA+PiAqYWR2NzUxMSkKPiA+PiAKPiA+PiAgICAgICBpZiAoYWR2NzUxMS0+dHlwZSA9 PSBBRFY3NTMzKQo+ID4+ICAgICAgICAgICAgICAgYWR2NzUzM19kc2lfcG93ZXJfb2ZmKGFkdjc1 MTEpOwo+ID4+ICt9Cj4gPj4gCj4gPj4gK3N0YXRpYyB2b2lkIGFkdjc1MTFfcG93ZXJfb2ZmKHN0 cnVjdCBhZHY3NTExICphZHY3NTExKQo+ID4+ICt7Cj4gPj4gKyAgICAgX19hZHY3NTExX3Bvd2Vy X29mZihhZHY3NTExKTsKPiA+PiAgICAgICBhZHY3NTExLT5wb3dlcmVkID0gZmFsc2U7Cj4gPj4g IH0KPiA+PiAKPiA+PiBAQCAtNTQ1LDI0ICs1NTQsMTMgQEAgc3RhdGljIGludCBhZHY3NTExX2dl dF9tb2RlcyhzdHJ1Y3QgYWR2NzUxMQo+ID4+ICphZHY3NTExLAo+ID4+ICAgICAgIHVuc2lnbmVk IGludCBjb3VudDsKPiA+PiAgICAgICAKPiA+PiAgICAgICAvKiBSZWFkaW5nIHRoZSBFRElEIG9u bHkgd29ya3MgaWYgdGhlIGRldmljZSBpcyBwb3dlcmVkICovCj4gPj4gLSAgICAgaWYgKCFhZHY3 NTExLT5wb3dlcmVkKSB7Cj4gPj4gLSAgICAgICAgICAgICByZWdtYXBfdXBkYXRlX2JpdHMoYWR2 NzUxMS0+cmVnbWFwLCBBRFY3NTExX1JFR19QT1dFUiwKPiA+PiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBBRFY3NTExX1BPV0VSX1BPV0VSX0RPV04sIDApOwo+ID4+IC0gICAgICAg ICAgICAgaWYgKGFkdjc1MTEtPmkyY19tYWluLT5pcnEpIHsKPiA+PiAtICAgICAgICAgICAgICAg ICAgICAgcmVnbWFwX3dyaXRlKGFkdjc1MTEtPnJlZ21hcCwKPiA+IAo+ID4gQURWNzUxMV9SRUdf SU5UX0VOQUJMRSgwKSwKPiA+IAo+ID4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgQURWNzUxMV9JTlQwX0VESURfUkVBRFkpOwo+ID4+IC0gICAgICAgICAgICAgICAgICAgICBy ZWdtYXBfd3JpdGUoYWR2NzUxMS0+cmVnbWFwLAo+ID4+IEFEVjc1MTFfUkVHX0lOVF9FTkFCTEUo MSksCj4gPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBBRFY3NTExX0lOVDFf RERDX0VSUk9SKTsKPiA+PiAtICAgICAgICAgICAgIH0KPiA+PiAtICAgICAgICAgICAgIGFkdjc1 MTEtPmN1cnJlbnRfZWRpZF9zZWdtZW50ID0gLTE7Cj4gPj4gLSAgICAgfQo+ID4+ICsgICAgIGlm ICghYWR2NzUxMS0+cG93ZXJlZCkKPiA+PiArICAgICAgICAgICAgIF9fYWR2NzUxMV9wb3dlcl9v bihhZHY3NTExKTsKPiA+IAo+ID4gVGhlIF9fYWR2NzUxMV9wb3dlcl9vbigpIGZ1bmN0aW9uIGRv ZXMgbW9yZSB0aGFuIHRoZSBhYm92ZSwgaW4gcGFydGljdWxhcgo+ID4gaXQgcGVyZm9ybXMgYW4g ZXhwZW5zaXZlIHJlZ2NhY2hlX3N5bmMoKSBhbmQgY2FsbHMgYWR2NzUzM19kc2lfcG93ZXJfb24o KQo+ID4gZm9yIHRoZSBBRFY3NTMzLiBEb24ndCB0aG9zZSBvcGVyYXRpb25zIGhhdmUgc2lkZSBl ZmZlY3RzIHRoYXQgYXJlIGVpdGhlcgo+ID4gbm90IHdhbnRlZCBvciBub3QgbmVlZGVkIGhlcmUg PyBJbiBhbnkgY2FzZSB0aGlzIHBhdGNoIG1vZGlmaWVzIHRoZQo+ID4gYmVoYXZpb3VyIG9mIHRo ZSBkcml2ZXIsIHdoaWNoIG5lZWRzIHRvIGJlIGRvY3VtZW50ZWQgaW4gdGhlIGtlcm5lbAo+ID4g bWVzc2FnZS4KPiAKPiBTb3JyeSwgd2hhdCBkbyB5b3UgbWVhbiBieSBrZXJuZWwgbWVzc2FnZT8g Q29tbWl0IG1lc3NhZ2UsIG1heWJlPwoKU29ycnksIHllcywgSSBtZWFudCBjb21taXQgbWVzc2Fn ZS4KCj4gRmFpciBwb2ludCwgSSdsbCByZXZpZXcgdGhlIGFkdjc1MzNfZHNpX3Bvd2VyX29uIGJp dHMgYW5kIHNlZSBpZiB0aGV5Cj4gc2hvdWxkIG1vdmUgb3V0IHRvIHRoZSBleHRlcm5hbCBmdW5j dGlvbiByYXRoZXIgdGhlbiB0aGUgaW50ZXJuYWwgb25lLgo+IFNpbWlsYXJseSBmb3IgdGhlIHJl Z2NhY2hlX3N5bmMuCj4gCj4gVGhhbmtzIHNvIG11Y2ggZm9yIHRoZSByZXZpZXchCgotLSAKUmVn YXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=