From: Stefan Agner <stefan@agner.ch>
To: dri-devel@lists.freedesktop.org
Cc: jianwei.wang.chn@gmail.com, daniel.vetter@ffwll.ch,
meng.yi@nxp.com, linux-kernel@vger.kernel.org,
alison.wang@freescale.com
Subject: Re: [PATCH 0/3] drm/fsl-dcu: fix driver remove/DRM unload
Date: Wed, 16 Nov 2016 16:59:23 -0800 [thread overview]
Message-ID: <19d9e2ee811aa1c02bf8a30069b4e27c@agner.ch> (raw)
In-Reply-To: <20161020003221.2941-1-stefan@agner.ch>
On 2016-10-19 17:32, Stefan Agner wrote:
> Hi All,
>
> The first patch is a better alternative to the previously posted
> patch ("drm/fsl-dcu: only init fbdev if required") as suggested
> by Daniel.
>
> The second and third are fix related issue uncovered during tests
> with bind/unbind:
> echo 40058000.dcu > /sys/bus/platform/drivers/fsl-dcu/unbind
> echo 40058000.dcu > /sys/bus/platform/drivers/fsl-dcu/bind
>
> Especially the third patch I am not sure if that is a reasonable
> strategy to fix the issue. I did not saw another SoC DRM driver
> which is making use of drm_crtc_force_disable_all...
>
> Also, when the X Server is running (with modesetting driver) I
> still get a warning:
>
> WARNING: CPU: 0 PID: 452 at drivers/gpu/drm/drm_crtc.c:1154
> drm_mode_config_cleanup+0x210/0x220
>
> The comment says it is the drivers fault, but as far as I can
> tell it is user space which does not free up this framebuffers.
> Is there something missing in my driver?
>
> Any ideas?
>
> --
> Stefan
>
> Stefan Agner (3):
> drm/fb_cma_helper: do not free fbdev if there is none
> drm/fsl-dcu: unload driver before disabling clocks
> drm/fsl-dcu: disable outputs before unloading driver
>
> drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Applied 2/3 to my for-next branch.
--
Stefan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-11-17 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 0:32 [PATCH 0/3] drm/fsl-dcu: fix driver remove/DRM unload Stefan Agner
2016-10-20 0:32 ` [PATCH 1/3] drm/fb_cma_helper: do not free fbdev if there is none Stefan Agner
2016-10-20 6:42 ` Daniel Vetter
2016-10-20 0:32 ` [PATCH 2/3] drm/fsl-dcu: unload driver before disabling clocks Stefan Agner
2016-10-20 0:32 ` [PATCH 3/3] drm/fsl-dcu: disable outputs before unloading driver Stefan Agner
2016-11-17 0:59 ` Stefan Agner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d9e2ee811aa1c02bf8a30069b4e27c@agner.ch \
--to=stefan@agner.ch \
--cc=alison.wang@freescale.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianwei.wang.chn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meng.yi@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).