From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v4 12/22] drm: omapdrm: Prevent processing the same event multiple times Date: Thu, 15 Dec 2016 14:20:48 +0200 Message-ID: <1a06debb-e620-cd59-fcdc-bbf4f1572258@ti.com> References: <1481675266-24598-1-git-send-email-laurent.pinchart@ideasonboard.com> <1481675266-24598-13-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0558422554==" Return-path: Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B5016E1EC for ; Thu, 15 Dec 2016 12:20:59 +0000 (UTC) In-Reply-To: <1481675266-24598-13-git-send-email-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0558422554== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2ExexxvrGxKbIODOjRU7hlIXIod0Nc06N" --2ExexxvrGxKbIODOjRU7hlIXIod0Nc06N Content-Type: multipart/mixed; boundary="BtmnB6IV5ToXI6vqOmtTa2hprKNWs0dMn"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Message-ID: <1a06debb-e620-cd59-fcdc-bbf4f1572258@ti.com> Subject: Re: [PATCH v4 12/22] drm: omapdrm: Prevent processing the same event multiple times References: <1481675266-24598-1-git-send-email-laurent.pinchart@ideasonboard.com> <1481675266-24598-13-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1481675266-24598-13-git-send-email-laurent.pinchart@ideasonboard.com> --BtmnB6IV5ToXI6vqOmtTa2hprKNWs0dMn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 14/12/16 02:27, Laurent Pinchart wrote: > The vblank interrupt is disabled after one occurrence, preventing the > atomic update event from being processed twice. However, this also > prevents the software frame counter from being updated correctly that > would require vblank interrupts to be kept enabled while the CRTC is > active. >=20 > In preparation for vblank interrupt fixes, make sure that the atomic > update event will be processed once only when the vblank interrupt will= > be kept enabled. >=20 > Signed-off-by: Laurent Pinchart > --- > Changes since v3: >=20 > - Don't release and reacquire the spinlock for just one return > - Remove unneeded (and unbalanced) drm_crtc_vblank_get() > - Store the event in the atomic flush handler to avoid race condition > - Use spin_lock_irq instead of spin_lock_irsave in flush handler > --- > drivers/gpu/drm/omapdrm/omap_crtc.c | 23 +++++++++++++++-------- > 1 file changed, 15 insertions(+), 8 deletions(-) Reviewed-by: Tomi Valkeinen Tomi --BtmnB6IV5ToXI6vqOmtTa2hprKNWs0dMn-- --2ExexxvrGxKbIODOjRU7hlIXIod0Nc06N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYUoqkAAoJEPo9qoy8lh71jFEQAJSf/wncdf/5oSjJRq8+Xppr 0BvwrKjJz6d5vfqDxJc7tiTHlYxbVqWeh8wBmxUXTHDWhVJpF8wVgkP7q1L+uEvF WanyZOsn663uOkKCxLs72DqxB8gwlmgvynRA0vya8PGJhaDQTpdsGKJZHpKKrw+/ WpHGXCLTtu3uCB0iZPc91F/j88Ait5AdlziSg6KsSz1oyrryZK+atC+RcvhjCBGr lli1PMnFVLCp6pTLGp+2GY3DIJoH2G8jOylZs8nBb6YhsPAs9zjcr+5UodycefYB fLbIRZXUFERSlWHbe29qe/PAxBw2/pf7pM1oTMmIt13Y1os5LiPSvN5HyfJiJ/em 2sOIA7XM2AlAujBMn6bqQT1dP5TcBfNJsCZ0DsGeL2GMTP1nnN7ASLD/9yaFSAJR U6HrLDRHMsXaTXGVWcJEyEj67sPO6um81VKHlu+8LUWgqbbaRuKlLDWe5vONCd79 E/iXNLKrupFKzDRryqHj+XOR3I8mGO7ItHFenLY/WW6kFypOtzcTaHiKAWIWjJaK jiH3j+BMHEOjFMpFk4okwZWbBpwJQFzIIGX1ue8JrbIHkMAHnKCHVxNIdofP5Twj jX+2aZTZWMdMm0ixOCW5iC8tQAf3CusdShMy63ND+j9LlOkpHBZrw4iKSxKuAO24 aLAQefpljXsKxy4nRVSc =upIk -----END PGP SIGNATURE----- --2ExexxvrGxKbIODOjRU7hlIXIod0Nc06N-- --===============0558422554== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0558422554==--