From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm/omapdrm: Switch to gem_free_object_unlocked
Date: Thu, 29 Mar 2018 12:41:33 +0300 [thread overview]
Message-ID: <1adec348-dbd1-bcc3-e5db-446d2b50023a@ti.com> (raw)
In-Reply-To: <20180328114144.19890-1-daniel.vetter@ffwll.ch>
On 28/03/18 14:41, Daniel Vetter wrote:
> The only thing that omap_gem_free_object does that might need the
> magic protection of struct_mutex (of keeping all objects alive if that
> lock is held, even if the last reference is gone) is the mm_list
> manipulation.
>
> But that is already protected by the separate omapdrm->list_lock,
> which means struct_mutex is an entirely internal lock for omapdrm.
> Everything else is just releasing resources, which is all protected
> already by the various subsystems and allocators.
>
> To make this even more obvious we could do an
> s/dev->struct_mutex/omapdrm->gem_lock/ like I've done for udl. But
> since omapdrm is a lot bigger and a lot more active I'll refrain from
> that - this is better done by omapdrm developers at some suitable time
> in the future.
>
> v2: Just auditing the code isn't enough, I actually have to remove
> the now wrong locking check in omap_gem_free_object ...
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
This version works fine. I'll pick this to omapdrm branch. Thanks!
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-29 9:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 8:23 [PATCH 1/5] staging/vboxvideo: Use gem_free_object_unlocked Daniel Vetter
2018-03-27 8:23 ` [PATCH 2/5] drm/rockchip: fixup comment for gem_free_object_unlocked Daniel Vetter
2018-03-28 14:02 ` Sean Paul
2018-03-27 8:23 ` [PATCH 3/5] drm/udl: Get rid of dev->struct_mutex usage Daniel Vetter
2018-03-27 16:35 ` Sean Paul
2018-03-27 8:23 ` [PATCH 4/5] drm/omapdrm: Fix mm_list locking Daniel Vetter
2018-03-29 9:40 ` Tomi Valkeinen
2018-03-27 8:23 ` [PATCH 5/5] drm/omapdrm: Switch to gem_free_object_unlocked Daniel Vetter
2018-03-28 9:52 ` Tomi Valkeinen
2018-03-28 10:12 ` Daniel Vetter
2018-03-28 11:13 ` Tomi Valkeinen
2018-03-28 11:41 ` [PATCH] " Daniel Vetter
2018-03-29 9:41 ` Tomi Valkeinen [this message]
2018-04-02 15:05 ` Laurent Pinchart
2018-04-03 9:07 ` Daniel Vetter
2018-04-03 11:23 ` Laurent Pinchart
2018-03-27 8:34 ` [PATCH 1/5] staging/vboxvideo: Use gem_free_object_unlocked Greg Kroah-Hartman
2018-03-27 9:18 ` Daniel Vetter
2018-03-27 15:25 ` Greg Kroah-Hartman
2018-03-28 15:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1adec348-dbd1-bcc3-e5db-446d2b50023a@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox