[PATCH] drm/sched: Remove mention of indirect buffers

[PATCH] drm/sched: Remove mention of indirect buffers

[Tvrtko Ursulin]

Indirect buffers are an AMD term describing essentialy a job submitted to
the scheduler, just a lower level one. Since scheduler was promoted to be
generic long ago, lets replace those references with jobs.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Philipp Stanner <phasta@kernel.org>
---
 drivers/gpu/drm/scheduler/sched_entity.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
index 8867b95ab089..254932b9050e 100644
--- a/drivers/gpu/drm/scheduler/sched_entity.c
+++ b/drivers/gpu/drm/scheduler/sched_entity.c
@@ -285,9 +285,9 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
 		return 0;
 
 	sched = entity->rq->sched;
-	/**
-	 * The client will not queue more IBs during this fini, consume existing
-	 * queued IBs or discard them on SIGKILL
+	/*
+	 * The client will not queue more jobs during this fini - consume
+	 * existing queued ones, or discard them on SIGKILL.
 	 */
 	if (current->flags & PF_EXITING) {
 		if (timeout)
@@ -300,7 +300,7 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
 				    drm_sched_entity_is_idle(entity));
 	}
 
-	/* For killed process disable any more IBs enqueue right now */
+	/* For a killed process disallow further enqueueing of jobs. */
 	last_user = cmpxchg(&entity->last_user, current->group_leader, NULL);
 	if ((!last_user || last_user == current->group_leader) &&
 	    (current->flags & PF_EXITING) && (current->exit_code == SIGKILL))
@@ -324,9 +324,9 @@ EXPORT_SYMBOL(drm_sched_entity_flush);
 void drm_sched_entity_fini(struct drm_sched_entity *entity)
 {
 	/*
-	 * If consumption of existing IBs wasn't completed. Forcefully remove
-	 * them here. Also makes sure that the scheduler won't touch this entity
-	 * any more.
+	 * If consumption of existing jobs wasn't completed forcefully remove
+	 * them. Also makes sure that the scheduler won't touch this entity any
+	 * more.
 	 */
 	drm_sched_entity_kill(entity);
 
-- 
2.48.0

Re: [PATCH] drm/sched: Remove mention of indirect buffers

[Alex Deucher]

On Thu, Aug 14, 2025 at 9:36 AM Tvrtko Ursulin
<tvrtko.ursulin@igalia.com> wrote:
>
> Indirect buffers are an AMD term describing essentialy a job submitted to
> the scheduler, just a lower level one. Since scheduler was promoted to be
> generic long ago, lets replace those references with jobs.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Philipp Stanner <phasta@kernel.org>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/scheduler/sched_entity.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index 8867b95ab089..254932b9050e 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -285,9 +285,9 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
>                 return 0;
>
>         sched = entity->rq->sched;
> -       /**
> -        * The client will not queue more IBs during this fini, consume existing
> -        * queued IBs or discard them on SIGKILL
> +       /*
> +        * The client will not queue more jobs during this fini - consume
> +        * existing queued ones, or discard them on SIGKILL.
>          */
>         if (current->flags & PF_EXITING) {
>                 if (timeout)
> @@ -300,7 +300,7 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
>                                     drm_sched_entity_is_idle(entity));
>         }
>
> -       /* For killed process disable any more IBs enqueue right now */
> +       /* For a killed process disallow further enqueueing of jobs. */
>         last_user = cmpxchg(&entity->last_user, current->group_leader, NULL);
>         if ((!last_user || last_user == current->group_leader) &&
>             (current->flags & PF_EXITING) && (current->exit_code == SIGKILL))
> @@ -324,9 +324,9 @@ EXPORT_SYMBOL(drm_sched_entity_flush);
>  void drm_sched_entity_fini(struct drm_sched_entity *entity)
>  {
>         /*
> -        * If consumption of existing IBs wasn't completed. Forcefully remove
> -        * them here. Also makes sure that the scheduler won't touch this entity
> -        * any more.
> +        * If consumption of existing jobs wasn't completed forcefully remove
> +        * them. Also makes sure that the scheduler won't touch this entity any
> +        * more.
>          */
>         drm_sched_entity_kill(entity);
>
> --
> 2.48.0
>

Re: [PATCH] drm/sched: Remove mention of indirect buffers

[Christian König]

On 14.08.25 15:36, Tvrtko Ursulin wrote:
> Indirect buffers are an AMD term describing essentialy a job submitted to
> the scheduler, just a lower level one. Since scheduler was promoted to be
> generic long ago, lets replace those references with jobs.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Philipp Stanner <phasta@kernel.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/scheduler/sched_entity.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index 8867b95ab089..254932b9050e 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -285,9 +285,9 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
>  		return 0;
>  
>  	sched = entity->rq->sched;
> -	/**
> -	 * The client will not queue more IBs during this fini, consume existing
> -	 * queued IBs or discard them on SIGKILL
> +	/*
> +	 * The client will not queue more jobs during this fini - consume
> +	 * existing queued ones, or discard them on SIGKILL.
>  	 */
>  	if (current->flags & PF_EXITING) {
>  		if (timeout)
> @@ -300,7 +300,7 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
>  				    drm_sched_entity_is_idle(entity));
>  	}
>  
> -	/* For killed process disable any more IBs enqueue right now */
> +	/* For a killed process disallow further enqueueing of jobs. */
>  	last_user = cmpxchg(&entity->last_user, current->group_leader, NULL);
>  	if ((!last_user || last_user == current->group_leader) &&
>  	    (current->flags & PF_EXITING) && (current->exit_code == SIGKILL))
> @@ -324,9 +324,9 @@ EXPORT_SYMBOL(drm_sched_entity_flush);
>  void drm_sched_entity_fini(struct drm_sched_entity *entity)
>  {
>  	/*
> -	 * If consumption of existing IBs wasn't completed. Forcefully remove
> -	 * them here. Also makes sure that the scheduler won't touch this entity
> -	 * any more.
> +	 * If consumption of existing jobs wasn't completed forcefully remove
> +	 * them. Also makes sure that the scheduler won't touch this entity any
> +	 * more.
>  	 */
>  	drm_sched_entity_kill(entity);
>  

Re: [PATCH] drm/sched: Remove mention of indirect buffers

[Philipp Stanner]

On Thu, 2025-08-14 at 14:36 +0100, Tvrtko Ursulin wrote:
> Indirect buffers are an AMD term describing essentialy a job submitted to
> the scheduler, just a lower level one. Since scheduler was promoted to be
> generic long ago, lets replace those references with jobs.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Philipp Stanner <phasta@kernel.org>

Applied to drm-misc-next

Thx
P.

> ---
>  drivers/gpu/drm/scheduler/sched_entity.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index 8867b95ab089..254932b9050e 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -285,9 +285,9 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
>  		return 0;
>  
>  	sched = entity->rq->sched;
> -	/**
> -	 * The client will not queue more IBs during this fini, consume existing
> -	 * queued IBs or discard them on SIGKILL
> +	/*
> +	 * The client will not queue more jobs during this fini - consume
> +	 * existing queued ones, or discard them on SIGKILL.
>  	 */
>  	if (current->flags & PF_EXITING) {
>  		if (timeout)
> @@ -300,7 +300,7 @@ long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout)
>  				    drm_sched_entity_is_idle(entity));
>  	}
>  
> -	/* For killed process disable any more IBs enqueue right now */
> +	/* For a killed process disallow further enqueueing of jobs. */
>  	last_user = cmpxchg(&entity->last_user, current->group_leader, NULL);
>  	if ((!last_user || last_user == current->group_leader) &&
>  	    (current->flags & PF_EXITING) && (current->exit_code == SIGKILL))
> @@ -324,9 +324,9 @@ EXPORT_SYMBOL(drm_sched_entity_flush);
>  void drm_sched_entity_fini(struct drm_sched_entity *entity)
>  {
>  	/*
> -	 * If consumption of existing IBs wasn't completed. Forcefully remove
> -	 * them here. Also makes sure that the scheduler won't touch this entity
> -	 * any more.
> +	 * If consumption of existing jobs wasn't completed forcefully remove
> +	 * them. Also makes sure that the scheduler won't touch this entity any
> +	 * more.
>  	 */
>  	drm_sched_entity_kill(entity);
>