From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 13/16] drm/omap: use u32 instead of enum omap_color_mode Date: Wed, 24 May 2017 14:01:57 +0300 Message-ID: <1e271875-7fa8-1576-062c-49feb3aef80e@ti.com> References: <1493893412-12178-1-git-send-email-tomi.valkeinen@ti.com> <2936246.4Oq3uqjSjE@avalon> <2155194.RFTWLhi1J2@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0994799129==" Return-path: Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2CAE6E5EF for ; Wed, 24 May 2017 11:02:02 +0000 (UTC) In-Reply-To: <2155194.RFTWLhi1J2@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0994799129== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O3gvRhkCTLoHhgt0JT16lHh6HU6DhvQGR" --O3gvRhkCTLoHhgt0JT16lHh6HU6DhvQGR Content-Type: multipart/mixed; boundary="dIhxbqLFpdxeeE2lO5vd34rPBr7fo5o05"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Jyri Sarha Message-ID: <1e271875-7fa8-1576-062c-49feb3aef80e@ti.com> Subject: Re: [PATCH 13/16] drm/omap: use u32 instead of enum omap_color_mode References: <1493893412-12178-1-git-send-email-tomi.valkeinen@ti.com> <2936246.4Oq3uqjSjE@avalon> <2155194.RFTWLhi1J2@avalon> In-Reply-To: <2155194.RFTWLhi1J2@avalon> --dIhxbqLFpdxeeE2lO5vd34rPBr7fo5o05 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 24/05/17 13:46, Laurent Pinchart wrote: > Hi Tomi, >=20 > On Wednesday 24 May 2017 13:37:48 Tomi Valkeinen wrote: >> On 24/05/17 13:28, Laurent Pinchart wrote: >>> On Thursday 04 May 2017 13:23:29 Tomi Valkeinen wrote: >>>> In this step we drop 'enum omap_color_mode', and use u32 instead. >>>> >>>> Signed-off-by: Tomi Valkeinen >>> >>> I believe this should go before 12/16, otherwise you end up temporari= ly >>> storing DRM_FORMAT_* values in enum omap_color_mode variables. >> >> That's on purpose, I mention it in the previous patch. Do you see a >> problem with it? >=20 > It's dirty :-) You had to silence a few warnings with explicit casts be= cause=20 > of that. >=20 >> If I change the order, then I'd be going back and forth with u32 and >> enum omap_color_mode. >=20 > If you first switch to u32, there's nothing wrong storing the enum=20 > omap_color_mode value in a u32, and it will then be easy to transition = to=20 > DRM_FORMAT_*. True, I did that and the end result looks a bit cleaner. Thanks! Tomi --dIhxbqLFpdxeeE2lO5vd34rPBr7fo5o05-- --O3gvRhkCTLoHhgt0JT16lHh6HU6DhvQGR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZJWglAAoJEPo9qoy8lh71xgIP/jfdym835Y84nV8zt0nmWFd7 Ean+NteO/3XabAlnLVHLF9FNcl3gIxjNdhA1DQGpSXw/WnAu5Q+XTPpthFfTURbj adjM9Ors3WDcSCUaf7RCv2D8qI+Z35+uuaZMLZnxH3ywGFte4ihvl5pzD50y/S33 q3w6078no/cytPW2b0DJt5rRjyWJWTnnJxcsW7I9womLmdpL2bZTmoINTncEDOEL 3c78V54umEhPYqlqYR5uPAT4br3HKMj3U+/eFXVOkue456d3KxmCFbUxfaWlWZq7 t5z5j8TO9E4nIEmincDfvmM5+HP/m+9FnCg+licEQskX1cX9JvLKOYiB2xR2BT6W 0IeH31EPlokDrIkWSnJ4oGlil2LSYe4ISB2SqnTnwova5Z887IeTkWssoPJOI5se EXAHtFylvWgOLie7CS+psBdQXqOJapxDTvCp168G95AR4O71I+2rv75VLgDz90yz Sd8U4IuXSvRJOsGKvKJpUVGt62olFyAorDYyYisuCZU33aqmYBUv5wL57V7hmndJ NRpa9YDxMgNbXOTmmBfxfQRxlIIqifsq3pZw28iyxwPPhonWQz1aC+Jo+u+4DCf9 cQXDZ30jwVpv0cfSZ8PvZW3UH13KkLOw/A9NnbvyOxiFxKUT3DEKAK1evdGdZOEh Y/yDqtQgsP5jsEwJCjjU =U7pX -----END PGP SIGNATURE----- --O3gvRhkCTLoHhgt0JT16lHh6HU6DhvQGR-- --===============0994799129== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0994799129==--