From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28497D41D74 for ; Mon, 15 Dec 2025 12:25:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C82B10E485; Mon, 15 Dec 2025 12:25:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="MFNtC9o7"; dkim-atps=neutral Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41E3A10E485; Mon, 15 Dec 2025 12:25:18 +0000 (UTC) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4dVK5Q3lJFz9scD; Mon, 15 Dec 2025 13:25:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1765801514; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gJOFMp1/K+qQ0MSqjWn/CbbRaLJJuaP23xTo6CU3FMU=; b=MFNtC9o7GDr77G4gP5pdlWOgQeeiKPzkDClg8L2DPLsenZjXbBPFNYiW+f7Yt3dIHPmQyP OJMvPnvOPIvbcMj8jkup2nPMtdqY9haLsfcz/IxOV2J03K4sDF356sDyQ23TsGQ07TViaD FhWOVrJMTFcJ9CeKh2BEanhmBKLu/puWhJkeqyz5IF7MKc0wDX6+LpZo37kPzrx07UbVHu /SrGIEw9Yb9k6R4DHidfnQwttDmp8t0gODXRNwKwn1DjYqW3hsQZd1gJ97ZgepaPr9lGGF Kb4b3/HsX4GoqvHqXz/IOEsaMsqC0j4WmS+EX3sDV8DayQFJEqKPzO/PssjTDQ== Message-ID: <1f0fd860bf3466b9967d5a99ecd49eb93e0f7a19.camel@mailbox.org> Subject: Re: [PATCH 12/14] drm/scheduler: Describe @result in drm_sched_job_done() From: Philipp Stanner To: Bagas Sanjaya , Linux Kernel Mailing List , Linux AMDGPU , Linux DRI Development , Linux Filesystems Development , Linux Media , linaro-mm-sig@lists.linaro.org, kasan-dev@googlegroups.com, Linux Virtualization , Linux Memory Management List , Linux Network Bridge , Linux Networking Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthew Brost , Danilo Krummrich , Philipp Stanner , Alexander Viro , Christian Brauner , Jan Kara , Sumit Semwal , Alexander Potapenko , Marco Elver , Dmitry Vyukov , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?ISO-8859-1?Q?P=E9rez?= , Andrew Morton , Uladzislau Rezki , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Taimur Hassan , Wayne Lin , Alex Hung , Aurabindo Pillai , Dillon Varone , George Shen , Aric Cyr , Cruise Hung , Mario Limonciello , Sunil Khatri , Dominik Kaszewski , David Hildenbrand , Peter Zijlstra , Lorenzo Stoakes , Max Kellermann , "Nysal Jan K.A." , Ryan Roberts , Alexey Skidanov , Vlastimil Babka , Kent Overstreet , Vitaly Wool , Harry Yoo , Mateusz Guzik , NeilBrown , Amir Goldstein , Jeff Layton , Ivan Lipski , Tao Zhou , YiPeng Chai , Hawking Zhang , Lyude Paul , Daniel Almeida , Luben Tuikov , Matthew Auld , Roopa Prabhu , Mao Zhu , Shaomin Deng , Charles Han , Jilin Yuan , Swaraj Gaikwad , George Anthony Vernon Date: Mon, 15 Dec 2025 13:24:46 +0100 In-Reply-To: <20251215113903.46555-13-bagasdotme@gmail.com> References: <20251215113903.46555-1-bagasdotme@gmail.com> <20251215113903.46555-13-bagasdotme@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MBO-RS-META: q9aiurnjorghwoz79fww7b6wqkkf5zeq X-MBO-RS-ID: ca016de3dd37ac937be X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phasta@kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" nit about commit title: We use "drm/sched:" as prefix nowadays On Mon, 2025-12-15 at 18:39 +0700, Bagas Sanjaya wrote: > Sphinx reports kernel-doc warning: >=20 > WARNING: ./drivers/gpu/drm/scheduler/sched_main.c:367 function parameter = 'result' not described in 'drm_sched_job_done' >=20 > Describe @result parameter to fix it >=20 Thx for fixing this! > . >=20 > Fixes: 539f9ee4b52a8b ("drm/scheduler: properly forward fence errors") > Signed-off-by: Bagas Sanjaya > --- > =C2=A0drivers/gpu/drm/scheduler/sched_main.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/sch= eduler/sched_main.c > index 1d4f1b822e7b76..4f844087fd48eb 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_s= cheduler *sched) > =C2=A0/** > =C2=A0 * drm_sched_job_done - complete a job > =C2=A0 * @s_job: pointer to the job which is done > + * @result: job result "error code for the job's finished-fence" would be a bit better and more verbose. With that: Reviewed-by: Philipp Stanner > =C2=A0 * > =C2=A0 * Finish the job's fence and resubmit the work items. > =C2=A0 */