From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Skeggs Subject: Re: [PATCH] drm/nouveau: silence warnings reported during builds with W=1 Date: Sun, 4 Sep 2016 11:52:22 +1000 Message-ID: <1ffad079-befe-4f07-4751-eeeb2142a633@gmail.com> References: <1472573836-2759-1-git-send-email-baoyou.xie@linaro.org> <201608302204.41518.arnd@arndb.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0301945683==" Return-path: Received: from mail-pa0-x244.google.com (mail-pa0-x244.google.com [IPv6:2607:f8b0:400e:c03::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A0196E0E7 for ; Sun, 4 Sep 2016 01:49:13 +0000 (UTC) Received: by mail-pa0-x244.google.com with SMTP id pp5so874564pac.2 for ; Sat, 03 Sep 2016 18:49:13 -0700 (PDT) Received: from [192.168.0.117] (182-239-193-174.ip.adam.com.au. [182.239.193.174]) by smtp.gmail.com with ESMTPSA id p74sm8613577pfk.68.2016.09.03.18.49.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Sep 2016 18:49:11 -0700 (PDT) In-Reply-To: <201608302204.41518.arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0301945683== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="goCABwb8CbrUmefm38ANEBf99QHJCvfIV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --goCABwb8CbrUmefm38ANEBf99QHJCvfIV Content-Type: multipart/mixed; boundary="csOT4g30Tr11fNlRNn09CNl4uiafOLOOt" From: Ben Skeggs To: dri-devel@lists.freedesktop.org Message-ID: <1ffad079-befe-4f07-4751-eeeb2142a633@gmail.com> Subject: Re: [PATCH] drm/nouveau: silence warnings reported during builds with W=1 References: <1472573836-2759-1-git-send-email-baoyou.xie@linaro.org> <201608302204.41518.arnd@arndb.de> In-Reply-To: <201608302204.41518.arnd@arndb.de> --csOT4g30Tr11fNlRNn09CNl4uiafOLOOt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/31/2016 06:04 AM, Arnd Bergmann wrote: > On Tuesday 30 August 2016, Baoyou Xie wrote: >> We get some warnings when building kernel with W=3D1: >> drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no p= revious prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes] >> drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no pr= evious prototype for 'nv50_grctx_fill' [-Wmissing-prototypes] >> drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:265:1: warning: no pr= evious prototype for 'nv50_grctx_init' [-Wmissing-prototypes] >> .... >> >> In fact, some functions are only used in the file in which they >> are declared and don't need a declaration, but can be made static. >> and others are declared in the header files, but need to add >> missing header dependencies. >> >> Signed-off-by: Baoyou Xie >=20 > The patch looks very good, and this is better than one patch per file. = I would personally > do this as two patches, as you are touching a number of files and are d= oing two separate > things here. As a rule of thumb, when the changelog text mentions two o= r more things > that the patch does, the patch should be split up so that each part doe= s one thing. > After you do that, it also becomes easier to write a good subject line = like "mark > function as static" and "add missing includes", which tells you more ab= out the patch > than "silence warnings". >=20 > It's quite likely that the nouveau maintainers are less picky than I am= though, so > if they want to apply the patch as-is >=20 > Acked-by: Arnd Bergmann >=20 > Otherwise please split and resend in a few days, in case there are othe= r comments This patch does indeed look a lot better than the previous series. I would also prefer the patch to be split into two as suggested by Arnd. Other than that, I'm very happy to take the patch. Thank you for your wo= rk! Ben. > that need to be addressed. >=20 > Arnd > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >=20 --csOT4g30Tr11fNlRNn09CNl4uiafOLOOt-- --goCABwb8CbrUmefm38ANEBf99QHJCvfIV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXy35XAAoJEHYLnGJQkpH7Cn0QAMZXYY3HIOZeIE64f5MrHs5I J++pbdy5jzdh/8OR4DKAa/yYMQ1cRF9fm128qJD5QXKZTwc1AE6VF/yvpWJz6Mti NVTSpaFBQ+zgRKMBvSmNQL1JHYFFR3va6j8R2yHmmrCm/BniYYuyrNeKx+AX4o0A nrsnmLtQCSZhss21VQnMrYOWXFb9TI81pV/WwytM9Phb9/knREDwzGt4V+b6JVjw Dy1TmF4U8d6dVvONprJ0HgYdpg39VwaPOnn42n1l5EGwvuNU+wwf9nKxFiUKRl6D I9ncwVASWfW7b6hYdD8lgVtk6TUWeTIF2/jvToA+Vo1HK+7x7Pg7kDiePK7wwwoz tIgUqHnSyooeIQzyhADR36H9QlEH0qgvibLpjHVDYNfEq+9/MaKdqk8IAugfLQJN sdlBjiETWj9h37tS9BeuSVheObuBTZlsjhhKnhEKczJA8AJ7TPvgctXU6OlwHH0I ceih1x7C8zENDYpGUshtUphkIAcY9oNZKdltRl3Yh2QBjfJ90FJJOqTkzeL3Rwnd tldS97PTiUf6ia1q5HnGWpO9RyLw1ij3e2WmG9pvhU8xJnNcHlZ/tZQN3ZbNi9RY dA+0NUqAE3xVZXnk0pcZaZeQ16/BBcIr+ZzSa70d1sO/HaomRNsHZzneGFzeXJ5O UvNQkLFT9mSMNu26VY2A =umLe -----END PGP SIGNATURE----- --goCABwb8CbrUmefm38ANEBf99QHJCvfIV-- --===============0301945683== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0301945683==--