From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org,
DRI Development <dri-devel@lists.freedesktop.org>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH] rcar-du: add/rename DEFR6 TCON bits
Date: Tue, 26 Apr 2016 00:07:59 +0300 [thread overview]
Message-ID: <20054207.ltPEUenxrn@avalon> (raw)
In-Reply-To: <CAMuHMdWqskNoX4ryvzzs04LkMf6=tCQYaqn5ufuVdmsnPz8+fA@mail.gmail.com>
Hi Geert,
On Monday 25 Apr 2016 09:25:30 Geert Uytterhoeven wrote:
> On Sat, Apr 23, 2016 at 12:56 AM, Sergei Shtylyov wrote:
> > The TCNE2 bit of the DEFR6 register was renamed to TCNE1 in the R-Car
> > gen2 manuals -- which makes more sense as that bit controls whether DU1,
> > not DU2 is connected to TCON.
> >
> > While at it, add the TCNE0 bit which controls whether DU0 is connected to
> > TCON.
> >
> > Based on the large patch by Andrey Gusakov
> > <andrey.gusakov@cogentembedded.com>.
> >
> > Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> I hard a hard time finding this register, as it's actually called "DEF6R"...
> Care to update /DEFRx/DEFxR/ as well?
Inconsistent information between datasheet versions I'm afraid, and even
between different registers in a single datasheet. We have DEFR0, DEFR1, and
then DEFxR. I wonder if it's worth renaming the registers.
> Regardless:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > ---
> > The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch.
> >
> > drivers/gpu/drm/rcar-du/rcar_du_regs.h | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > Index: linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> > ===================================================================
> > --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> > +++ linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> > @@ -195,9 +195,10 @@
> >
> > #define DEFR6_ODPM12_DISP (2 << 8)
> > #define DEFR6_ODPM12_CDE (3 << 8)
> > #define DEFR6_ODPM12_MASK (3 << 8)
> >
> > -#define DEFR6_TCNE2 (1 << 6)
> > +#define DEFR6_TCNE1 (1 << 6)
> > +#define DEFR6_TCNE0 (1 << 4)
> >
> > #define DEFR6_MLOS1 (1 << 2)
> >
> > -#define DEFR6_DEFAULT (DEFR6_CODE | DEFR6_TCNE2)
> > +#define DEFR6_DEFAULT (DEFR6_CODE | DEFR6_TCNE1)
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-25 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 22:56 [PATCH] rcar-du: add/rename DEFR6 TCON bits Sergei Shtylyov
2016-04-25 7:25 ` Geert Uytterhoeven
2016-04-25 11:34 ` Sergei Shtylyov
2016-04-25 21:07 ` Laurent Pinchart [this message]
2016-04-25 21:11 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20054207.ltPEUenxrn@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox