From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dave Airlie <airlied@redhat.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm: allow drivers to provide their own EDID fetching routine
Date: Tue, 20 Jul 2010 16:05:47 -0700 [thread overview]
Message-ID: <20100720160547.5e73889c@virtuousgeek.org> (raw)
In-Reply-To: <1279666470.337.5.camel@clockmaker-el6>
On Wed, 21 Jul 2010 08:54:30 +1000
Dave Airlie <airlied@redhat.com> wrote:
> On Tue, 2010-07-20 at 15:44 -0700, Jesse Barnes wrote:
> > Make drm_edid_read take a new argument, edid_read, to allow drivers to
> > provide their own EDID fetch routine. Export the bit banging DDC over
> > i2c version of the EDID fetching routine and make the drivers use it.
> > This sets the stage for GMBUS support in the Intel driver.
> >
>
> I think this needs some rework.
>
> You might want to checkout what the radeon driver does for hw i2c
> engine. You should set up your own i2c hw handlers and use those instead
> of bypassing the i2c stack. GMBUS is just another i2c hw block.
I'll check it out, but I don't see what using the i2c stack buys us
here except for obfuscation...
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-07-20 23:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 22:44 [PATCH 1/2] drm: allow drivers to provide their own EDID fetching routine Jesse Barnes
2010-07-20 22:44 ` [PATCH 2/2] drm/i915: use GMBUS for EDID fetching Jesse Barnes
2010-07-20 22:54 ` [PATCH 1/2] drm: allow drivers to provide their own EDID fetching routine Dave Airlie
2010-07-20 23:05 ` Jesse Barnes [this message]
2010-07-20 23:27 ` Dave Airlie
2010-07-20 23:34 ` Jesse Barnes
2010-07-20 23:35 ` Dave Airlie
2010-07-20 23:43 ` Jesse Barnes
2010-07-21 0:08 ` [Intel-gfx] " Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720160547.5e73889c@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox