From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] vgaarb: use bridges to control VGA routing where possible. (v2) Date: Mon, 20 Dec 2010 20:02:58 -0800 Message-ID: <20101220200258.305889ec@jbarnes-desktop> References: <1292803809-9200-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1292803809-9200-1-git-send-email-airlied@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Dave Airlie Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie List-Id: dri-devel@lists.freedesktop.org On Mon, 20 Dec 2010 10:10:09 +1000 Dave Airlie wrote: > - * @change_bridge: traverse ancestors and change bridges > + * @change_bridge_flags: traverse ancestors and change bridges > + * CHANGE_BRIDGE_ONLY / CHANGE_BRIDGE > */ > int pci_set_vga_state(struct pci_dev *dev, bool decode, > - unsigned int command_bits, bool change_bridge) > + unsigned int command_bits, u32 flags) > { Other than this nitpick, it looks sound to me; we'll need to actually disable VGA decode in the shared bridge hierarchy case rather than just using simple bridge routing. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center