From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 08/32] drm/nouveau: use system_wq instead of dev_priv->wq Date: Thu, 6 Jan 2011 09:29:22 -0800 Message-ID: <20110106172922.GA29580@mtj.dyndns.org> References: <1294062595-30097-1-git-send-email-tj@kernel.org> <1294062595-30097-9-git-send-email-tj@kernel.org> <1294189627.2276.0.camel@nisroch> <1294190172.2276.2.camel@nisroch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1294190172.2276.2.camel@nisroch> Sender: linux-kernel-owner@vger.kernel.org To: Ben Skeggs Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hello, On Wed, Jan 05, 2011 at 11:16:05AM +1000, Ben Skeggs wrote: > On Wed, 2011-01-05 at 11:07 +1000, Ben Skeggs wrote: > > On Mon, 2011-01-03 at 14:49 +0100, Tejun Heo wrote: > > > With cmwq, there's no reason for nouveau to use a dedicated workqueue. > > > Drop dev_priv->wq and use system_wq instead. > > > > > > Because nouveau_irq_uninstall() may be called from unsleepable > > > context, the work items can't be flushed from there. Instead, init > > > and flush from nouveau_load/unload(). > > Ehh, ok, why not! I'll push this through the nouveau tree, and it'll > > get to Dave from there. > > On second thoughts, this won't apply on top of current nouveau code > that's queued for 2.6.38. Can you rebase on top of Dave's drm-next tree > please. We already missed this merge window, so I'll refresh the patch once the window is closed and resend. Thank you. -- tejun