From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: Linux 2.6.37 Date: Fri, 7 Jan 2011 16:52:00 +0100 Message-ID: <20110107155200.GA3883@tiehlicka.suse.cz> References: <20110106104816.GA4026@tiehlicka.suse.cz> <1bdc18$j6a1ns@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alex Riesen Cc: Chris Wilson , Linus Torvalds , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu 06-01-11 22:08:46, Alex Riesen wrote: > On Thu, Jan 6, 2011 at 21:55, Alex Riesen wrote: > > On Thu, Jan 6, 2011 at 18:49, Chris Wilson wrote: > >> > >> My fear is that some machines have a dependency between the backlight > >> and panel power status. The patch in question changed the timing between > >> turning on the panel and adjusting the backlight which would be restore > >> with: > >> > >> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c > >> index aa23070..0b40b4f 100644 > >> --- a/drivers/gpu/drm/i915/intel_lvds.c > >> +++ b/drivers/gpu/drm/i915/intel_lvds.c > >> @@ -106,6 +106,12 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds) > >> ?? ?? ?? ??I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON); > >> ?? ?? ?? ??POSTING_READ(lvds_reg); > >> > >> + ?? ?? ?? { > >> + ?? ?? ?? ?? ?? ?? ?? u32 reg = HAS_PCH_SPLIT(dev) ? PCH_PP_STATUS : PPS_STATUS; > ... > > FWIW it does not compile: > > ??CC ?? ?? ??drivers/gpu/drm/i915/intel_lvds.o > > drivers/gpu/drm/i915/intel_lvds.c: In function ???intel_lvds_enable???: > > drivers/gpu/drm/i915/intel_lvds.c:110: error: ???PPS_STATUS??? undeclared > > Ah, I see. Should be PP_STATUS. Whatever. It does not help. The backlight > stays off. It didn't help in my case either -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic