From mboxrd@z Thu Jan  1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 32511] glDrawPixels broken on savage
Date: Sat,  8 Jan 2011 14:40:18 -0800 (PST)
Message-ID: <20110108224018.9DF47130061@annarchy.freedesktop.org>
References: <bug-32511-502@http.bugs.freedesktop.org/>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from annarchy.freedesktop.org (annarchy.freedesktop.org
	[131.252.210.176])
	by gabe.freedesktop.org (Postfix) with ESMTP id C97BD9E76D
	for <dri-devel@lists.freedesktop.org>;
	Sat,  8 Jan 2011 14:40:18 -0800 (PST)
In-Reply-To: <bug-32511-502@http.bugs.freedesktop.org/>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

https://bugs.freedesktop.org/show_bug.cgi?id=32511

--- Comment #10 from Tormod Volden <bugzi09.fdo.tormod@xoxy.net> 2011-01-08 14:40:18 PST ---
It seems like offsetting the aperture address fixes this issue. I am not sure
what is the proper place to do this, but this patch at least works for me. It
fixes drawpix and a lot of xscreensaver hacks: glblur works again,
molecule/polyhedra/juggler3d and many others are now free of corruption.
antspotlight works better, but sometimes hangs or dies, probably for unrelated
reasons.

diff --git a/src/mesa/drivers/dri/savage/savagecontext.h
b/src/mesa/drivers/dri/savage/savagecontext.h
index 75bec62..2557605 100644
--- a/src/mesa/drivers/dri/savage/savagecontext.h
+++ b/src/mesa/drivers/dri/savage/savagecontext.h
@@ -311,9 +311,9 @@ extern int SAVAGE_DEBUG;
 #define DEBUG_DMA            0x010
 #define DEBUG_STATE          0x020

-#define TARGET_FRONT    0x0
-#define TARGET_BACK     0x1
-#define TARGET_DEPTH    0x2
+#define TARGET_FRONT    0x2
+#define TARGET_BACK     0x3
+#define TARGET_DEPTH    0x4

 #define SUBPIXEL_X -0.5
 #define SUBPIXEL_Y -0.375

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.