dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 32246] Compiz 0.9 switcher segfaults in mipmap generation code
Date: Tue, 15 Feb 2011 18:02:31 -0800 (PST)	[thread overview]
Message-ID: <20110216020231.5734F130009@annarchy.freedesktop.org> (raw)
In-Reply-To: <bug-32246-502@http.bugs.freedesktop.org/>

https://bugs.freedesktop.org/show_bug.cgi?id=32246

--- Comment #4 from Bryce Harrington <bryce@canonical.com> 2011-02-15 18:02:31 PST ---
Created an attachment (id=43410)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=43410)
0001-Check-for-null-pointer-in-mipmap-image-data.patch

It looks to me like this occurs when the calling application passes in a mipmap
that has undefined image data (e.g. priv-target->Image[0][0]->Data == NULL in
this case).

For the case where _mesa_is_format_compressed() is true, there is an ASSERT to
catch that this is undefined, but there is no such check for the false case.

The attached patch adds such a check (a problem message rather than an
assertion, though).  Possibly it should be using _mesa_error() or perhaps an
assert; I'm not certain.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

  parent reply	other threads:[~2011-02-16  2:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09  5:01 [Bug 32246] New: Compiz 0.9 switcher segfaults in mipmap generation code bugzilla-daemon
2010-12-09  5:17 ` [Bug 32246] " bugzilla-daemon
2010-12-09 20:25 ` bugzilla-daemon
2010-12-09 21:42 ` bugzilla-daemon
2011-02-16  2:02 ` bugzilla-daemon [this message]
2011-03-07 16:49 ` [Bug 32246] [RADEON:KMS:R600C] compiz " bugzilla-daemon
2012-11-02 16:30 ` bugzilla-daemon
2014-07-07 16:03 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110216020231.5734F130009@annarchy.freedesktop.org \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).