From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 35935] since 2.6.38.1, screen become garbled after some times (RV770)
Date: Tue, 26 Apr 2011 14:20:29 -0700 (PDT) [thread overview]
Message-ID: <20110426212030.2122913004F@annarchy.freedesktop.org> (raw)
In-Reply-To: <bug-35935-502@http.bugs.freedesktop.org/>
https://bugs.freedesktop.org/show_bug.cgi?id=35935
--- Comment #5 from Mjules <mjulien.m@gmail.com> 2011-04-26 14:20:30 PDT ---
The result of the bisection is :
ba3ffdc68b4c80fe4cc42bdae6040eca1067ebb2 is the first bad commit
commit ba3ffdc68b4c80fe4cc42bdae6040eca1067ebb2
Author: Stanislav Kinsbursky <skinsbursky@parallels.com>
Date: Thu Mar 17 18:54:23 2011 +0300
RPC: killing RPC tasks races fixed
commit 8e26de238fd794c8ea56a5c98bf67c40cfeb051d upstream.
RPC task RPC_TASK_QUEUED bit is set must be checked before trying to wake
up
task rpc_killall_tasks() because task->tk_waitqueue can not be set (equal
to
NULL).
Also, as Trond Myklebust mentioned, such approach (instead of checking
tk_waitqueue to NULL) allows us to "optimise away the call to
rpc_wake_up_queued_task() altogether for those
tasks that aren't queued".
Here is an example of dereferencing of tk_waitqueue equal to NULL:
CPU 0 CPU 1 CPU 2
-------------------- --------------------- --------------------------
nfs4_run_open_task
rpc_run_task
rpc_execute
rpc_set_active
rpc_make_runnable
(waiting)
rpc_async_schedule
nfs4_open_prepare
nfs_wait_on_sequence
nfs_umount_begin
rpc_killall_tasks
rpc_wake_up_task
rpc_wake_up_queued_task
spin_lock(tk_waitqueue == NULL)
BUG()
rpc_sleep_on
spin_lock(&q->lock)
__rpc_sleep_on
task->tk_waitqueue = q
Signed-off-by: Stanislav Kinsbursky <skinsbursky@openvz.org>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
:040000 040000 91b88f0611c9ff1cf2691d9d65ec13c652a554ac
e23b6d459a8bef93de6ea4821754e2f51e3ad32f M net
which seems completely bogus to me (I don't use nfs).
BTW, the bug is still present with 2.6.38.3 and seems more frequent with it.
Another detail is it occurs only one time during a session.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
next prev parent reply other threads:[~2011-04-26 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 18:57 [Bug 35935] New: since 2.6.38.1, screen become garbled after some times (RV770) bugzilla-daemon
2011-04-03 19:01 ` [Bug 35935] " bugzilla-daemon
2011-04-03 19:05 ` bugzilla-daemon
2011-04-03 23:59 ` bugzilla-daemon
2011-04-04 10:23 ` bugzilla-daemon
2011-04-26 21:20 ` bugzilla-daemon [this message]
2011-05-30 15:34 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110426212030.2122913004F@annarchy.freedesktop.org \
--to=bugzilla-daemon@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox