From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aurelien Jarno Subject: Re: [PATCH 1/2] drm/radeon: Use pci_dma_mapping_error() Date: Wed, 27 Apr 2011 12:08:06 +0200 Message-ID: <20110427100806.GA20115@volta.aurel32.net> References: <1303882443-7613-1-git-send-email-aurelien@aurel32.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dave Airlie Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Wed, Apr 27, 2011 at 05:49:50PM +1000, Dave Airlie wrote: > On Wed, Apr 27, 2011 at 3:34 PM, Aurelien Jarno wrote: > > ... instead of comparing with DMA_ERROR_CODE, which will only work on > > powerpc/sparc/x86. > > > > So you wrote a patch that breaks it everwhere? It seems I inverted the condition yes. > You might want to actually boot this sort of thing before I do, or > read the interface for pci_dma_mapping_error, it doesn't seem to > return what you seem to think it does. I tried, but I don't have such a card, so it doesn't trigger the bug. I'll send a v2 soon. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net