From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 3/3] drm: Factor-out drm_emit_vblank_event code. Date: Thu, 28 Apr 2011 13:36:17 -0700 Message-ID: <20110428133617.18026c59@jbarnes-desktop> References: <1303884659-739-1-git-send-email-christopher.halse.rogers@canonical.com> <1303884659-739-3-git-send-email-christopher.halse.rogers@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy3-pub.bluehost.com (oproxy3-pub.bluehost.com [69.89.21.8]) by gabe.freedesktop.org (Postfix) with SMTP id D48C59E980 for ; Thu, 28 Apr 2011 13:36:23 -0700 (PDT) In-Reply-To: <1303884659-739-3-git-send-email-christopher.halse.rogers@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: christopher.halse.rogers@canonical.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, 27 Apr 2011 16:10:59 +1000 christopher.halse.rogers@canonical.com wrote: > From: Christopher James Halse Rogers > > Signed-off-by: Christopher James Halse Rogers > --- > drivers/gpu/drm/drm_irq.c | 39 ++++++++++++++++----------------------- > 1 files changed, 16 insertions(+), 23 deletions(-) > Oh I see you already addressed my last comment. :) I think Michel is right about the put; the event queue holds the ref and the emit should drop it, so keeping them together seems good to me. Other than that, Reviewed-by: Jesse Barnes same for the first patch now that you've addressed my cleanup issue. -- Jesse Barnes, Intel Open Source Technology Center