From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] Pack swap complete bits into an XEvent Date: Thu, 28 Apr 2011 14:34:58 -0700 Message-ID: <20110428143458.627e0bb1@jbarnes-desktop> References: <1304022442-8070-1-git-send-email-jbarnes@virtuousgeek.org> <1304022442-8070-2-git-send-email-jbarnes@virtuousgeek.org> <87y62uhxh5.fsf@pollan.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87y62uhxh5.fsf-NuZ+OHacjZctnJUoGz2Qal6hYfS7NtTn@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org Errors-To: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org To: Eric Anholt Cc: xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org On Thu, 28 Apr 2011 14:33:58 -0700 Eric Anholt wrote: > On Thu, 28 Apr 2011 13:27:19 -0700, Jesse Barnes wrote: > > The defintion of the swap complete event was wrong; XEvents are only 32 > > bytes long, and with padding the swap event was longer. So use some > > creative packing to get all the bits we want transmitted. Requires a > > proto version bump. > > --- > > configure.ac | 2 +- > > glxproto.h | 13 +++++++++---- > > 2 files changed, 10 insertions(+), 5 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index d88e6df..a3047e4 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -1,5 +1,5 @@ > > AC_PREREQ([2.60]) > > -AC_INIT([GLProto], [1.4.12], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg]) > > +AC_INIT([GLProto], [1.4.13], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg]) > > AM_INIT_AUTOMAKE([foreign dist-bzip2]) > > AM_MAINTAINER_MODE > > > > diff --git a/glxproto.h b/glxproto.h > > index 0ff44e3..4a583c1 100644 > > --- a/glxproto.h > > +++ b/glxproto.h > > @@ -1370,18 +1370,23 @@ typedef struct { > > CARD32 unused2 B32; > > } xGLXPbufferClobberEvent; > > > > +/* Note, this struct is too large for an Xevent, I fail -- jbarnes > > + * So sbc_lo won't ever be sent. We can use a generic event though without > > + * size restrictions, thus xGLXBufferSwapComplete2. > > + */ > > This comment doesn't seem to match the change. double fail. will fix. -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel